updated create_or_update_import_data to use guard clause

1 files changed, 3 insertions, 1 deletions

diff --git a/app/models/project.rb b/app/models/project.rb
index 72c4f591420..7dc9f396e9e 100644
--- a/app/models/project.rb
+++ b/app/models/project.rb
@@ -465,7 +465,7 @@ class Project < ActiveRecord::Base
 
     import_url = Gitlab::UrlSanitizer.new(value)
     super(import_url.sanitized_url)
-    create_or_update_import_data(credentials: import_url.credentials) if valid_import_url?
+    create_or_update_import_data(credentials: import_url.credentials)
   end
 
   def import_url
@@ -482,6 +482,8 @@ class Project < ActiveRecord::Base
   end
 
   def create_or_update_import_data(data: nil, credentials: nil)
+    return unless valid_import_url?
+
     project_import_data = import_data || build_import_data
     if data
       project_import_data.data ||= {}