summaryrefslogtreecommitdiff
path: root/app/models/note.rb
diff options
context:
space:
mode:
authorDouwe Maan <douwe@selenight.nl>2016-01-22 01:43:06 +0100
committerDouwe Maan <douwe@selenight.nl>2016-01-22 01:47:17 +0100
commit150b4f66e6a244b5f6bd1119de3ce68336a9bf9e (patch)
tree5520435b90d8129c4013ae1d3d5e17a3f4c2d56a /app/models/note.rb
parent3f7993b5ceb9c5ba616dffef39f9b535482d92c1 (diff)
downloadgitlab-ce-150b4f66e6a244b5f6bd1119de3ce68336a9bf9e.tar.gz
Make sure non-highlighted diffs are still escapedunescaped-diffs
Diffstat (limited to 'app/models/note.rb')
-rw-r--r--app/models/note.rb8
1 files changed, 6 insertions, 2 deletions
diff --git a/app/models/note.rb b/app/models/note.rb
index 15f48110ad2..55255d22c2f 100644
--- a/app/models/note.rb
+++ b/app/models/note.rb
@@ -244,7 +244,7 @@ class Note < ActiveRecord::Base
prev_match_line = nil
prev_lines = []
- diff_lines.each do |line|
+ highlighted_diff_lines.each do |line|
if line.type == "match"
prev_lines.clear
prev_match_line = line
@@ -261,7 +261,11 @@ class Note < ActiveRecord::Base
end
def diff_lines
- @diff_lines ||= Gitlab::Diff::Parser.new.parse(diff.diff.lines.to_a)
+ @diff_lines ||= Gitlab::Diff::Parser.new.parse(diff.diff.lines)
+ end
+
+ def highlighted_diff_lines
+ Gitlab::Diff::Highlight.new(diff_lines).highlight
end
def discussion_id