diff options
| author | Fatih Acet <acetfatih@gmail.com> | 2016-08-31 20:26:12 +0000 |
|---|---|---|
| committer | Fatih Acet <acetfatih@gmail.com> | 2016-08-31 20:26:12 +0000 |
| commit | 286f10afb9c9945e37fb903009f823ba694a95b4 (patch) | |
| tree | 46383d2c3cf28aae61c02fb6751b8f4649666e12 /app/models/commit.rb | |
| parent | 35bcf73413c7a1b77b3797c7fecaf1e931db98b3 (diff) | |
| parent | 632899826bbb4d50f8c003b2c1771fa17d89d022 (diff) | |
| download | gitlab-ce-286f10afb9c9945e37fb903009f823ba694a95b4.tar.gz | |
Merge branch 'fix-todo-pagination' into 'master'
Fix bug where pagination is still displayed despite all todos marked as done
## What does this MR do?
Changes the todo `mark all as done` button callback to remove pagination and add user friendly text `"You're all done!"` so that it is consistent with what the page should look like after refreshing
## Are there points in the code the reviewer needs to double check?
Shouldn't be
## Why was this MR needed?
Resolve existing UI inconsistency
## Screenshots (if relevant)
Before:
After:
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #21048
See merge request !6113
Diffstat (limited to 'app/models/commit.rb')
0 files changed, 0 insertions, 0 deletions