summaryrefslogtreecommitdiff
path: root/app/controllers
diff options
context:
space:
mode:
authorGrzegorz Bizon <grzesiek.bizon@gmail.com>2016-04-18 12:00:47 +0200
committerGrzegorz Bizon <grzesiek.bizon@gmail.com>2016-04-19 12:15:56 +0200
commit66b6d82a3e2f3ea32cdd534f8bcbba8ed515ce2d (patch)
treea5a2e685a1779e399d0b5f1f523f1d01b02dbe7d /app/controllers
parentd177abb32b0b31ec27c51d0eb42e1ea131d64a03 (diff)
downloadgitlab-ce-66b6d82a3e2f3ea32cdd534f8bcbba8ed515ce2d.tar.gz
Use guard clause to check ability to share project
Diffstat (limited to 'app/controllers')
-rw-r--r--app/controllers/projects/group_links_controller.rb11
1 files changed, 4 insertions, 7 deletions
diff --git a/app/controllers/projects/group_links_controller.rb b/app/controllers/projects/group_links_controller.rb
index cd0f081cd7d..606552fa853 100644
--- a/app/controllers/projects/group_links_controller.rb
+++ b/app/controllers/projects/group_links_controller.rb
@@ -8,14 +8,11 @@ class Projects::GroupLinksController < Projects::ApplicationController
def create
group = Group.find(params[:link_group_id])
+ return render_404 unless can?(current_user, :read_group, group)
- if can?(current_user, :read_group, group)
- project.project_group_links.create(
- group: group, group_access: params[:link_group_access]
- )
- else
- return render_404
- end
+ project.project_group_links.create(
+ group: group, group_access: params[:link_group_access]
+ )
redirect_to namespace_project_group_links_path(project.namespace, project)
end