diff options
| author | Robert Speicher <robert@gitlab.com> | 2017-08-29 16:23:02 +0000 |
|---|---|---|
| committer | Robert Speicher <robert@gitlab.com> | 2017-08-29 16:23:02 +0000 |
| commit | 172cb70d4c427163895ec1792bd955f85748842d (patch) | |
| tree | 3f72e17f3beeac3547cbbbf28bfd0d1cda272e33 /app/controllers | |
| parent | 8e60636984d9f559f7e3cceee04be599b0df583f (diff) | |
| parent | 380dff622f83e199a08f37692395bfe3a3e5b437 (diff) | |
| download | gitlab-ce-172cb70d4c427163895ec1792bd955f85748842d.tar.gz | |
Merge branch '35793_fix_predicate_names' into 'master'
Remove `is_` prefix from predicate method names
See merge request !13810
Diffstat (limited to 'app/controllers')
| -rw-r--r-- | app/controllers/groups/milestones_controller.rb | 6 | ||||
| -rw-r--r-- | app/controllers/projects/issues_controller.rb | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/app/controllers/groups/milestones_controller.rb b/app/controllers/groups/milestones_controller.rb index 5c10d7bc261..7a7bcb1a3d2 100644 --- a/app/controllers/groups/milestones_controller.rb +++ b/app/controllers/groups/milestones_controller.rb @@ -35,13 +35,13 @@ class Groups::MilestonesController < Groups::ApplicationController end def edit - render_404 if @milestone.is_legacy_group_milestone? + render_404 if @milestone.legacy_group_milestone? end def update # Keep this compatible with legacy group milestones where we have to update # all projects milestones states at once. - if @milestone.is_legacy_group_milestone? + if @milestone.legacy_group_milestone? update_params = milestone_params.select { |key| key == "state_event" } milestones = @milestone.milestones else @@ -67,7 +67,7 @@ class Groups::MilestonesController < Groups::ApplicationController end def milestone_path - if @milestone.is_legacy_group_milestone? + if @milestone.legacy_group_milestone? group_milestone_path(group, @milestone.safe_title, title: @milestone.title) else group_milestone_path(group, @milestone.iid) diff --git a/app/controllers/projects/issues_controller.rb b/app/controllers/projects/issues_controller.rb index 8893a514207..1afaceac567 100644 --- a/app/controllers/projects/issues_controller.rb +++ b/app/controllers/projects/issues_controller.rb @@ -202,7 +202,7 @@ class Projects::IssuesController < Projects::ApplicationController task_status: @issue.task_status } - if @issue.is_edited? + if @issue.edited? response[:updated_at] = @issue.updated_at response[:updated_by_name] = @issue.last_edited_by.name response[:updated_by_path] = user_path(@issue.last_edited_by) |
