summaryrefslogtreecommitdiff
path: root/app/controllers/projects
diff options
context:
space:
mode:
authorZ.J. van de Weg <zegerjan@gitlab.com>2016-06-09 11:54:48 +0200
committerZ.J. van de Weg <zegerjan@gitlab.com>2016-06-15 19:17:55 +0200
commit17ad286e5db45c2d0d39fdceb8f201fe2e780a25 (patch)
tree118444adc1d19eecd4a17c8245bced3976413fad /app/controllers/projects
parent3fe4a2f525375a353755e0620988c33c85cd9f9e (diff)
downloadgitlab-ce-17ad286e5db45c2d0d39fdceb8f201fe2e780a25.tar.gz
Diffstat (limited to 'app/controllers/projects')
-rw-r--r--app/controllers/projects/merge_requests_controller.rb10
1 files changed, 5 insertions, 5 deletions
diff --git a/app/controllers/projects/merge_requests_controller.rb b/app/controllers/projects/merge_requests_controller.rb
index 49b1f3cec32..851822d805a 100644
--- a/app/controllers/projects/merge_requests_controller.rb
+++ b/app/controllers/projects/merge_requests_controller.rb
@@ -204,14 +204,14 @@ class Projects::MergeRequestsController < Projects::ApplicationController
@merge_request.update(merge_error: nil)
- if params[:merge_when_build_succeeds].present? && @merge_request.pipeline && @merge_request.pipeline.active?
- if @merge_request.ci_commit.active?
+ if params[:merge_when_build_succeeds].present?
+ if @merge_request.pipeline && @merge_request.pipeline.active?
MergeRequests::MergeWhenBuildSucceedsService.new(@project, current_user, merge_params)
.execute(@merge_request)
@status = :merge_when_build_succeeds
- # This can be triggered when a user clicks the auto merge button while
- # the tests finish at about the same time
- elsif @merge_request.ci_commit.success?
+ elsif @merge_request.pipeline.success?
+ # This can be triggered when a user clicks the auto merge button while
+ # the tests finish at about the same time
MergeWorker.perform_async(@merge_request.id, current_user.id, params)
@status = :success
else