diff options
| author | blackst0ne <blackst0ne.ru@gmail.com> | 2017-06-07 09:45:16 +1100 |
|---|---|---|
| committer | blackst0ne <blackst0ne.ru@gmail.com> | 2017-06-07 09:45:16 +1100 |
| commit | a544e46bb083c27bfa2966ea67ddf97b5dc7cb08 (patch) | |
| tree | 14ffd0a5844127e7a63786a5e695832cc356ab2c /app/controllers/projects/variables_controller.rb | |
| parent | 71f9c43c833531fb6e2231225b74a42dea4ae00c (diff) | |
| download | gitlab-ce-a544e46bb083c27bfa2966ea67ddf97b5dc7cb08.tar.gz | |
Add a rubocop rule to check if a method 'redirect_to' is used without explicitly set 'status' in 'destroy' actions of controllers31840-add-a-rubocop-that-forbids-redirect_to-inside-a-controller-destroy-action-without-an-explicit-status
Diffstat (limited to 'app/controllers/projects/variables_controller.rb')
| -rw-r--r-- | app/controllers/projects/variables_controller.rb | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/app/controllers/projects/variables_controller.rb b/app/controllers/projects/variables_controller.rb index 0953eecaeb5..50e25a00f03 100644 --- a/app/controllers/projects/variables_controller.rb +++ b/app/controllers/projects/variables_controller.rb @@ -36,7 +36,9 @@ class Projects::VariablesController < Projects::ApplicationController @key = @project.variables.find(params[:id]) @key.destroy - redirect_to namespace_project_settings_ci_cd_path(project.namespace, project), notice: 'Variable was successfully removed.' + redirect_to namespace_project_settings_ci_cd_path(project.namespace, project), + status: 302, + notice: 'Variable was successfully removed.' end private |