diff options
author | Luke "Jared" Bennett <lbennett@gitlab.com> | 2017-10-27 20:42:57 +0100 |
---|---|---|
committer | Luke "Jared" Bennett <lbennett@gitlab.com> | 2017-10-27 20:43:04 +0100 |
commit | 2f130527c0959df1a79d8a4bec648b8f3ead73ca (patch) | |
tree | e1779443f8ad6a1510486863d23f2f685036ef5f /app/assets | |
parent | b5079721bfff6fd36d79da9c6ab22bfd9009f752 (diff) | |
download | gitlab-ce-2f130527c0959df1a79d8a4bec648b8f3ead73ca.tar.gz |
FE review changes - remove internal details assertion and look for closest form if no discussion_line_code
Diffstat (limited to 'app/assets')
-rw-r--r-- | app/assets/javascripts/notes.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/assets/javascripts/notes.js b/app/assets/javascripts/notes.js index 7f163e7e0e8..b111c117556 100644 --- a/app/assets/javascripts/notes.js +++ b/app/assets/javascripts/notes.js @@ -415,7 +415,7 @@ export default class Notes { this.note_ids.push(noteEntity.id); form = $form || $(`.js-discussion-note-form[data-discussion-id="${noteEntity.discussion_id}"]`); - row = form.length ? form.closest('tr') : $(`#${noteEntity.discussion_line_code}`); + row = (form.length || !noteEntity.discussion_line_code) ? form.closest('tr') : $(`#${noteEntity.discussion_line_code}`); if (noteEntity.on_image) { row = form; |