diff options
author | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2015-05-02 07:34:58 +0000 |
---|---|---|
committer | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2015-05-02 07:34:58 +0000 |
commit | cfbff017d0ba1ba4fd896b4762b23853f123c60a (patch) | |
tree | 1f381ccc24888ccbd82a8b220ad1254fc5be7afb /CHANGELOG | |
parent | 812c7a85df81c526b6f21de8c057eb3ba0c20874 (diff) | |
parent | a2eee3181c6b0fc3ef8b95f3187704a2b12774e4 (diff) | |
download | gitlab-ce-cfbff017d0ba1ba4fd896b4762b23853f123c60a.tar.gz |
Merge branch 'you-get-a-title-and-you-get-a-title-and-everyone-gets-a-title' into 'master'
Add a page title to every page.
![You get a title, and you get a title; everyone gets a title!](https://i.imgflip.com/kvmq8.jpg)
The `page_title` helper pushes the provided string at the end of the title, but because of the order that layouts are rendered in by ActionView, the result is always this:
```
<title from view> |
<title from as specified in the controller or by its layout> |
<title from layouts/_head>
```
For example: `Merge Requests | GitLab.org / Gitlab Community Edition | GitLab`.
All a developer needs to know is to put a `page_title` call describing the page in question at the start of every template.
To get everything where I wanted it to go without too much duplication, I had to make some changes around layouts, sidebars and controllers.
See merge request !593
Diffstat (limited to 'CHANGELOG')
-rw-r--r-- | CHANGELOG | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/CHANGELOG b/CHANGELOG index 2364cf5d7fa..2c5c9c76ccf 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -2,6 +2,7 @@ Please view this file on the master branch, on stable branches it's out of date. v 7.11.0 (unreleased) - Don't allow a merge request to be merged when its title starts with "WIP". + - Add a page title to every page. - Get Gitorious importer to work again. - Fix clone URL field and X11 Primary selection (Dmitry Medvinsky) - Ignore invalid lines in .gitmodules |