summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThong Kuah <tkuah@gitlab.com>2019-07-01 22:10:15 +1200
committerThong Kuah <tkuah@gitlab.com>2019-07-08 09:14:37 +1200
commit25ba11a2aad9571e4759cdc711199634e3392c5b (patch)
treec68aae18a695f1412c141b91835e1ce4e304ddd6
parenta2cd33d1baa3de0774ebfcff2e6bbffffcb5d025 (diff)
downloadgitlab-ce-25ba11a2aad9571e4759cdc711199634e3392c5b.tar.gz
Remove un-used method
We stopped calling the fallback so we can remove this now
-rw-r--r--app/models/deployment.rb5
-rw-r--r--spec/models/deployment_spec.rb28
2 files changed, 0 insertions, 33 deletions
diff --git a/app/models/deployment.rb b/app/models/deployment.rb
index ad32ec3f1d5..b69cda4f2f9 100644
--- a/app/models/deployment.rb
+++ b/app/models/deployment.rb
@@ -85,11 +85,6 @@ class Deployment < ApplicationRecord
Commit.truncate_sha(sha)
end
- # Deprecated - will be replaced by a persisted cluster_id
- def deployment_platform_cluster
- environment.deployment_platform&.cluster
- end
-
def execute_hooks
deployment_data = Gitlab::DataBuilder::Deployment.build(self)
project.execute_services(deployment_data, :deployment_hooks)
diff --git a/spec/models/deployment_spec.rb b/spec/models/deployment_spec.rb
index 79647c5719c..d4e631f109b 100644
--- a/spec/models/deployment_spec.rb
+++ b/spec/models/deployment_spec.rb
@@ -322,32 +322,4 @@ describe Deployment do
end
end
end
-
- describe '#deployment_platform_cluster' do
- let(:deployment) { create(:deployment) }
- let(:project) { deployment.project }
- let(:environment) { deployment.environment }
-
- subject { deployment.deployment_platform_cluster }
-
- before do
- expect(project).to receive(:deployment_platform)
- .with(environment: environment.name).and_call_original
- end
-
- context 'project has no deployment platform' do
- before do
- expect(project.clusters).to be_empty
- end
-
- it { is_expected.to be_nil }
- end
-
- context 'project has a deployment platform' do
- let!(:cluster) { create(:cluster, projects: [project]) }
- let!(:platform) { create(:cluster_platform_kubernetes, cluster: cluster) }
-
- it { is_expected.to eq cluster }
- end
- end
end