diff options
| author | Phil Hughes <me@iamphill.com> | 2016-06-22 08:43:54 +0100 |
|---|---|---|
| committer | Phil Hughes <me@iamphill.com> | 2016-06-22 08:43:54 +0100 |
| commit | 5a09745534fd7ae04595a45f33297c0185a81b16 (patch) | |
| tree | 16106129ebf62110c2889d7e87bb3e4f95cacc75 | |
| parent | 9676421d0142277e8c1c31eecb8c33118dceb79f (diff) | |
| download | gitlab-ce-5a09745534fd7ae04595a45f33297c0185a81b16.tar.gz | |
Use jQuery objects in ref dropdown
| -rw-r--r-- | app/assets/javascripts/gl_dropdown.js.coffee | 7 | ||||
| -rw-r--r-- | app/assets/javascripts/project.js.coffee | 21 |
2 files changed, 16 insertions, 12 deletions
diff --git a/app/assets/javascripts/gl_dropdown.js.coffee b/app/assets/javascripts/gl_dropdown.js.coffee index 2a7bf0bc306..41ca2462424 100644 --- a/app/assets/javascripts/gl_dropdown.js.coffee +++ b/app/assets/javascripts/gl_dropdown.js.coffee @@ -280,7 +280,7 @@ class GitLabDropdown html = @renderData(data) # Render the full menu - full_html = @renderMenu(html.join("")) + full_html = @renderMenu(html) @appendMenu(full_html) @@ -351,7 +351,8 @@ class GitLabDropdown if @options.renderMenu menu_html = @options.renderMenu(html) else - menu_html = "<ul>#{html}</ul>" + menu_html = $('<ul />') + .append(html) return menu_html @@ -360,7 +361,7 @@ class GitLabDropdown selector = '.dropdown-content' if @dropdown.find(".dropdown-toggle-page").length selector = ".dropdown-page-one .dropdown-content" - $(selector, @dropdown).html html + $(selector, @dropdown).append html # Render the row renderItem: (data, group = false, index = false) -> diff --git a/app/assets/javascripts/project.js.coffee b/app/assets/javascripts/project.js.coffee index 96e10dd7e8a..707178d1268 100644 --- a/app/assets/javascripts/project.js.coffee +++ b/app/assets/javascripts/project.js.coffee @@ -70,17 +70,20 @@ class @Project fieldName: 'ref' renderRow: (ref) -> if ref.header? - "<li class='dropdown-header'>#{ref.header}</li>" + $('<li />') + .addClass 'dropdown-header' + .text ref.header else - isActiveClass = if ref is selected then 'is-active' else '' - - "<li> - <a href='#' data-ref='#{escape(ref)}' class='#{isActiveClass}'> - #{ref} - </a> - </li>" + link = $('<a />') + .attr 'href', '#' + .addClass(if ref is selected then 'is-active' else '') + .text ref + .attr 'data-ref', escape(ref) + + $('<li />') + .append link id: (obj, $el) -> - $el.data('ref') + $el.attr('data-ref') toggleLabel: (obj, $el) -> $el.text().trim() clicked: (e) -> |