diff options
| author | Bob Van Landuyt <bob@gitlab.com> | 2019-08-15 08:04:38 +0000 |
|---|---|---|
| committer | Bob Van Landuyt <bob@gitlab.com> | 2019-08-15 08:04:38 +0000 |
| commit | fe0ab065c4da9867683a013c1c22b1ff0a6d8273 (patch) | |
| tree | 7bb1c3336122e0af0a9eeaa77b085b1585e9bb1a | |
| parent | 9d16806fc41b41253abb60a4c69ecdee507ae666 (diff) | |
| parent | dd84b9a03d24d27edafc861a988239de30f08a46 (diff) | |
| download | gitlab-ce-fe0ab065c4da9867683a013c1c22b1ff0a6d8273.tar.gz | |
Merge branch 'allow-focus-in-specs' into 'master'
Allow to use focus: true in specs
See merge request gitlab-org/gitlab-ce!31691
| -rw-r--r-- | doc/development/testing_guide/best_practices.md | 1 | ||||
| -rw-r--r-- | spec/spec_helper.rb | 3 |
2 files changed, 4 insertions, 0 deletions
diff --git a/doc/development/testing_guide/best_practices.md b/doc/development/testing_guide/best_practices.md index 448d9fd01c4..9d6792e9139 100644 --- a/doc/development/testing_guide/best_practices.md +++ b/doc/development/testing_guide/best_practices.md @@ -70,6 +70,7 @@ bundle exec rspec spec/[path]/[to]/[spec].rb - On `before` and `after` hooks, prefer it scoped to `:context` over `:all` - When using `evaluate_script("$('.js-foo').testSomething()")` (or `execute_script`) which acts on a given element, use a Capyabara matcher beforehand (e.g. `find('.js-foo')`) to ensure the element actually exists. +- Use `focus: true` to isolate parts of the specs you want to run. [four-phase-test]: https://robots.thoughtbot.com/four-phase-test diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index bcc133790d1..bd504f1553b 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -48,6 +48,9 @@ Dir[Rails.root.join("spec/support/**/*.rb")].each { |f| require f } quality_level = Quality::TestLevel.new RSpec.configure do |config| + config.filter_run focus: true + config.run_all_when_everything_filtered = true + config.use_transactional_fixtures = true config.use_instantiated_fixtures = false config.fixture_path = Rails.root |