summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon Knox <simon@gitlab.com>2017-09-21 11:39:04 +0000
committerSimon Knox <simon@gitlab.com>2017-09-21 11:39:04 +0000
commitb5145eabf1ee71ab280e6ff5bb39bea25e1b02a1 (patch)
tree50e2bd42e41c2cc2a435873ecc63b4f1eb0daf72
parenteec0e52fb568ae187f4137b8f46f70fc9acc3a32 (diff)
downloadgitlab-ce-b5145eabf1ee71ab280e6ff5bb39bea25e1b02a1.tar.gz
Update style_guide_js.md
-rw-r--r--doc/development/fe_guide/style_guide_js.md4
1 files changed, 2 insertions, 2 deletions
diff --git a/doc/development/fe_guide/style_guide_js.md b/doc/development/fe_guide/style_guide_js.md
index b7375128908..7d79f718cb0 100644
--- a/doc/development/fe_guide/style_guide_js.md
+++ b/doc/development/fe_guide/style_guide_js.md
@@ -525,9 +525,9 @@ On those a default key should not be provided.
### The Javascript/Vue Accord
The goal of this accord is to make sure we are all on the same page.
-1. When writing Vue, you may not use jQuery in your application.
+1. When writing Vue, you may not use jQuery in your application.
1. If you need to grab data from the DOM, you may query the DOM once while bootstrapping your application to grab data attributes using `dataset`. You can do this without jQuery.
- 1. You may use a jQuery dependency in Vue.js following [this example from the docs](https://vuejs.org/v2/examples/select2.html).
+ 1. You may use a jQuery dependency in Vue.js following [this example from the docs](https://vuejs.org/v2/examples/select2.html).
1. If an outside jQuery Event needs to be listen to inside the Vue application, you may use jQuery event listeners.
1. We will avoid adding new jQuery events when they are not required. Instead of adding new jQuery events take a look at [different methods to do the same task](https://vuejs.org/v2/api/#vm-emit).
1. You may query the `window` object once, while bootstrapping your application for application specific data (e.g. `scrollTo` is ok to access anytime). Do this access during the bootstrapping of your application.