diff options
| author | Fatih Acet <acetfatih@gmail.com> | 2016-06-28 15:29:45 +0000 |
|---|---|---|
| committer | Fatih Acet <acetfatih@gmail.com> | 2016-06-28 15:29:45 +0000 |
| commit | 7a94432e18f5210abda85721810ca2a4e573de5d (patch) | |
| tree | 16d404b234bc18acb7e7f11e0d06e07176f3a68a | |
| parent | 1ade080ec89eb6be67a03dc82a1002ad7fd9d51c (diff) | |
| parent | b5fa56eb3f2cea5e21c68b43c7c22b5b96e0e7b3 (diff) | |
| download | gitlab-ce-7a94432e18f5210abda85721810ca2a4e573de5d.tar.gz | |
Merge branch 'remove-gon-variable' into 'master'
Unused gon variable with very bad performance
## What does this MR do?
Remove an unused variable with a lot of performance penalty. It was opening a transaction just to return a constant string.
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
See merge request !4969
| -rw-r--r-- | CHANGELOG | 1 | ||||
| -rw-r--r-- | lib/gitlab/gon_helper.rb | 1 |
2 files changed, 1 insertions, 1 deletions
diff --git a/CHANGELOG b/CHANGELOG index 15d247ded95..b0c7c528e38 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -13,6 +13,7 @@ v 8.10.0 (unreleased) - Fix changing issue state columns in milestone view - Fix user creation with stronger minimum password requirements !4054 (nathan-pmt) - Check for conflicts with existing Project's wiki path when creating a new project. + - Remove unused front-end variable -> default_issues_tracker - Add API endpoint for a group issues !4520 (mahcsig) - Allow [ci skip] to be in any case and allow [skip ci]. !4785 (simon_w) diff --git a/lib/gitlab/gon_helper.rb b/lib/gitlab/gon_helper.rb index f751a3a12fd..d4f12cb1df9 100644 --- a/lib/gitlab/gon_helper.rb +++ b/lib/gitlab/gon_helper.rb @@ -3,7 +3,6 @@ module Gitlab def add_gon_variables gon.api_version = API::API.version gon.default_avatar_url = URI::join(Gitlab.config.gitlab.url, ActionController::Base.helpers.image_path('no_avatar.png')).to_s - gon.default_issues_tracker = Project.new.default_issue_tracker.to_param gon.max_file_size = current_application_settings.max_attachment_size gon.relative_url_root = Gitlab.config.gitlab.relative_url_root gon.shortcuts_path = help_shortcuts_path |