diff options
author | Nihad Abbasov <narkoz.2008@gmail.com> | 2013-05-07 00:09:23 +0500 |
---|---|---|
committer | Nihad Abbasov <narkoz.2008@gmail.com> | 2013-05-07 00:09:23 +0500 |
commit | 77d0e41df00c45aaafdec5fd6cdddce003c29445 (patch) | |
tree | e75df356b263caf2a1fe9ec42da01ee08c394414 | |
parent | 8b65d069cce294ddc3450862e8066b1dbf6695da (diff) | |
download | gitlab-ce-77d0e41df00c45aaafdec5fd6cdddce003c29445.tar.gz |
fix API route to delete project hook
-rw-r--r-- | lib/api/projects.rb | 2 | ||||
-rw-r--r-- | spec/requests/api/projects_spec.rb | 8 |
2 files changed, 5 insertions, 5 deletions
diff --git a/lib/api/projects.rb b/lib/api/projects.rb index 53fd91dcca8..18e912ff48e 100644 --- a/lib/api/projects.rb +++ b/lib/api/projects.rb @@ -274,7 +274,7 @@ module Gitlab # hook_id (required) - The ID of hook to delete # Example Request: # DELETE /projects/:id/hooks/:hook_id - delete ":id/hooks" do + delete ":id/hooks/:hook_id" do authorize! :admin_project, user_project required_attributes! [:hook_id] diff --git a/spec/requests/api/projects_spec.rb b/spec/requests/api/projects_spec.rb index a3620d0a6a5..4fd6d5ab0f1 100644 --- a/spec/requests/api/projects_spec.rb +++ b/spec/requests/api/projects_spec.rb @@ -467,21 +467,21 @@ describe Gitlab::API do end end - describe "DELETE /projects/:id/hooks" do + describe "DELETE /projects/:id/hooks/:hook_id" do it "should delete hook from project" do expect { - delete api("/projects/#{project.id}/hooks", user), hook_id: hook.id + delete api("/projects/#{project.id}/hooks/#{hook.id}", user) }.to change {project.hooks.count}.by(-1) response.status.should == 200 end it "should return success when deleting hook" do - delete api("/projects/#{project.id}/hooks", user), hook_id: hook.id + delete api("/projects/#{project.id}/hooks/#{hook.id}", user) response.status.should == 200 end it "should return success when deleting non existent hook" do - delete api("/projects/#{project.id}/hooks", user), hook_id: 42 + delete api("/projects/#{project.id}/hooks/42", user) response.status.should == 200 end |