diff options
author | Clement Ho <clemmakesapps@gmail.com> | 2017-12-07 17:52:33 +0000 |
---|---|---|
committer | Clement Ho <clemmakesapps@gmail.com> | 2017-12-07 17:52:33 +0000 |
commit | be8ca260dadae948d09a87664baed8c85d133434 (patch) | |
tree | eabe4f1ed28017aff3053ce5ef1416fe711a659a | |
parent | bd44feea23c07bd7592753cc90605afd81352cdc (diff) | |
parent | 1c42ea529b48219481a40f523ebc0da7af644a46 (diff) | |
download | gitlab-ce-be8ca260dadae948d09a87664baed8c85d133434.tar.gz |
Merge branch '40715-updateendpoint-undefined-on-issue-page' into 'master'
Resolve "updateEndpoint undefined on Issue page"
Closes #40715
See merge request gitlab-org/gitlab-ce!15698
-rw-r--r-- | app/assets/javascripts/issue_show/index.js | 27 | ||||
-rw-r--r-- | changelogs/unreleased/40715-updateendpoint-undefined-on-issue-page.yml | 5 |
2 files changed, 7 insertions, 25 deletions
diff --git a/app/assets/javascripts/issue_show/index.js b/app/assets/javascripts/issue_show/index.js index aca9dec2a96..a21ce41e65e 100644 --- a/app/assets/javascripts/issue_show/index.js +++ b/app/assets/javascripts/issue_show/index.js @@ -5,7 +5,7 @@ import '../vue_shared/vue_resource_interceptor'; document.addEventListener('DOMContentLoaded', () => { const initialDataEl = document.getElementById('js-issuable-app-initial-data'); - const initialData = JSON.parse(initialDataEl.innerHTML.replace(/"/g, '"')); + const props = JSON.parse(initialDataEl.innerHTML.replace(/"/g, '"')); $('.issuable-edit').on('click', (e) => { e.preventDefault(); @@ -18,32 +18,9 @@ document.addEventListener('DOMContentLoaded', () => { components: { issuableApp, }, - data() { - return { - ...initialData, - }; - }, render(createElement) { return createElement('issuable-app', { - props: { - canUpdate: this.canUpdate, - canDestroy: this.canDestroy, - endpoint: this.endpoint, - issuableRef: this.issuableRef, - initialTitleHtml: this.initialTitleHtml, - initialTitleText: this.initialTitleText, - initialDescriptionHtml: this.initialDescriptionHtml, - initialDescriptionText: this.initialDescriptionText, - issuableTemplates: this.issuableTemplates, - markdownPreviewPath: this.markdownPreviewPath, - markdownDocsPath: this.markdownDocsPath, - projectPath: this.projectPath, - projectNamespace: this.projectNamespace, - updatedAt: this.updatedAt, - updatedByName: this.updatedByName, - updatedByPath: this.updatedByPath, - initialTaskStatus: this.initialTaskStatus, - }, + props, }); }, }); diff --git a/changelogs/unreleased/40715-updateendpoint-undefined-on-issue-page.yml b/changelogs/unreleased/40715-updateendpoint-undefined-on-issue-page.yml new file mode 100644 index 00000000000..0328a693354 --- /dev/null +++ b/changelogs/unreleased/40715-updateendpoint-undefined-on-issue-page.yml @@ -0,0 +1,5 @@ +--- +title: Fix updateEndpoint undefined error for issue_show app root +merge_request: 15698 +author: +type: fixed |