diff options
author | Andrey Vakarev <avakarev@gmail.com> | 2012-05-20 03:01:13 +0300 |
---|---|---|
committer | Andrey Vakarev <avakarev@gmail.com> | 2012-05-20 03:01:13 +0300 |
commit | fed1c9804744fa20bfda47d269a4b0b566754ba3 (patch) | |
tree | 7c7efb225544dc38b61a31dd05e90af484bac5f2 | |
parent | f33cf247b6387a5a0f33a4ccb4867ab2d2f14d4e (diff) | |
download | gitlab-ce-fed1c9804744fa20bfda47d269a4b0b566754ba3.tar.gz |
Refactoring: get rid of ruby antipattern unless/else and use if/else instead
-rw-r--r-- | app/controllers/application_controller.rb | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index 17bcef4bb23..8dd407ac16b 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -97,12 +97,12 @@ class ApplicationController < ActionController::Base end def load_refs - unless params[:ref].blank? - @ref = params[:ref] - else + if params[:ref].blank? @branch = params[:branch].blank? ? nil : params[:branch] @tag = params[:tag].blank? ? nil : params[:tag] @ref = @branch || @tag || @project.try(:default_branch) || Repository.default_ref + else + @ref = params[:ref] end end |