summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Speicher <robert@gitlab.com>2015-05-07 21:51:51 +0000
committerRobert Speicher <robert@gitlab.com>2015-05-07 21:51:51 +0000
commitc4aa700398173b80131a00a0e7dd3badd454bc22 (patch)
tree7a0725dabd8d4aa4dbac4bfdfe8e9f5eb3c84f8f
parentf5f097b765e6401ad379e313b4c34cd37d248930 (diff)
parent5ed7a39dc7aeff97bd7dceb9e125b352223e29a3 (diff)
downloadgitlab-ce-c4aa700398173b80131a00a0e7dd3badd454bc22.tar.gz
Merge branch 'rs-fix-filter-tooltips' into 'master'
Fix tooltips for event filter links See merge request !618
-rw-r--r--app/helpers/events_helper.rb12
1 files changed, 8 insertions, 4 deletions
diff --git a/app/helpers/events_helper.rb b/app/helpers/events_helper.rb
index c9fd0f0362b..18c75a8726b 100644
--- a/app/helpers/events_helper.rb
+++ b/app/helpers/events_helper.rb
@@ -25,12 +25,16 @@ module EventsHelper
def event_filter_link(key, tooltip)
key = key.to_s
- active = if @event_filter.active? key
- 'active'
- end
+ active = 'active' if @event_filter.active?(key)
+ link_opts = {
+ class: 'event_filter_link',
+ id: "#{key}_event_filter",
+ title: "Filter by #{tooltip.downcase}",
+ data: { toggle: 'tooltip', placement: 'top' }
+ }
content_tag :li, class: "filter_icon #{active}" do
- link_to request.path, class: 'has_tooltip event_filter_link', id: "#{key}_event_filter", 'data-original-title' => 'Filter by ' + tooltip.downcase do
+ link_to request.path, link_opts do
icon(icon_for_event[key]) + content_tag(:span, ' ' + tooltip)
end
end