diff options
| author | Dmitriy Zaporozhets <dzaporozhets@gitlab.com> | 2014-12-23 09:06:52 +0000 |
|---|---|---|
| committer | Dmitriy Zaporozhets <dzaporozhets@gitlab.com> | 2014-12-23 09:06:52 +0000 |
| commit | b9e2e116a1af02a5e883a3dc48d9538239be5497 (patch) | |
| tree | 2711e5bbd8e385a3d61b0cb4dfc0b054816abf2c | |
| parent | 73885c31d6153c2b4ce5039970d51f0802df12ba (diff) | |
| parent | c5a1b808393d5b3769db0d65214df1645b69f6bf (diff) | |
| download | gitlab-ce-b9e2e116a1af02a5e883a3dc48d9538239be5497.tar.gz | |
Merge branch 'migrations-separate' into 'master'
Migrations separate
Sytse will tweet on merge.
See merge request !1343
| -rw-r--r-- | CONTRIBUTING.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 9531b27089b..be3b8bb5e2d 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -118,6 +118,7 @@ Please ensure you support the feature you contribute through all of these steps. 1. Can merge without problems (if not please merge `master`, never rebase commits pushed to the remote server) 1. Does not break any existing functionality 1. Fixes one specific issue or implements one specific feature (do not combine things, send separate merge requests if needed) +1. Migrations should do only one thing (eg: either create a table, move data to a new table or remove an old table) to aid retrying on failure 1. Keeps the GitLab code base clean and well structured 1. Contains functionality we think other users will benefit from too 1. Doesn't add configuration options since they complicate future changes |