summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLin Jen-Shin <godfat@godfat.org>2016-07-20 22:42:14 +0800
committerLin Jen-Shin <godfat@godfat.org>2016-07-20 22:42:14 +0800
commit782b384f8a738ecffef27b0651d986a9823045e9 (patch)
treebae6b31a24663c1c16e3d3f57eaa025a99bb8a8d
parentff3776c8d5a84f7ea6b1b50ad8c7add02d3f0434 (diff)
downloadgitlab-ce-782b384f8a738ecffef27b0651d986a9823045e9.tar.gz
Rename user2 to reporter_user
-rw-r--r--spec/requests/api/builds_spec.rb10
1 files changed, 5 insertions, 5 deletions
diff --git a/spec/requests/api/builds_spec.rb b/spec/requests/api/builds_spec.rb
index 43fb2edb730..e110699596c 100644
--- a/spec/requests/api/builds_spec.rb
+++ b/spec/requests/api/builds_spec.rb
@@ -5,11 +5,11 @@ describe API::API, api: true do
let(:user) { create(:user) }
let(:api_user) { user }
- let(:user2) { create(:user) }
+ let(:reporter_user) { create(:user) }
let(:guest_user) { create(:user) }
let!(:project) { create(:project, creator_id: user.id) }
let!(:developer) { create(:project_member, :developer, user: user, project: project) }
- let!(:reporter) { create(:project_member, :reporter, user: user2, project: project) }
+ let!(:reporter) { create(:project_member, :reporter, user: reporter_user, project: project) }
let!(:guest) { create(:project_member, :guest, user: guest_user, project: project) }
let!(:pipeline) { create(:ci_pipeline, project: project, sha: project.commit.id, ref: project.default_branch) }
let!(:build) { create(:ci_build, pipeline: pipeline) }
@@ -175,7 +175,7 @@ describe API::API, api: true do
end
describe 'GET /projects/:id/artifacts/:ref_name/download?job=name' do
- let(:api_user) { user2 } # is a reporter of the project
+ let(:api_user) { reporter_user }
let(:build) { create(:ci_build, :success, :artifacts, pipeline: pipeline) }
def path_for_ref(ref = pipeline.ref, job = build.name)
@@ -301,7 +301,7 @@ describe API::API, api: true do
end
context 'user without :update_build permission' do
- let(:api_user) { user2 }
+ let(:api_user) { reporter_user }
it 'should not cancel build' do
expect(response).to have_http_status(403)
@@ -333,7 +333,7 @@ describe API::API, api: true do
end
context 'user without :update_build permission' do
- let(:api_user) { user2 }
+ let(:api_user) { reporter_user }
it 'should not retry build' do
expect(response).to have_http_status(403)