Matching version-like expressions as `milestone_name`s instead of `milestone_iid`s

The changes also account for %2.1. being matched as milestone_name = "2.1" without
the word-separating dot.

1 files changed, 8 insertions, 3 deletions

diff --git a/app/models/milestone.rb b/app/models/milestone.rb
index 50fa95d4d4b..92c07fd20da 100644
--- a/app/models/milestone.rb
+++ b/app/models/milestone.rb
@@ -79,14 +79,19 @@ class Milestone < ActiveRecord::Base
   end
 
   def self.reference_pattern
+    # NOTE: The iid pattern only matches when all characters on the expression
+    # are digits, so it will match %2 but not %2.1 because that's probably a
+    # milestone name and we want it to be matched as such.
     %r{
       (#{Project.reference_pattern})?
       #{Regexp.escape(reference_prefix)}
       (?:
-        (?<milestone_iid>\d+) | # Integer-based milestone iid, or
+        (?<milestone_iid>
+          \d+(?!\S\w)\b # Integer-based milestone iid, or
+        ) |
         (?<milestone_name>
-          [A-Za-z0-9_-]+ |      # String-based single-word milestone title, or
-          "[^"]+"               # String-based multi-word milestone surrounded in quotes
+          [^"\s]+\b |  # String-based single-word milestone title, or
+          "[^"]+"      # String-based multi-word milestone surrounded in quotes
         )
       )
     }x