diff options
author | Kamil Trzciński <ayufan@ayufan.eu> | 2017-11-14 10:46:07 +0000 |
---|---|---|
committer | Kamil Trzciński <ayufan@ayufan.eu> | 2017-11-14 10:46:07 +0000 |
commit | 6b9b516007c8dda88f33e9603a6880e3fc3ff103 (patch) | |
tree | c6b9ddc30d54cc043bf474c69f5812268623fe7f | |
parent | 8902bdec4d54de0e50657c897a9ade413c443924 (diff) | |
parent | c00fde606ee2d8f87a13c801efc3278396f6bb7f (diff) | |
download | gitlab-ce-6b9b516007c8dda88f33e9603a6880e3fc3ff103.tar.gz |
Merge branch '39884-fix-pipeline-transition-with-single-manual-action' into 'master'
Make sure all pipelines would go to pending once
Closes #39884
See merge request gitlab-org/gitlab-ce!15251
-rw-r--r-- | app/models/ci/pipeline.rb | 4 | ||||
-rw-r--r-- | changelogs/unreleased/39884-fix-pipeline-transition-with-single-manual-action.yml | 6 | ||||
-rw-r--r-- | spec/services/ci/process_pipeline_service_spec.rb | 24 |
3 files changed, 32 insertions, 2 deletions
diff --git a/app/models/ci/pipeline.rb b/app/models/ci/pipeline.rb index fcbe3d2b67b..19814864e50 100644 --- a/app/models/ci/pipeline.rb +++ b/app/models/ci/pipeline.rb @@ -66,8 +66,8 @@ module Ci state_machine :status, initial: :created do event :enqueue do - transition created: :pending - transition [:success, :failed, :canceled, :skipped] => :running + transition [:created, :skipped] => :pending + transition [:success, :failed, :canceled] => :running end event :run do diff --git a/changelogs/unreleased/39884-fix-pipeline-transition-with-single-manual-action.yml b/changelogs/unreleased/39884-fix-pipeline-transition-with-single-manual-action.yml new file mode 100644 index 00000000000..580b97241e7 --- /dev/null +++ b/changelogs/unreleased/39884-fix-pipeline-transition-with-single-manual-action.yml @@ -0,0 +1,6 @@ +--- +title: Fix pipeline status transition for single manual job. This would also fix pipeline + duration becuse it is depending on status transition +merge_request: 15251 +author: +type: fixed diff --git a/spec/services/ci/process_pipeline_service_spec.rb b/spec/services/ci/process_pipeline_service_spec.rb index 214adc9960f..0ce41e7c7ee 100644 --- a/spec/services/ci/process_pipeline_service_spec.rb +++ b/spec/services/ci/process_pipeline_service_spec.rb @@ -292,6 +292,30 @@ describe Ci::ProcessPipelineService, '#execute' do end end + context 'when there is only one manual action' do + before do + create_build('deploy', stage_idx: 0, when: 'manual', allow_failure: true) + + process_pipeline + end + + it 'skips the pipeline' do + expect(pipeline.reload).to be_skipped + end + + context 'when the action was played' do + before do + play_manual_action('deploy') + end + + it 'queues the action and pipeline' do + expect(all_builds_statuses).to eq(%w[pending]) + + expect(pipeline.reload).to be_pending + end + end + end + context 'when blocking manual actions are defined' do before do create_build('code:test', stage_idx: 0) |