summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>2017-06-26 17:00:07 +0200
committerDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>2017-06-26 17:00:07 +0200
commit0aa5f08988547678c2a32a5ad85332bbc165d3bf (patch)
tree738537c24975838dad5d63e55c5506fdbc42299e
parent69043814b40fb1203e77c75b4bb082dd67501222 (diff)
downloadgitlab-ce-0aa5f08988547678c2a32a5ad85332bbc165d3bf.tar.gz
Move another group member spec from spinachdz-refactor-group-members-tests
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-rw-r--r--features/group/members.feature7
-rw-r--r--spec/features/groups/members/manage_members.rb17
2 files changed, 17 insertions, 7 deletions
diff --git a/features/group/members.feature b/features/group/members.feature
index a7e51339e12..49a44f57cbb 100644
--- a/features/group/members.feature
+++ b/features/group/members.feature
@@ -4,13 +4,6 @@ Feature: Group Members
And "John Doe" is owner of group "Owned"
And "John Doe" is guest of group "Guest"
- Scenario: Guest should not be able to remove other users from group
- Given "Mary Jane" is guest of group "Guest"
- When I visit group "Guest" members page
- Then I should see user "John Doe" in team list
- Then I should see user "Mary Jane" in team list
- Then I should not see the "Remove User From Group" button for "Mary Jane"
-
Scenario: Search member by name
Given "Mary Jane" is guest of group "Guest"
And I visit group "Guest" members page
diff --git a/spec/features/groups/members/manage_members.rb b/spec/features/groups/members/manage_members.rb
index d5925a13401..a9a654b20e2 100644
--- a/spec/features/groups/members/manage_members.rb
+++ b/spec/features/groups/members/manage_members.rb
@@ -77,6 +77,23 @@ feature 'Groups > Members > Manage members', feature: true do
end
end
+ scenario 'guest can not manage other users' do
+ group.add_guest(user1)
+ group.add_developer(user2)
+
+ visit group_group_members_path(group)
+
+ expect(page).not_to have_button 'Add to group'
+
+ page.within(second_row) do
+ # Can not modify user2 role
+ expect(page).not_to have_button 'Developer'
+
+ # Can not remove user2
+ expect(page).not_to have_css('a.btn-remove')
+ end
+ end
+
def first_row
page.all('ul.content-list > li')[0]
end