diff options
| author | Shinya Maeda <gitlab.shinyamaeda@gmail.com> | 2017-03-30 21:03:25 +0900 |
|---|---|---|
| committer | Shinya Maeda <gitlab.shinyamaeda@gmail.com> | 2017-04-06 23:46:58 +0900 |
| commit | d48658e340c6d8d8b5e028afa6d5962ec7616e24 (patch) | |
| tree | a125e9a7f0cea593cde813350929ba30713a28ea | |
| parent | 13bac4c252d2e84484bd0038a6c463e8b0a9cced (diff) | |
| download | gitlab-ce-d48658e340c6d8d8b5e028afa6d5962ec7616e24.tar.gz | |
Use constraint for #validation
| -rw-r--r-- | lib/ci/cron_parser.rb | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/lib/ci/cron_parser.rb b/lib/ci/cron_parser.rb index b0ffb48dabc..be41474198d 100644 --- a/lib/ci/cron_parser.rb +++ b/lib/ci/cron_parser.rb @@ -12,8 +12,10 @@ module Ci end def validation - is_valid_cron = try_parse_cron(@cron, 'Europe/Istanbul').present? - is_valid_cron_time_zone = try_parse_cron('* * * * *', @cron_time_zone).present? + VALID_SYNTAX_TIME_ZONE = 'Europe/Istanbul' + VALID_SYNTAX_CRON = '* * * * *' + is_valid_cron = try_parse_cron(@cron, VALID_SYNTAX_TIME_ZONE).present? + is_valid_cron_time_zone = try_parse_cron(VALID_SYNTAX_CRON, @cron_time_zone).present? return is_valid_cron, is_valid_cron_time_zone end |