diff options
author | Fatih Acet <acetfatih@gmail.com> | 2016-12-16 20:34:41 +0000 |
---|---|---|
committer | Fatih Acet <acetfatih@gmail.com> | 2016-12-16 20:34:41 +0000 |
commit | e7b995e85f5a1be5c52cdb44b8df89da7372e814 (patch) | |
tree | 9266cd2b7e06b6ccdff4e65dde8f268f1e9cf756 | |
parent | fb16b01faab577af781386b9a68336213117b689 (diff) | |
parent | 595da33d738041cf0b2c28a87989aa271f5019cc (diff) | |
download | gitlab-ce-e7b995e85f5a1be5c52cdb44b8df89da7372e814.tar.gz |
Merge branch 'rounded-labels-fixes' into 'master'
Additional rounded label fixes
## What does this MR do?
fixes some UI bugs for the change to rounded labels
## Are there points in the code the reviewer needs to double check?
-
## Why was this MR needed? / Screenshots (if relevant)
before:

after:

these now have full rounded border-radius as well :)

## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
-
See merge request !8136
-rw-r--r-- | app/assets/stylesheets/framework/variables.scss | 2 | ||||
-rw-r--r-- | app/assets/stylesheets/pages/labels.scss | 4 | ||||
-rw-r--r-- | changelogs/unreleased/rounded-labels-fixes.yml | 4 |
3 files changed, 8 insertions, 2 deletions
diff --git a/app/assets/stylesheets/framework/variables.scss b/app/assets/stylesheets/framework/variables.scss index 267fcd77b38..9b4d09c0576 100644 --- a/app/assets/stylesheets/framework/variables.scss +++ b/app/assets/stylesheets/framework/variables.scss @@ -438,7 +438,7 @@ $jq-ui-default-color: #777; $label-gray-bg: #f8fafc; $label-inverse-bg: #333; $label-remove-border: rgba(0, 0, 0, .1); -$label-border-radius: 14px; +$label-border-radius: 100px; /* * Lint diff --git a/app/assets/stylesheets/pages/labels.scss b/app/assets/stylesheets/pages/labels.scss index 25c91203ff4..d129eb12a45 100644 --- a/app/assets/stylesheets/pages/labels.scss +++ b/app/assets/stylesheets/pages/labels.scss @@ -98,7 +98,7 @@ } .label { - padding: 9px; + padding: 8px 9px 9px; font-size: 14px; } } @@ -201,6 +201,8 @@ .label-remove { border-left: 1px solid $label-remove-border; z-index: 3; + border-radius: $label-border-radius; + padding: 6px 10px 6px 9px; } .btn { diff --git a/changelogs/unreleased/rounded-labels-fixes.yml b/changelogs/unreleased/rounded-labels-fixes.yml new file mode 100644 index 00000000000..e0fbc6e3b5a --- /dev/null +++ b/changelogs/unreleased/rounded-labels-fixes.yml @@ -0,0 +1,4 @@ +--- +title: Additional rounded label fixes +merge_request: +author: |