summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFatih Acet <acetfatih@gmail.com>2016-11-02 18:57:28 +0000
committerFatih Acet <acetfatih@gmail.com>2016-11-02 18:57:28 +0000
commitd9cf5c0adc23bc121af27bac4f790fa4a11bae6d (patch)
tree25b75b805481eead1099376e3283a539040b10b7
parent99a12e120953c7b11d35a65e002a7906f30a99cb (diff)
parent1ad62d9684ce5e04d96caf5094610a7fc2436f60 (diff)
downloadgitlab-ce-d9cf5c0adc23bc121af27bac4f790fa4a11bae6d.tar.gz
Merge branch 'eslint-check-file-names' into 'master'
Check that JavaScript file names match convention ## What does this MR do? Introduce a new ESLint rule to check JavaScript file names. ## What are the relevant issue numbers? fixes #23118 See merge request !7238
-rw-r--r--.eslintrc6
-rw-r--r--CHANGELOG.md1
-rw-r--r--package.json1
3 files changed, 8 insertions, 0 deletions
diff --git a/.eslintrc b/.eslintrc
index 16eb18ecba2..b58007d90a9 100644
--- a/.eslintrc
+++ b/.eslintrc
@@ -1,5 +1,11 @@
{
"extends": "airbnb",
+ "plugins": [
+ "filenames"
+ ],
+ "rules": {
+ "filenames/match-regex": [2, "^[a-z_]+$"]
+ },
"globals": {
"$": false,
"_": false,
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 36ec61dd46f..82ede293a72 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -27,6 +27,7 @@ Please view this file on the master branch, on stable branches it's out of date.
- Removed delete branch tooltip !6954
- Stop unauthorized users dragging on milestone page (blackst0ne)
- Restore issue boards welcome message when a project is created !6899
+- Check that JavaScript file names match convention !7238 (winniehell)
- Do not show tooltip for active element !7105 (winniehell)
- Escape ref and path for relative links !6050 (winniehell)
- Fixed link typo on /help/ui to Alerts section. !6915 (Sam Rose)
diff --git a/package.json b/package.json
index d440307bd10..a303c9c1eac 100644
--- a/package.json
+++ b/package.json
@@ -7,6 +7,7 @@
"devDependencies": {
"eslint": "^3.1.1",
"eslint-config-airbnb": "^12.0.0",
+ "eslint-plugin-filenames": "^1.1.0",
"eslint-plugin-import": "^2.0.1",
"eslint-plugin-jsx-a11y": "^2.2.3",
"eslint-plugin-react": "^6.4.1"