diff options
| author | Filipa Lacerda <filipa@gitlab.com> | 2017-08-11 21:43:33 +0100 |
|---|---|---|
| committer | Filipa Lacerda <filipa@gitlab.com> | 2017-08-11 21:43:33 +0100 |
| commit | a3cf3e5074fdad83120d1b2815e422f342c6de42 (patch) | |
| tree | 046f628d4122998224479198b6d62204ee3eeac8 | |
| parent | c7dbba8bf1e87bb69656ce7a99fb10633d6c78da (diff) | |
| download | gitlab-ce-a3cf3e5074fdad83120d1b2815e422f342c6de42.tar.gz | |
Fix broken markdown field test
| -rw-r--r-- | app/assets/javascripts/vue_shared/components/markdown/field.vue | 9 | ||||
| -rw-r--r-- | spec/javascripts/vue_shared/components/markdown/field_spec.js | 3 |
2 files changed, 6 insertions, 6 deletions
diff --git a/app/assets/javascripts/vue_shared/components/markdown/field.vue b/app/assets/javascripts/vue_shared/components/markdown/field.vue index f84652d397c..4e1d623647e 100644 --- a/app/assets/javascripts/vue_shared/components/markdown/field.vue +++ b/app/assets/javascripts/vue_shared/components/markdown/field.vue @@ -64,12 +64,11 @@ .then(resp => resp.json()) .then((data) => { this.markdownPreviewLoading = false; - this.markdownPreview = data.body; - this.referencedCommands = data.references.commands; - this.referencedUsers = data.references.users; + this.markdownPreview = data.body || 'Nothing to preview.'; - if (!this.markdownPreview) { - this.markdownPreview = 'Nothing to preview.'; + if (data.references) { + this.referencedCommands = data.references.commands; + this.referencedUsers = data.references.users; } this.$nextTick(() => { diff --git a/spec/javascripts/vue_shared/components/markdown/field_spec.js b/spec/javascripts/vue_shared/components/markdown/field_spec.js index 291e19c9f3c..84d9a3782a6 100644 --- a/spec/javascripts/vue_shared/components/markdown/field_spec.js +++ b/spec/javascripts/vue_shared/components/markdown/field_spec.js @@ -92,6 +92,7 @@ describe('Markdown field component', () => { it('renders GFM with jQuery', (done) => { spyOn($.fn, 'renderGFM'); + previewLink.click(); setTimeout(() => { @@ -100,7 +101,7 @@ describe('Markdown field component', () => { ).toHaveBeenCalled(); done(); - }); + }, 0); }); }); |
