summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhil Hughes <me@iamphill.com>2017-03-22 12:10:33 +0000
committerPhil Hughes <me@iamphill.com>2017-03-22 12:10:33 +0000
commit8df5b369979ca3c34182f49cc734b01cab861f21 (patch)
treede5cd63af80e760192a8c666e4c6b89c8ce00186
parent78840333d7e1432fc6235b59e90040d0f9e43b41 (diff)
downloadgitlab-ce-8df5b369979ca3c34182f49cc734b01cab861f21.tar.gz
Fixed bug stopping issue boards cards being dragged
This was caused by the window being zoomed & therefore returning a non-rounded number. The number now gets rounded to correctly work in the if statement Closes #29576
-rw-r--r--app/assets/javascripts/boards/components/board_list.js2
-rw-r--r--changelogs/unreleased/issue-boards-cant-drag-fix.yml4
2 files changed, 5 insertions, 1 deletions
diff --git a/app/assets/javascripts/boards/components/board_list.js b/app/assets/javascripts/boards/components/board_list.js
index 9248d036497..86e6c26e570 100644
--- a/app/assets/javascripts/boards/components/board_list.js
+++ b/app/assets/javascripts/boards/components/board_list.js
@@ -48,7 +48,7 @@ import boardCard from './board_card';
this.list.getIssues(false);
}
- if (this.scrollHeight() > this.listHeight()) {
+ if (this.scrollHeight() > Math.ceil(this.listHeight())) {
this.showCount = true;
} else {
this.showCount = false;
diff --git a/changelogs/unreleased/issue-boards-cant-drag-fix.yml b/changelogs/unreleased/issue-boards-cant-drag-fix.yml
new file mode 100644
index 00000000000..ac92573abe8
--- /dev/null
+++ b/changelogs/unreleased/issue-boards-cant-drag-fix.yml
@@ -0,0 +1,4 @@
+---
+title: Fixed bug in issue boards which stopped cards being able to be dragged
+merge_request:
+author: