diff options
author | Phil Hughes <me@iamphill.com> | 2018-11-21 11:49:31 +0000 |
---|---|---|
committer | Phil Hughes <me@iamphill.com> | 2018-11-21 11:49:31 +0000 |
commit | 685e14f8887ef8f26fd15e935d377b2c806b6c38 (patch) | |
tree | faff43575153743bdd42cbc3683384f30c2743fa | |
parent | b8dd1425841521bffbe0f937565b9d60e9182be0 (diff) | |
parent | febc473f541b2c82ec811b1540b2a7ceec8131ca (diff) | |
download | gitlab-ce-685e14f8887ef8f26fd15e935d377b2c806b6c38.tar.gz |
Merge branch '53578-fe-deployment-status' into 'master'
Adds missing status in deployment widget
See merge request gitlab-org/gitlab-ce!23239
4 files changed, 38 insertions, 0 deletions
diff --git a/app/assets/javascripts/vue_merge_request_widget/components/deployment.vue b/app/assets/javascripts/vue_merge_request_widget/components/deployment.vue index 1c5b5d02e20..c0cf1b2f656 100644 --- a/app/assets/javascripts/vue_merge_request_widget/components/deployment.vue +++ b/app/assets/javascripts/vue_merge_request_widget/components/deployment.vue @@ -42,6 +42,8 @@ export default { running: __('Deploying to'), success: __('Deployed to'), failed: __('Failed to deploy to'), + created: __('Will deploy to'), + canceled: __('Failed to deploy to'), }, data() { return { diff --git a/changelogs/unreleased/53578-fe-deployment-status.yml b/changelogs/unreleased/53578-fe-deployment-status.yml new file mode 100644 index 00000000000..b88bd70ee2e --- /dev/null +++ b/changelogs/unreleased/53578-fe-deployment-status.yml @@ -0,0 +1,5 @@ +--- +title: Adds states to the deployment widget +merge_request: +author: +type: added diff --git a/locale/gitlab.pot b/locale/gitlab.pot index b65b0a0a920..15d18e6691f 100644 --- a/locale/gitlab.pot +++ b/locale/gitlab.pot @@ -7245,6 +7245,9 @@ msgstr "" msgid "Wiki|Wiki Pages" msgstr "" +msgid "Will deploy to" +msgstr "" + msgid "Withdraw Access Request" msgstr "" diff --git a/spec/javascripts/vue_mr_widget/components/deployment_spec.js b/spec/javascripts/vue_mr_widget/components/deployment_spec.js index 056b4df8fdc..e355416bd27 100644 --- a/spec/javascripts/vue_mr_widget/components/deployment_spec.js +++ b/spec/javascripts/vue_mr_widget/components/deployment_spec.js @@ -252,5 +252,33 @@ describe('Deployment component', () => { ); }); }); + + describe('created', () => { + beforeEach(() => { + vm = mountComponent(Component, { + deployment: Object.assign({}, deploymentMockData, { status: 'created' }), + showMetrics: true, + }); + }); + + it('renders information about created deployment', () => { + expect(vm.$el.querySelector('.js-deployment-info').textContent).toContain('Will deploy to'); + }); + }); + + describe('canceled', () => { + beforeEach(() => { + vm = mountComponent(Component, { + deployment: Object.assign({}, deploymentMockData, { status: 'canceled' }), + showMetrics: true, + }); + }); + + it('renders information about canceled deployment', () => { + expect(vm.$el.querySelector('.js-deployment-info').textContent).toContain( + 'Failed to deploy to', + ); + }); + }); }); }); |