diff options
| author | Jacopo <beschi.jacopo@gmail.com> | 2017-11-20 08:49:13 +0100 |
|---|---|---|
| committer | Jacopo <beschi.jacopo@gmail.com> | 2017-11-20 09:04:27 +0100 |
| commit | 0b3e3692eb95a68897b4896d168e6763ac0a97b9 (patch) | |
| tree | 5969d5554f843437fee95d7a109fd19877a6ead4 | |
| parent | a248bb769f40937e93e8050f3ababb9066115940 (diff) | |
| download | gitlab-ce-0b3e3692eb95a68897b4896d168e6763ac0a97b9.tar.gz | |
Disables autocomplete in filtered search
Sets `autocomplete=off` to issuable filtered serarch.
| -rw-r--r-- | app/helpers/search_helper.rb | 3 | ||||
| -rw-r--r-- | changelogs/unreleased/38877-disable-autocomplete-in-filtered-search.yml | 5 | ||||
| -rw-r--r-- | spec/helpers/search_helper_spec.rb | 4 |
3 files changed, 11 insertions, 1 deletions
diff --git a/app/helpers/search_helper.rb b/app/helpers/search_helper.rb index cf28a917fd1..2f57660516d 100644 --- a/app/helpers/search_helper.rb +++ b/app/helpers/search_helper.rb @@ -140,7 +140,8 @@ module SearchHelper placeholder: 'Search or filter results...', data: { 'username-params' => @users.to_json(only: [:id, :username]) - } + }, + autocomplete: 'off' } if @project.present? diff --git a/changelogs/unreleased/38877-disable-autocomplete-in-filtered-search.yml b/changelogs/unreleased/38877-disable-autocomplete-in-filtered-search.yml new file mode 100644 index 00000000000..07439a860ec --- /dev/null +++ b/changelogs/unreleased/38877-disable-autocomplete-in-filtered-search.yml @@ -0,0 +1,5 @@ +--- +title: Disables autocomplete in filtered searc +merge_request: 15477 +author: Jacopo Beschi @jacopo-beschi +type: added diff --git a/spec/helpers/search_helper_spec.rb b/spec/helpers/search_helper_spec.rb index ab647401e14..6c9a7febf14 100644 --- a/spec/helpers/search_helper_spec.rb +++ b/spec/helpers/search_helper_spec.rb @@ -102,6 +102,10 @@ describe SearchHelper do it 'includes project base-endpoint' do expect(search_filter_input_options('')[:data]['base-endpoint']).to eq(project_path(@project)) end + + it 'includes autocomplete=off flag' do + expect(search_filter_input_options('')[:autocomplete]).to eq('off') + end end context 'group' do |