diff options
| author | Amy Phillips <aphillips@gitlab.com> | 2020-11-29 11:25:40 +0000 |
|---|---|---|
| committer | Amy Phillips <aphillips@gitlab.com> | 2020-11-29 11:25:40 +0000 |
| commit | 0f551269bb3672146dd80f5345dbd88cf367ccf4 (patch) | |
| tree | 9e735546a16ea1c483ad8dc52d1e429aac771491 | |
| parent | 518aebfe14a72ba08b5b0a528654805bb2d66cd3 (diff) | |
| download | gitlab-ce-ap/include-sentry-in-definition-of-done.tar.gz | |
Include Sentry checks to definition of doneap/include-sentry-in-definition-of-done
| -rw-r--r-- | doc/development/contributing/merge_request_workflow.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/doc/development/contributing/merge_request_workflow.md b/doc/development/contributing/merge_request_workflow.md index 219c81fa0ff..c523cae673a 100644 --- a/doc/development/contributing/merge_request_workflow.md +++ b/doc/development/contributing/merge_request_workflow.md @@ -241,7 +241,7 @@ requirements. 1. Reviewed by relevant reviewers and all concerns are addressed for Availability, Regressions, Security. Documentation reviews should take place as soon as possible, but they should not block a merge request. 1. Merged by a project maintainer. 1. Create an issue in the [infrastructure issue tracker](https://gitlab.com/gitlab-com/gl-infra/infrastructure/-/issues) to inform the Infrastructure department when your contribution is changing default settings or introduces a new setting, if relevant. -1. Confirmed to be working in the [Canary stage](https://about.gitlab.com/handbook/engineering/#canary-testing) or on GitLab.com once the contribution is deployed. +1. Confirmed to be working in the [Canary stage](https://about.gitlab.com/handbook/engineering/#canary-testing) with no new [Sentry](https://about.gitlab.com/handbook/engineering/#sentry) errors or on GitLab.com once the contribution is deployed. 1. Added to the [release post](https://about.gitlab.com/handbook/marketing/blog/release-posts/), if relevant. 1. Added to [the website](https://gitlab.com/gitlab-com/www-gitlab-com/blob/master/data/features.yml), if relevant. |