Merge branch 'remove-unnecessary-freeze-in-lib-gitlab' into 'master'

Avoid calling freeze on already frozen strings in lib/gitlab

See merge request gitlab-org/gitlab-ce!32637

61 files changed, 119 insertions, 117 deletions

diff --git a/lib/gitlab/auth/unique_ips_limiter.rb b/lib/gitlab/auth/unique_ips_limiter.rb
index 31dd61ae6cf..97e78ecf094 100644
--- a/lib/gitlab/auth/unique_ips_limiter.rb
+++ b/lib/gitlab/auth/unique_ips_limiter.rb
@@ -3,7 +3,7 @@
 module Gitlab
   module Auth
     class UniqueIpsLimiter
-      USER_UNIQUE_IPS_PREFIX = 'user_unique_ips'.freeze
+      USER_UNIQUE_IPS_PREFIX = 'user_unique_ips'
 
       class << self
         def limit_user_id!(user_id)
diff --git a/lib/gitlab/auth/user_auth_finders.rb b/lib/gitlab/auth/user_auth_finders.rb
index bba7e2cbb3c..97755117edc 100644
--- a/lib/gitlab/auth/user_auth_finders.rb
+++ b/lib/gitlab/auth/user_auth_finders.rb
@@ -20,7 +20,7 @@ module Gitlab
     module UserAuthFinders
       include Gitlab::Utils::StrongMemoize
 
-      PRIVATE_TOKEN_HEADER = 'HTTP_PRIVATE_TOKEN'.freeze
+      PRIVATE_TOKEN_HEADER = 'HTTP_PRIVATE_TOKEN'
       PRIVATE_TOKEN_PARAM = :private_token
 
       # Check the Rails session for valid authentication details
diff --git a/lib/gitlab/background_migration/merge_request_assignees_migration_progress_check.rb b/lib/gitlab/background_migration/merge_request_assignees_migration_progress_check.rb
index e948cedaad5..de0c357ab1c 100644
--- a/lib/gitlab/background_migration/merge_request_assignees_migration_progress_check.rb
+++ b/lib/gitlab/background_migration/merge_request_assignees_migration_progress_check.rb
@@ -7,7 +7,7 @@ module Gitlab
       include Gitlab::Utils::StrongMemoize
 
       RESCHEDULE_DELAY = 3.hours
-      WORKER = 'PopulateMergeRequestAssigneesTable'.freeze
+      WORKER = 'PopulateMergeRequestAssigneesTable'
       DeadJobsError = Class.new(StandardError)
 
       def perform
diff --git a/lib/gitlab/background_migration/prepare_untracked_uploads.rb b/lib/gitlab/background_migration/prepare_untracked_uploads.rb
index 2ac51dd7b55..3d943205783 100644
--- a/lib/gitlab/background_migration/prepare_untracked_uploads.rb
+++ b/lib/gitlab/background_migration/prepare_untracked_uploads.rb
@@ -10,15 +10,15 @@ module Gitlab
       include ::Gitlab::Utils::StrongMemoize
 
       FIND_BATCH_SIZE = 500
-      RELATIVE_UPLOAD_DIR = "uploads".freeze
+      RELATIVE_UPLOAD_DIR = "uploads"
       ABSOLUTE_UPLOAD_DIR = File.join(
         Gitlab.config.uploads.storage_path,
         RELATIVE_UPLOAD_DIR
       )
-      FOLLOW_UP_MIGRATION = 'PopulateUntrackedUploads'.freeze
+      FOLLOW_UP_MIGRATION = 'PopulateUntrackedUploads'
       START_WITH_ROOT_REGEX = %r{\A#{Gitlab.config.uploads.storage_path}/}.freeze
-      EXCLUDED_HASHED_UPLOADS_PATH = "#{ABSOLUTE_UPLOAD_DIR}/@hashed/*".freeze
-      EXCLUDED_TMP_UPLOADS_PATH = "#{ABSOLUTE_UPLOAD_DIR}/tmp/*".freeze
+      EXCLUDED_HASHED_UPLOADS_PATH = "#{ABSOLUTE_UPLOAD_DIR}/@hashed/*"
+      EXCLUDED_TMP_UPLOADS_PATH = "#{ABSOLUTE_UPLOAD_DIR}/tmp/*"
 
       # This class is used to iterate over batches of
       # `untracked_files_for_uploads` rows.
diff --git a/lib/gitlab/bitbucket_server_import/importer.rb b/lib/gitlab/bitbucket_server_import/importer.rb
index ff2694abd5e..93c6fdcf69c 100644
--- a/lib/gitlab/bitbucket_server_import/importer.rb
+++ b/lib/gitlab/bitbucket_server_import/importer.rb
@@ -7,7 +7,7 @@ module Gitlab
       attr_reader :project, :project_key, :repository_slug, :client, :errors, :users
       attr_accessor :logger
 
-      REMOTE_NAME = 'bitbucket_server'.freeze
+      REMOTE_NAME = 'bitbucket_server'
       BATCH_SIZE = 100
 
       TempBranch = Struct.new(:name, :sha)
diff --git a/lib/gitlab/checks/lfs_check.rb b/lib/gitlab/checks/lfs_check.rb
index 67a65d61441..7b013567a03 100644
--- a/lib/gitlab/checks/lfs_check.rb
+++ b/lib/gitlab/checks/lfs_check.rb
@@ -3,8 +3,8 @@
 module Gitlab
   module Checks
     class LfsCheck < BaseChecker
-      LOG_MESSAGE = "Scanning repository for blobs stored in LFS and verifying their files have been uploaded to GitLab...".freeze
-      ERROR_MESSAGE = 'LFS objects are missing. Ensure LFS is properly set up or try a manual "git lfs push --all".'.freeze
+      LOG_MESSAGE = 'Scanning repository for blobs stored in LFS and verifying their files have been uploaded to GitLab...'
+      ERROR_MESSAGE = 'LFS objects are missing. Ensure LFS is properly set up or try a manual "git lfs push --all".'
 
       def validate!
         return unless Feature.enabled?(:lfs_check, default_enabled: true)
diff --git a/lib/gitlab/checks/project_created.rb b/lib/gitlab/checks/project_created.rb
index 0058a402a62..362562068e9 100644
--- a/lib/gitlab/checks/project_created.rb
+++ b/lib/gitlab/checks/project_created.rb
@@ -3,7 +3,7 @@
 module Gitlab
   module Checks
     class ProjectCreated < PostPushMessage
-      PROJECT_CREATED = "project_created".freeze
+      PROJECT_CREATED = "project_created"
 
       def message
         <<~MESSAGE
diff --git a/lib/gitlab/checks/project_moved.rb b/lib/gitlab/checks/project_moved.rb
index cb3b7acaaad..6f04fddc6c4 100644
--- a/lib/gitlab/checks/project_moved.rb
+++ b/lib/gitlab/checks/project_moved.rb
@@ -3,7 +3,7 @@
 module Gitlab
   module Checks
     class ProjectMoved < PostPushMessage
-      REDIRECT_NAMESPACE = "redirect_namespace".freeze
+      REDIRECT_NAMESPACE = "redirect_namespace"
 
       def initialize(project, user, protocol, redirected_path)
         @redirected_path = redirected_path
diff --git a/lib/gitlab/ci/build/port.rb b/lib/gitlab/ci/build/port.rb
index 6c4656ffea2..017b31b4f77 100644
--- a/lib/gitlab/ci/build/port.rb
+++ b/lib/gitlab/ci/build/port.rb
@@ -4,8 +4,8 @@ module Gitlab
   module Ci
     module Build
       class Port
-        DEFAULT_PORT_NAME = 'default_port'.freeze
-        DEFAULT_PORT_PROTOCOL = 'http'.freeze
+        DEFAULT_PORT_NAME = 'default_port'
+        DEFAULT_PORT_PROTOCOL = 'http'
 
         attr_reader :number, :protocol, :name
 
diff --git a/lib/gitlab/ci/build/step.rb b/lib/gitlab/ci/build/step.rb
index 7fcabc035ac..48111ae5717 100644
--- a/lib/gitlab/ci/build/step.rb
+++ b/lib/gitlab/ci/build/step.rb
@@ -4,9 +4,9 @@ module Gitlab
   module Ci
     module Build
       class Step
-        WHEN_ON_FAILURE = 'on_failure'.freeze
-        WHEN_ON_SUCCESS = 'on_success'.freeze
-        WHEN_ALWAYS = 'always'.freeze
+        WHEN_ON_FAILURE = 'on_failure'
+        WHEN_ON_SUCCESS = 'on_success'
+        WHEN_ALWAYS = 'always'
 
         attr_reader :name
         attr_accessor :script, :timeout, :when, :allow_failure
diff --git a/lib/gitlab/ci/config/entry/cache.rb b/lib/gitlab/ci/config/entry/cache.rb
index 7b94af24c09..ef07c319ce4 100644
--- a/lib/gitlab/ci/config/entry/cache.rb
+++ b/lib/gitlab/ci/config/entry/cache.rb
@@ -12,7 +12,7 @@ module Gitlab
           include ::Gitlab::Config::Entry::Attributable
 
           ALLOWED_KEYS = %i[key untracked paths policy].freeze
-          DEFAULT_POLICY = 'pull-push'.freeze
+          DEFAULT_POLICY = 'pull-push'
 
           validations do
             validates :config, allowed_keys: ALLOWED_KEYS
diff --git a/lib/gitlab/ci/config/external/file/template.rb b/lib/gitlab/ci/config/external/file/template.rb
index 54f4cf74c4d..db56f6a9b00 100644
--- a/lib/gitlab/ci/config/external/file/template.rb
+++ b/lib/gitlab/ci/config/external/file/template.rb
@@ -8,7 +8,7 @@ module Gitlab
           class Template < Base
             attr_reader :location, :project
 
-            SUFFIX = '.gitlab-ci.yml'.freeze
+            SUFFIX = '.gitlab-ci.yml'
 
             def initialize(params, context)
               @location = params[:template]
diff --git a/lib/gitlab/ci/cron_parser.rb b/lib/gitlab/ci/cron_parser.rb
index 94f4a4e36c9..1d7e7ea0f9a 100644
--- a/lib/gitlab/ci/cron_parser.rb
+++ b/lib/gitlab/ci/cron_parser.rb
@@ -3,8 +3,8 @@
 module Gitlab
   module Ci
     class CronParser
-      VALID_SYNTAX_SAMPLE_TIME_ZONE = 'UTC'.freeze
-      VALID_SYNTAX_SAMPLE_CRON = '* * * * *'.freeze
+      VALID_SYNTAX_SAMPLE_TIME_ZONE = 'UTC'
+      VALID_SYNTAX_SAMPLE_CRON = '* * * * *'
 
       def initialize(cron, cron_timezone = 'UTC')
         @cron = cron
diff --git a/lib/gitlab/ci/reports/test_case.rb b/lib/gitlab/ci/reports/test_case.rb
index 292e273a03a..fdeaad698b9 100644
--- a/lib/gitlab/ci/reports/test_case.rb
+++ b/lib/gitlab/ci/reports/test_case.rb
@@ -4,10 +4,10 @@ module Gitlab
   module Ci
     module Reports
       class TestCase
-        STATUS_SUCCESS = 'success'.freeze
-        STATUS_FAILED = 'failed'.freeze
-        STATUS_SKIPPED = 'skipped'.freeze
-        STATUS_ERROR = 'error'.freeze
+        STATUS_SUCCESS = 'success'
+        STATUS_FAILED = 'failed'
+        STATUS_SKIPPED = 'skipped'
+        STATUS_ERROR = 'error'
         STATUS_TYPES = [STATUS_SUCCESS, STATUS_FAILED, STATUS_SKIPPED, STATUS_ERROR].freeze
 
         attr_reader :name, :classname, :execution_time, :status, :file, :system_output, :stack_trace, :key
diff --git a/lib/gitlab/cleanup/project_upload_file_finder.rb b/lib/gitlab/cleanup/project_upload_file_finder.rb
index 5aace564c2d..3d35d474f5d 100644
--- a/lib/gitlab/cleanup/project_upload_file_finder.rb
+++ b/lib/gitlab/cleanup/project_upload_file_finder.rb
@@ -5,9 +5,9 @@ module Gitlab
     class ProjectUploadFileFinder
       FIND_BATCH_SIZE = 500
       ABSOLUTE_UPLOAD_DIR = FileUploader.root.freeze
-      EXCLUDED_SYSTEM_UPLOADS_PATH = "#{ABSOLUTE_UPLOAD_DIR}/-/*".freeze
-      EXCLUDED_HASHED_UPLOADS_PATH = "#{ABSOLUTE_UPLOAD_DIR}/@hashed/*".freeze
-      EXCLUDED_TMP_UPLOADS_PATH = "#{ABSOLUTE_UPLOAD_DIR}/tmp/*".freeze
+      EXCLUDED_SYSTEM_UPLOADS_PATH = "#{ABSOLUTE_UPLOAD_DIR}/-/*"
+      EXCLUDED_HASHED_UPLOADS_PATH = "#{ABSOLUTE_UPLOAD_DIR}/@hashed/*"
+      EXCLUDED_TMP_UPLOADS_PATH = "#{ABSOLUTE_UPLOAD_DIR}/tmp/*"
 
       # Paths are relative to the upload directory
       def each_file_batch(batch_size: FIND_BATCH_SIZE, &block)
diff --git a/lib/gitlab/database/sha_attribute.rb b/lib/gitlab/database/sha_attribute.rb
index ddbabc9098e..776e80701f1 100644
--- a/lib/gitlab/database/sha_attribute.rb
+++ b/lib/gitlab/database/sha_attribute.rb
@@ -12,7 +12,7 @@ module Gitlab
     # using them as if they were stored as string values. This gives you the
     # ease of use of string values, but without the storage overhead.
     class ShaAttribute < BINARY_TYPE
-      PACK_FORMAT = 'H*'.freeze
+      PACK_FORMAT = 'H*'
 
       # Casts binary data to a SHA1 in hexadecimal.
       def deserialize(value)
diff --git a/lib/gitlab/downtime_check/message.rb b/lib/gitlab/downtime_check/message.rb
index ec38bd769a3..5debb754943 100644
--- a/lib/gitlab/downtime_check/message.rb
+++ b/lib/gitlab/downtime_check/message.rb
@@ -5,8 +5,8 @@ module Gitlab
     class Message
       attr_reader :path, :offline
 
-      OFFLINE = "\e[31moffline\e[0m".freeze
-      ONLINE = "\e[32monline\e[0m".freeze
+      OFFLINE = "\e[31moffline\e[0m"
+      ONLINE = "\e[32monline\e[0m"
 
       # path - The file path of the migration.
       # offline - When set to `true` the migration will require downtime.
diff --git a/lib/gitlab/ee_compat_check.rb b/lib/gitlab/ee_compat_check.rb
index 86e532766b1..20c31e06905 100644
--- a/lib/gitlab/ee_compat_check.rb
+++ b/lib/gitlab/ee_compat_check.rb
@@ -1,11 +1,12 @@
+# coding: utf-8
 # frozen_string_literal: true
 
 # rubocop: disable Rails/Output
 module Gitlab
   # Checks if a set of migrations requires downtime or not.
   class EeCompatCheck
-    CANONICAL_CE_PROJECT_URL = 'https://gitlab.com/gitlab-org/gitlab-ce'.freeze
-    CANONICAL_EE_REPO_URL = 'https://gitlab.com/gitlab-org/gitlab-ee.git'.freeze
+    CANONICAL_CE_PROJECT_URL = 'https://gitlab.com/gitlab-org/gitlab-ce'
+    CANONICAL_EE_REPO_URL = 'https://gitlab.com/gitlab-org/gitlab-ee.git'
     CHECK_DIR = Rails.root.join('ee_compat_check')
     IGNORED_FILES_REGEX = /VERSION|CHANGELOG\.md|doc\/.+/i.freeze
     PLEASE_READ_THIS_BANNER = %Q{
diff --git a/lib/gitlab/etag_caching/store.rb b/lib/gitlab/etag_caching/store.rb
index 2395e7be026..1d2f0d7bbf4 100644
--- a/lib/gitlab/etag_caching/store.rb
+++ b/lib/gitlab/etag_caching/store.rb
@@ -4,7 +4,7 @@ module Gitlab
   module EtagCaching
     class Store
       EXPIRY_TIME = 20.minutes
-      SHARED_STATE_NAMESPACE = 'etag:'.freeze
+      SHARED_STATE_NAMESPACE = 'etag:'
 
       def get(key)
         Gitlab::Redis::SharedState.with { |redis| redis.get(redis_shared_state_key(key)) }
diff --git a/lib/gitlab/git.rb b/lib/gitlab/git.rb
index df9f33baec2..8d13c74dca2 100644
--- a/lib/gitlab/git.rb
+++ b/lib/gitlab/git.rb
@@ -7,11 +7,11 @@ module Gitlab
     # The ID of empty tree.
     # See http://stackoverflow.com/a/40884093/1856239 and
     # https://github.com/git/git/blob/3ad8b5bf26362ac67c9020bf8c30eee54a84f56d/cache.h#L1011-L1012
-    EMPTY_TREE_ID = '4b825dc642cb6eb9a060e54bf8d69288fbee4904'.freeze
+    EMPTY_TREE_ID = '4b825dc642cb6eb9a060e54bf8d69288fbee4904'
     BLANK_SHA = ('0' * 40).freeze
     COMMIT_ID = /\A[0-9a-f]{40}\z/.freeze
-    TAG_REF_PREFIX = "refs/tags/".freeze
-    BRANCH_REF_PREFIX = "refs/heads/".freeze
+    TAG_REF_PREFIX = "refs/tags/"
+    BRANCH_REF_PREFIX = "refs/heads/"
 
     BaseError = Class.new(StandardError)
     CommandError = Class.new(BaseError)
diff --git a/lib/gitlab/git/lfs_pointer_file.rb b/lib/gitlab/git/lfs_pointer_file.rb
index b7019a221ac..efd84e30ad9 100644
--- a/lib/gitlab/git/lfs_pointer_file.rb
+++ b/lib/gitlab/git/lfs_pointer_file.rb
@@ -3,8 +3,8 @@
 module Gitlab
   module Git
     class LfsPointerFile
-      VERSION = "https://git-lfs.github.com/spec/v1".freeze
-      VERSION_LINE = "version #{VERSION}".freeze
+      VERSION = "https://git-lfs.github.com/spec/v1"
+      VERSION_LINE = "version #{VERSION}"
 
       def initialize(data)
         @data = data
diff --git a/lib/gitlab/git/repository.rb b/lib/gitlab/git/repository.rb
index 27032602828..4ea618f063b 100644
--- a/lib/gitlab/git/repository.rb
+++ b/lib/gitlab/git/repository.rb
@@ -15,9 +15,9 @@ module Gitlab
 
       SEARCH_CONTEXT_LINES = 3
       REV_LIST_COMMIT_LIMIT = 2_000
-      GITALY_INTERNAL_URL = 'ssh://gitaly/internal.git'.freeze
+      GITALY_INTERNAL_URL = 'ssh://gitaly/internal.git'
       GITLAB_PROJECTS_TIMEOUT = Gitlab.config.gitlab_shell.git_timeout
-      EMPTY_REPOSITORY_CHECKSUM = '0000000000000000000000000000000000000000'.freeze
+      EMPTY_REPOSITORY_CHECKSUM = '0000000000000000000000000000000000000000'
 
       NoRepository = Class.new(StandardError)
       InvalidRepository = Class.new(StandardError)
diff --git a/lib/gitlab/git/util.rb b/lib/gitlab/git/util.rb
index 03c2c1367b0..cf8571bf917 100644
--- a/lib/gitlab/git/util.rb
+++ b/lib/gitlab/git/util.rb
@@ -5,7 +5,7 @@
 module Gitlab
   module Git
     module Util
-      LINE_SEP = "\n".freeze
+      LINE_SEP = "\n"
 
       def self.count_lines(string)
         case string[-1]
diff --git a/lib/gitlab/github_import/issuable_finder.rb b/lib/gitlab/github_import/issuable_finder.rb
index 211915f1d87..c81603a1aa9 100644
--- a/lib/gitlab/github_import/issuable_finder.rb
+++ b/lib/gitlab/github_import/issuable_finder.rb
@@ -10,7 +10,7 @@ module Gitlab
       attr_reader :project, :object
 
       # The base cache key to use for storing/retrieving issuable IDs.
-      CACHE_KEY = 'github-import/issuable-finder/%{project}/%{type}/%{iid}'.freeze
+      CACHE_KEY = 'github-import/issuable-finder/%{project}/%{type}/%{iid}'
 
       # project - An instance of `Project`.
       # object - The object to look up or set a database ID for.
diff --git a/lib/gitlab/github_import/label_finder.rb b/lib/gitlab/github_import/label_finder.rb
index d2479a8f565..cad39e48e43 100644
--- a/lib/gitlab/github_import/label_finder.rb
+++ b/lib/gitlab/github_import/label_finder.rb
@@ -6,7 +6,7 @@ module Gitlab
       attr_reader :project
 
       # The base cache key to use for storing/retrieving label IDs.
-      CACHE_KEY = 'github-import/label-finder/%{project}/%{name}'.freeze
+      CACHE_KEY = 'github-import/label-finder/%{project}/%{name}'
 
       # project - An instance of `Project`.
       def initialize(project)
diff --git a/lib/gitlab/github_import/milestone_finder.rb b/lib/gitlab/github_import/milestone_finder.rb
index 5625730e796..a157a1e1ff5 100644
--- a/lib/gitlab/github_import/milestone_finder.rb
+++ b/lib/gitlab/github_import/milestone_finder.rb
@@ -6,7 +6,7 @@ module Gitlab
       attr_reader :project
 
       # The base cache key to use for storing/retrieving milestone IDs.
-      CACHE_KEY = 'github-import/milestone-finder/%{project}/%{iid}'.freeze
+      CACHE_KEY = 'github-import/milestone-finder/%{project}/%{iid}'
 
       # project - An instance of `Project`
       def initialize(project)
diff --git a/lib/gitlab/github_import/page_counter.rb b/lib/gitlab/github_import/page_counter.rb
index c3db2d0b469..a3e7b3c1afc 100644
--- a/lib/gitlab/github_import/page_counter.rb
+++ b/lib/gitlab/github_import/page_counter.rb
@@ -9,7 +9,7 @@ module Gitlab
       attr_reader :cache_key
 
       # The base cache key to use for storing the last page number.
-      CACHE_KEY = 'github-importer/page-counter/%{project}/%{collection}'.freeze
+      CACHE_KEY = 'github-importer/page-counter/%{project}/%{collection}'
 
       def initialize(project, collection)
         @cache_key = CACHE_KEY % { project: project.id, collection: collection }
diff --git a/lib/gitlab/github_import/parallel_scheduling.rb b/lib/gitlab/github_import/parallel_scheduling.rb
index d4d1357f5a3..849a66d47ed 100644
--- a/lib/gitlab/github_import/parallel_scheduling.rb
+++ b/lib/gitlab/github_import/parallel_scheduling.rb
@@ -7,7 +7,7 @@ module Gitlab
 
       # The base cache key to use for tracking already imported objects.
       ALREADY_IMPORTED_CACHE_KEY =
-        'github-importer/already-imported/%{project}/%{collection}'.freeze
+        'github-importer/already-imported/%{project}/%{collection}'
 
       # project - An instance of `Project`.
       # client - An instance of `Gitlab::GithubImport::Client`.
diff --git a/lib/gitlab/github_import/user_finder.rb b/lib/gitlab/github_import/user_finder.rb
index 30283f147ef..51a532437bd 100644
--- a/lib/gitlab/github_import/user_finder.rb
+++ b/lib/gitlab/github_import/user_finder.rb
@@ -16,17 +16,17 @@ module Gitlab
 
       # The base cache key to use for caching user IDs for a given GitHub user
       # ID.
-      ID_CACHE_KEY = 'github-import/user-finder/user-id/%s'.freeze
+      ID_CACHE_KEY = 'github-import/user-finder/user-id/%s'
 
       # The base cache key to use for caching user IDs for a given GitHub email
       # address.
       ID_FOR_EMAIL_CACHE_KEY =
-        'github-import/user-finder/id-for-email/%s'.freeze
+        'github-import/user-finder/id-for-email/%s'
 
       # The base cache key to use for caching the Email addresses of GitHub
       # usernames.
       EMAIL_FOR_USERNAME_CACHE_KEY =
-        'github-import/user-finder/email-for-username/%s'.freeze
+        'github-import/user-finder/email-for-username/%s'
 
       # project - An instance of `Project`
       # client - An instance of `Gitlab::GithubImport::Client`
diff --git a/lib/gitlab/health_checks/gitaly_check.rb b/lib/gitlab/health_checks/gitaly_check.rb
index 898733fea5d..e560f87bf98 100644
--- a/lib/gitlab/health_checks/gitaly_check.rb
+++ b/lib/gitlab/health_checks/gitaly_check.rb
@@ -5,7 +5,7 @@ module Gitlab
     class GitalyCheck
       extend BaseAbstractCheck
 
-      METRIC_PREFIX = 'gitaly_health_check'.freeze
+      METRIC_PREFIX = 'gitaly_health_check'
 
       class << self
         def readiness
diff --git a/lib/gitlab/import_export.rb b/lib/gitlab/import_export.rb
index bb46bd657e8..d08848a65a8 100644
--- a/lib/gitlab/import_export.rb
+++ b/lib/gitlab/import_export.rb
@@ -7,7 +7,7 @@ module Gitlab
     # For every version update the version history in these docs must be kept up to date:
     # - development/import_export.md
     # - user/project/settings/import_export.md
-    VERSION = '0.2.4'.freeze
+    VERSION = '0.2.4'
     FILENAME_LIMIT = 50
 
     def export_path(relative_path:)
diff --git a/lib/gitlab/import_export/after_export_strategies/base_after_export_strategy.rb b/lib/gitlab/import_export/after_export_strategies/base_after_export_strategy.rb
index d39b6fe5955..c5fb39b7b52 100644
--- a/lib/gitlab/import_export/after_export_strategies/base_after_export_strategy.rb
+++ b/lib/gitlab/import_export/after_export_strategies/base_after_export_strategy.rb
@@ -10,7 +10,7 @@ module Gitlab
 
         StrategyError = Class.new(StandardError)
 
-        AFTER_EXPORT_LOCK_FILE_NAME = '.after_export_action'.freeze
+        AFTER_EXPORT_LOCK_FILE_NAME = '.after_export_action'
 
         private
 
diff --git a/lib/gitlab/import_export/after_export_strategies/web_upload_strategy.rb b/lib/gitlab/import_export/after_export_strategies/web_upload_strategy.rb
index acb7f225b17..aaa70f0b36d 100644
--- a/lib/gitlab/import_export/after_export_strategies/web_upload_strategy.rb
+++ b/lib/gitlab/import_export/after_export_strategies/web_upload_strategy.rb
@@ -4,9 +4,9 @@ module Gitlab
   module ImportExport
     module AfterExportStrategies
       class WebUploadStrategy < BaseAfterExportStrategy
-        PUT_METHOD = 'PUT'.freeze
-        POST_METHOD = 'POST'.freeze
-        INVALID_HTTP_METHOD = 'invalid. Only PUT and POST methods allowed.'.freeze
+        PUT_METHOD = 'PUT'
+        POST_METHOD = 'POST'
+        INVALID_HTTP_METHOD = 'invalid. Only PUT and POST methods allowed.'
 
         validates :url, addressable_url: true
 
diff --git a/lib/gitlab/incoming_email.rb b/lib/gitlab/incoming_email.rb
index 8b346f6d7d2..eece4edf895 100644
--- a/lib/gitlab/incoming_email.rb
+++ b/lib/gitlab/incoming_email.rb
@@ -2,9 +2,9 @@
 
 module Gitlab
   module IncomingEmail
-    UNSUBSCRIBE_SUFFIX        = '-unsubscribe'.freeze
-    UNSUBSCRIBE_SUFFIX_LEGACY = '+unsubscribe'.freeze
-    WILDCARD_PLACEHOLDER      = '%{key}'.freeze
+    UNSUBSCRIBE_SUFFIX        = '-unsubscribe'
+    UNSUBSCRIBE_SUFFIX_LEGACY = '+unsubscribe'
+    WILDCARD_PLACEHOLDER      = '%{key}'
 
     class << self
       def enabled?
diff --git a/lib/gitlab/job_waiter.rb b/lib/gitlab/job_waiter.rb
index e97e961771c..90dbe4d005d 100644
--- a/lib/gitlab/job_waiter.rb
+++ b/lib/gitlab/job_waiter.rb
@@ -17,7 +17,7 @@ module Gitlab
   # push to that array when done. Once the waiter has popped `count` items, it
   # knows all the jobs are done.
   class JobWaiter
-    KEY_PREFIX = "gitlab:job_waiter".freeze
+    KEY_PREFIX = "gitlab:job_waiter"
 
     def self.notify(key, jid)
       Gitlab::Redis::SharedState.with { |redis| redis.lpush(key, jid) }
diff --git a/lib/gitlab/kubernetes/helm.rb b/lib/gitlab/kubernetes/helm.rb
index 6e4286589c1..16ed0cb0f8e 100644
--- a/lib/gitlab/kubernetes/helm.rb
+++ b/lib/gitlab/kubernetes/helm.rb
@@ -3,12 +3,12 @@
 module Gitlab
   module Kubernetes
     module Helm
-      HELM_VERSION = '2.14.3'.freeze
-      KUBECTL_VERSION = '1.11.10'.freeze
-      NAMESPACE = 'gitlab-managed-apps'.freeze
-      SERVICE_ACCOUNT = 'tiller'.freeze
-      CLUSTER_ROLE_BINDING = 'tiller-admin'.freeze
-      CLUSTER_ROLE = 'cluster-admin'.freeze
+      HELM_VERSION = '2.14.3'
+      KUBECTL_VERSION = '1.11.10'
+      NAMESPACE = 'gitlab-managed-apps'
+      SERVICE_ACCOUNT = 'tiller'
+      CLUSTER_ROLE_BINDING = 'tiller-admin'
+      CLUSTER_ROLE = 'cluster-admin'
     end
   end
 end
diff --git a/lib/gitlab/kubernetes/pod.rb b/lib/gitlab/kubernetes/pod.rb
index 81317e532b2..d247662dc3b 100644
--- a/lib/gitlab/kubernetes/pod.rb
+++ b/lib/gitlab/kubernetes/pod.rb
@@ -3,11 +3,11 @@
 module Gitlab
   module Kubernetes
     module Pod
-      PENDING   = 'Pending'.freeze
-      RUNNING   = 'Running'.freeze
-      SUCCEEDED = 'Succeeded'.freeze
-      FAILED    = 'Failed'.freeze
-      UNKNOWN   = 'Unknown'.freeze
+      PENDING   = 'Pending'
+      RUNNING   = 'Running'
+      SUCCEEDED = 'Succeeded'
+      FAILED    = 'Failed'
+      UNKNOWN   = 'Unknown'
       PHASES    = [PENDING, RUNNING, SUCCEEDED, FAILED, UNKNOWN].freeze
     end
   end
diff --git a/lib/gitlab/logger.rb b/lib/gitlab/logger.rb
index 128a5dd8936..2ec8c268d09 100644
--- a/lib/gitlab/logger.rb
+++ b/lib/gitlab/logger.rb
@@ -40,7 +40,7 @@ module Gitlab
     end
 
     def self.cache_key
-      'logger:'.freeze + self.full_log_path.to_s
+      'logger:' + self.full_log_path.to_s
     end
   end
 end
diff --git a/lib/gitlab/metrics/subscribers/action_view.rb b/lib/gitlab/metrics/subscribers/action_view.rb
index c068f8017fd..2ed5878286a 100644
--- a/lib/gitlab/metrics/subscribers/action_view.rb
+++ b/lib/gitlab/metrics/subscribers/action_view.rb
@@ -15,7 +15,7 @@ module Gitlab
 
         attach_to :action_view
 
-        SERIES = 'views'.freeze
+        SERIES = 'views'
 
         def render_template(event)
           track(event) if current_transaction
diff --git a/lib/gitlab/metrics/transaction.rb b/lib/gitlab/metrics/transaction.rb
index d7986685c65..9584285be7e 100644
--- a/lib/gitlab/metrics/transaction.rb
+++ b/lib/gitlab/metrics/transaction.rb
@@ -14,7 +14,7 @@ module Gitlab
       THREAD_KEY = :_gitlab_metrics_transaction
 
       # The series to store events (e.g. Git pushes) in.
-      EVENT_SERIES = 'events'.freeze
+      EVENT_SERIES = 'events'
 
       attr_reader :tags, :values, :method, :metrics
 
diff --git a/lib/gitlab/metrics/web_transaction.rb b/lib/gitlab/metrics/web_transaction.rb
index b2a43d46fb2..fa17548723e 100644
--- a/lib/gitlab/metrics/web_transaction.rb
+++ b/lib/gitlab/metrics/web_transaction.rb
@@ -3,8 +3,8 @@
 module Gitlab
   module Metrics
     class WebTransaction < Transaction
-      CONTROLLER_KEY = 'action_controller.instance'.freeze
-      ENDPOINT_KEY = 'api.endpoint'.freeze
+      CONTROLLER_KEY = 'action_controller.instance'
+      ENDPOINT_KEY = 'api.endpoint'
       ALLOWED_SUFFIXES = Set.new(%w[json js atom rss xml zip])
 
       def initialize(env)
diff --git a/lib/gitlab/middleware/multipart.rb b/lib/gitlab/middleware/multipart.rb
index 433151b80e7..86b28e4e20a 100644
--- a/lib/gitlab/middleware/multipart.rb
+++ b/lib/gitlab/middleware/multipart.rb
@@ -28,7 +28,7 @@
 module Gitlab
   module Middleware
     class Multipart
-      RACK_ENV_KEY = 'HTTP_GITLAB_WORKHORSE_MULTIPART_FIELDS'.freeze
+      RACK_ENV_KEY = 'HTTP_GITLAB_WORKHORSE_MULTIPART_FIELDS'
 
       class Handler
         def initialize(env, message)
diff --git a/lib/gitlab/middleware/read_only/controller.rb b/lib/gitlab/middleware/read_only/controller.rb
index 53e55269c6e..802ff18fc58 100644
--- a/lib/gitlab/middleware/read_only/controller.rb
+++ b/lib/gitlab/middleware/read_only/controller.rb
@@ -5,9 +5,9 @@ module Gitlab
     class ReadOnly
       class Controller
         DISALLOWED_METHODS = %w(POST PATCH PUT DELETE).freeze
-        APPLICATION_JSON = 'application/json'.freeze
+        APPLICATION_JSON = 'application/json'
         APPLICATION_JSON_TYPES = %W{#{APPLICATION_JSON} application/vnd.git-lfs+json}.freeze
-        ERROR_MESSAGE = 'You cannot perform write operations on a read-only instance'.freeze
+        ERROR_MESSAGE = 'You cannot perform write operations on a read-only instance'
 
         WHITELISTED_GIT_ROUTES = {
           'projects/git_http' => %w{git_upload_pack git_receive_pack}
diff --git a/lib/gitlab/path_regex.rb b/lib/gitlab/path_regex.rb
index d9c28ff1181..ee2ef91c65c 100644
--- a/lib/gitlab/path_regex.rb
+++ b/lib/gitlab/path_regex.rb
@@ -125,9 +125,9 @@ module Gitlab
     # allow non-regex validations, etc), `NAMESPACE_FORMAT_REGEX_JS` serves as a Javascript-compatible version of
     # `NAMESPACE_FORMAT_REGEX`, with the negative lookbehind assertion removed. This means that the client-side validation
     # will pass for usernames ending in `.atom` and `.git`, but will be caught by the server-side validation.
-    PATH_START_CHAR = '[a-zA-Z0-9_\.]'.freeze
-    PATH_REGEX_STR = PATH_START_CHAR + '[a-zA-Z0-9_\-\.]*'.freeze
-    NAMESPACE_FORMAT_REGEX_JS = PATH_REGEX_STR + '[a-zA-Z0-9_\-]|[a-zA-Z0-9_]'.freeze
+    PATH_START_CHAR = '[a-zA-Z0-9_\.]'
+    PATH_REGEX_STR = PATH_START_CHAR + '[a-zA-Z0-9_\-\.]*'
+    NAMESPACE_FORMAT_REGEX_JS = PATH_REGEX_STR + '[a-zA-Z0-9_\-]|[a-zA-Z0-9_]'
 
     NO_SUFFIX_REGEX = /(?<!\.git|\.atom)/.freeze
     NAMESPACE_FORMAT_REGEX = /(?:#{NAMESPACE_FORMAT_REGEX_JS})#{NO_SUFFIX_REGEX}/.freeze
diff --git a/lib/gitlab/performance_bar.rb b/lib/gitlab/performance_bar.rb
index 68af290d069..4445c876e7a 100644
--- a/lib/gitlab/performance_bar.rb
+++ b/lib/gitlab/performance_bar.rb
@@ -2,7 +2,7 @@
 
 module Gitlab
   module PerformanceBar
-    ALLOWED_USER_IDS_KEY = 'performance_bar_allowed_user_ids:v2'.freeze
+    ALLOWED_USER_IDS_KEY = 'performance_bar_allowed_user_ids:v2'
     EXPIRY_TIME_L1_CACHE = 1.minute
     EXPIRY_TIME_L2_CACHE = 5.minutes
 
diff --git a/lib/gitlab/polling_interval.rb b/lib/gitlab/polling_interval.rb
index 0f69990df63..fd66787b029 100644
--- a/lib/gitlab/polling_interval.rb
+++ b/lib/gitlab/polling_interval.rb
@@ -2,7 +2,7 @@
 
 module Gitlab
   class PollingInterval
-    HEADER_NAME = 'Poll-Interval'.freeze
+    HEADER_NAME = 'Poll-Interval'
 
     def self.set_header(response, interval:)
       if polling_enabled?
diff --git a/lib/gitlab/private_commit_email.rb b/lib/gitlab/private_commit_email.rb
index 536fc9dae3a..886c2c32d36 100644
--- a/lib/gitlab/private_commit_email.rb
+++ b/lib/gitlab/private_commit_email.rb
@@ -2,7 +2,7 @@
 
 module Gitlab
   module PrivateCommitEmail
-    TOKEN = "_private".freeze
+    TOKEN = "_private"
 
     class << self
       def regex
diff --git a/lib/gitlab/profiler.rb b/lib/gitlab/profiler.rb
index 425c30d67fe..3f26b84be20 100644
--- a/lib/gitlab/profiler.rb
+++ b/lib/gitlab/profiler.rb
@@ -3,7 +3,7 @@
 
 module Gitlab
   module Profiler
-    FILTERED_STRING = '[FILTERED]'.freeze
+    FILTERED_STRING = '[FILTERED]'
 
     IGNORE_BACKTRACES = %w[
       lib/gitlab/i18n.rb
diff --git a/lib/gitlab/prometheus/additional_metrics_parser.rb b/lib/gitlab/prometheus/additional_metrics_parser.rb
index bd4ca578840..ee3d98f3602 100644
--- a/lib/gitlab/prometheus/additional_metrics_parser.rb
+++ b/lib/gitlab/prometheus/additional_metrics_parser.rb
@@ -3,7 +3,7 @@
 module Gitlab
   module Prometheus
     module AdditionalMetricsParser
-      CONFIG_ROOT = 'config/prometheus'.freeze
+      CONFIG_ROOT = 'config/prometheus'
       MUTEX = Mutex.new
       extend self
 
diff --git a/lib/gitlab/query_limiting/middleware.rb b/lib/gitlab/query_limiting/middleware.rb
index 949ae79a047..f6ffbfe2645 100644
--- a/lib/gitlab/query_limiting/middleware.rb
+++ b/lib/gitlab/query_limiting/middleware.rb
@@ -5,8 +5,8 @@ module Gitlab
     # Middleware for reporting (or raising) when a request performs more than a
     # certain amount of database queries.
     class Middleware
-      CONTROLLER_KEY = 'action_controller.instance'.freeze
-      ENDPOINT_KEY = 'api.endpoint'.freeze
+      CONTROLLER_KEY = 'action_controller.instance'
+      ENDPOINT_KEY = 'api.endpoint'
 
       def initialize(app)
         @app = app
diff --git a/lib/gitlab/quick_actions/issuable_actions.rb b/lib/gitlab/quick_actions/issuable_actions.rb
index e5d99ebee35..5cf24823ef5 100644
--- a/lib/gitlab/quick_actions/issuable_actions.rb
+++ b/lib/gitlab/quick_actions/issuable_actions.rb
@@ -1,3 +1,4 @@
+# coding: utf-8
 # frozen_string_literal: true
 
 module Gitlab
@@ -6,8 +7,8 @@ module Gitlab
       extend ActiveSupport::Concern
       include Gitlab::QuickActions::Dsl
 
-      SHRUG = '¯\\＿(ツ)＿/¯'.freeze
-      TABLEFLIP = '(╯°□°)╯︵ ┻━┻'.freeze
+      SHRUG = '¯\\＿(ツ)＿/¯'
+      TABLEFLIP = '(╯°□°)╯︵ ┻━┻'
 
       included do
         # Issue, MergeRequest, Epic: quick actions definitions
diff --git a/lib/gitlab/redis/cache.rb b/lib/gitlab/redis/cache.rb
index 6e8403ad878..6e31c506438 100644
--- a/lib/gitlab/redis/cache.rb
+++ b/lib/gitlab/redis/cache.rb
@@ -6,9 +6,9 @@ require_relative 'wrapper' unless defined?(::Rails) && ::Rails.root.present?
 module Gitlab
   module Redis
     class Cache < ::Gitlab::Redis::Wrapper
-      CACHE_NAMESPACE = 'cache:gitlab'.freeze
-      DEFAULT_REDIS_CACHE_URL = 'redis://localhost:6380'.freeze
-      REDIS_CACHE_CONFIG_ENV_VAR_NAME = 'GITLAB_REDIS_CACHE_CONFIG_FILE'.freeze
+      CACHE_NAMESPACE = 'cache:gitlab'
+      DEFAULT_REDIS_CACHE_URL = 'redis://localhost:6380'
+      REDIS_CACHE_CONFIG_ENV_VAR_NAME = 'GITLAB_REDIS_CACHE_CONFIG_FILE'
 
       class << self
         def default_url
diff --git a/lib/gitlab/redis/queues.rb b/lib/gitlab/redis/queues.rb
index 8b42c269dd0..0375e4a221a 100644
--- a/lib/gitlab/redis/queues.rb
+++ b/lib/gitlab/redis/queues.rb
@@ -6,10 +6,10 @@ require_relative 'wrapper' unless defined?(::Gitlab::Redis::Wrapper)
 module Gitlab
   module Redis
     class Queues < ::Gitlab::Redis::Wrapper
-      SIDEKIQ_NAMESPACE = 'resque:gitlab'.freeze
-      MAILROOM_NAMESPACE = 'mail_room:gitlab'.freeze
-      DEFAULT_REDIS_QUEUES_URL = 'redis://localhost:6381'.freeze
-      REDIS_QUEUES_CONFIG_ENV_VAR_NAME = 'GITLAB_REDIS_QUEUES_CONFIG_FILE'.freeze
+      SIDEKIQ_NAMESPACE = 'resque:gitlab'
+      MAILROOM_NAMESPACE = 'mail_room:gitlab'
+      DEFAULT_REDIS_QUEUES_URL = 'redis://localhost:6381'
+      REDIS_QUEUES_CONFIG_ENV_VAR_NAME = 'GITLAB_REDIS_QUEUES_CONFIG_FILE'
 
       class << self
         def default_url
diff --git a/lib/gitlab/redis/shared_state.rb b/lib/gitlab/redis/shared_state.rb
index 270a19e780c..35356083f26 100644
--- a/lib/gitlab/redis/shared_state.rb
+++ b/lib/gitlab/redis/shared_state.rb
@@ -6,12 +6,12 @@ require_relative 'wrapper' unless defined?(::Gitlab::Redis::Wrapper)
 module Gitlab
   module Redis
     class SharedState < ::Gitlab::Redis::Wrapper
-      SESSION_NAMESPACE = 'session:gitlab'.freeze
-      USER_SESSIONS_NAMESPACE = 'session:user:gitlab'.freeze
-      USER_SESSIONS_LOOKUP_NAMESPACE = 'session:lookup:user:gitlab'.freeze
-      IP_SESSIONS_LOOKUP_NAMESPACE = 'session:lookup:ip:gitlab'.freeze
-      DEFAULT_REDIS_SHARED_STATE_URL = 'redis://localhost:6382'.freeze
-      REDIS_SHARED_STATE_CONFIG_ENV_VAR_NAME = 'GITLAB_REDIS_SHARED_STATE_CONFIG_FILE'.freeze
+      SESSION_NAMESPACE = 'session:gitlab'
+      USER_SESSIONS_NAMESPACE = 'session:user:gitlab'
+      USER_SESSIONS_LOOKUP_NAMESPACE = 'session:lookup:user:gitlab'
+      IP_SESSIONS_LOOKUP_NAMESPACE = 'session:lookup:ip:gitlab'
+      DEFAULT_REDIS_SHARED_STATE_URL = 'redis://localhost:6382'
+      REDIS_SHARED_STATE_CONFIG_ENV_VAR_NAME = 'GITLAB_REDIS_SHARED_STATE_CONFIG_FILE'
 
       class << self
         def default_url
diff --git a/lib/gitlab/redis/wrapper.rb b/lib/gitlab/redis/wrapper.rb
index 07a1e20b076..fa1615a5953 100644
--- a/lib/gitlab/redis/wrapper.rb
+++ b/lib/gitlab/redis/wrapper.rb
@@ -8,8 +8,8 @@ require 'active_support/core_ext/module/delegation'
 module Gitlab
   module Redis
     class Wrapper
-      DEFAULT_REDIS_URL = 'redis://localhost:6379'.freeze
-      REDIS_CONFIG_ENV_VAR_NAME = 'GITLAB_REDIS_CONFIG_FILE'.freeze
+      DEFAULT_REDIS_URL = 'redis://localhost:6379'
+      REDIS_CONFIG_ENV_VAR_NAME = 'GITLAB_REDIS_CONFIG_FILE'
 
       class << self
         delegate :params, :url, to: :new
diff --git a/lib/gitlab/request_profiler.rb b/lib/gitlab/request_profiler.rb
index 033e451dbee..dd1482da40d 100644
--- a/lib/gitlab/request_profiler.rb
+++ b/lib/gitlab/request_profiler.rb
@@ -4,7 +4,7 @@ require 'fileutils'
 
 module Gitlab
   module RequestProfiler
-    PROFILES_DIR = "#{Gitlab.config.shared.path}/tmp/requests_profiles".freeze
+    PROFILES_DIR = "#{Gitlab.config.shared.path}/tmp/requests_profiles"
 
     def all
       Dir["#{PROFILES_DIR}/*.{html,txt}"].map do |path|
diff --git a/lib/gitlab/shard_health_cache.rb b/lib/gitlab/shard_health_cache.rb
index 6612347438e..eeb0cc75ef9 100644
--- a/lib/gitlab/shard_health_cache.rb
+++ b/lib/gitlab/shard_health_cache.rb
@@ -2,7 +2,7 @@
 
 module Gitlab
   class ShardHealthCache
-    HEALTHY_SHARDS_KEY = 'gitlab-healthy-shards'.freeze
+    HEALTHY_SHARDS_KEY = 'gitlab-healthy-shards'
     HEALTHY_SHARDS_TIMEOUT = 300
 
     # Clears the Redis set storing the list of healthy shards
diff --git a/lib/gitlab/sidekiq_monitor.rb b/lib/gitlab/sidekiq_monitor.rb
index 9842f1f53f7..a58b33534bf 100644
--- a/lib/gitlab/sidekiq_monitor.rb
+++ b/lib/gitlab/sidekiq_monitor.rb
@@ -4,7 +4,7 @@ module Gitlab
   class SidekiqMonitor < Daemon
     include ::Gitlab::Utils::StrongMemoize
 
-    NOTIFICATION_CHANNEL = 'sidekiq:cancel:notifications'.freeze
+    NOTIFICATION_CHANNEL = 'sidekiq:cancel:notifications'
     CANCEL_DEADLINE = 24.hours.seconds
     RECONNECT_TIME = 3.seconds
 
diff --git a/lib/gitlab/sidekiq_status.rb b/lib/gitlab/sidekiq_status.rb
index 0f890a12134..0dafccb3d34 100644
--- a/lib/gitlab/sidekiq_status.rb
+++ b/lib/gitlab/sidekiq_status.rb
@@ -18,7 +18,7 @@ module Gitlab
   # expire after a certain period of time to prevent storing too many keys in
   # Redis.
   module SidekiqStatus
-    STATUS_KEY = 'gitlab-sidekiq-status:%s'.freeze
+    STATUS_KEY = 'gitlab-sidekiq-status:%s'
 
     # The default time (in seconds) after which a status key is expired
     # automatically. The default of 30 minutes should be more than sufficient
diff --git a/lib/gitlab/url_helpers.rb b/lib/gitlab/url_helpers.rb
index 883585c196f..2a7919883c5 100644
--- a/lib/gitlab/url_helpers.rb
+++ b/lib/gitlab/url_helpers.rb
@@ -2,7 +2,7 @@
 
 module Gitlab
   class UrlHelpers
-    WSS_PROTOCOL = "wss".freeze
+    WSS_PROTOCOL = "wss"
     def self.as_wss(url)
       return unless url.present?
 
diff --git a/lib/gitlab/workhorse.rb b/lib/gitlab/workhorse.rb
index 139ec6e384a..db67e4fd479 100644
--- a/lib/gitlab/workhorse.rb
+++ b/lib/gitlab/workhorse.rb
@@ -7,13 +7,13 @@ require 'uri'
 
 module Gitlab
   class Workhorse
-    SEND_DATA_HEADER = 'Gitlab-Workhorse-Send-Data'.freeze
-    VERSION_FILE = 'GITLAB_WORKHORSE_VERSION'.freeze
-    INTERNAL_API_CONTENT_TYPE = 'application/vnd.gitlab-workhorse+json'.freeze
-    INTERNAL_API_REQUEST_HEADER = 'Gitlab-Workhorse-Api-Request'.freeze
-    NOTIFICATION_CHANNEL = 'workhorse:notifications'.freeze
+    SEND_DATA_HEADER = 'Gitlab-Workhorse-Send-Data'
+    VERSION_FILE = 'GITLAB_WORKHORSE_VERSION'
+    INTERNAL_API_CONTENT_TYPE = 'application/vnd.gitlab-workhorse+json'
+    INTERNAL_API_REQUEST_HEADER = 'Gitlab-Workhorse-Api-Request'
+    NOTIFICATION_CHANNEL = 'workhorse:notifications'
     ALLOWED_GIT_HTTP_ACTIONS = %w[git_receive_pack git_upload_pack info_refs].freeze
-    DETECT_HEADER = 'Gitlab-Workhorse-Detect-Content-Type'.freeze
+    DETECT_HEADER = 'Gitlab-Workhorse-Detect-Content-Type'
 
     include JwtAuthenticatable