summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHeinrich Lee Yu <heinrich@gitlab.com>2019-05-13 01:13:30 -0500
committerHeinrich Lee Yu <heinrich@gitlab.com>2019-05-14 00:10:46 -0500
commit99f06bc8589cf65012898ca5b32328613d5bd602 (patch)
treecf06f16baba4aa9ac479ecc9cb4b7443eac6f189
parent74511b049743cf543694bb92a8acd7e7586e533d (diff)
downloadgitlab-ce-99f06bc8589cf65012898ca5b32328613d5bd602.tar.gz
Fix hiding of quick action prompt in specsfix-slow-preview-note-specs
-rw-r--r--spec/support/helpers/features/notes_helpers.rb10
1 files changed, 4 insertions, 6 deletions
diff --git a/spec/support/helpers/features/notes_helpers.rb b/spec/support/helpers/features/notes_helpers.rb
index 38f30a14409..8a139fafac2 100644
--- a/spec/support/helpers/features/notes_helpers.rb
+++ b/spec/support/helpers/features/notes_helpers.rb
@@ -25,12 +25,10 @@ module Spec
page.within('.js-main-target-form') do
filled_text = fill_in('note[note]', with: text)
- begin
- # Dismiss quick action prompt if it appears
- filled_text.parent.send_keys(:escape)
- rescue Selenium::WebDriver::Error::ElementNotInteractableError
- # It's fine if we can't escape when there's no prompt.
- end
+ # Wait for quick action prompt to load and then dismiss it with ESC
+ # because it may block the Preview button
+ wait_for_requests
+ filled_text.send_keys(:escape)
click_on('Preview')