summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZeger-Jan van de Weg <git@zjvandeweg.nl>2019-06-27 14:10:05 +0200
committerZeger-Jan van de Weg <git@zjvandeweg.nl>2019-07-05 14:40:13 +0200
commit031e91beebfe6d9de469a3635ba898e434da9d31 (patch)
tree2fff7e11fe82c8064eb43aadf350bb0830622adf
parente049fe0d2ea585818cd4a6a65a1d71cbee365a52 (diff)
downloadgitlab-ce-031e91beebfe6d9de469a3635ba898e434da9d31.tar.gz
Remove high cardinality Prometheus metriczj-praefect-config-gitlab-yml
The metric was used to correlate Gitaly requests to the Rails controller and action combination. However, Kibana provides better observability in this specific metric, and can handle hig cardinality much better. There's no dashboard in Grafana that currently depends on this metric being exposed.
-rw-r--r--lib/gitlab/gitaly_client.rb9
1 files changed, 0 insertions, 9 deletions
diff --git a/lib/gitlab/gitaly_client.rb b/lib/gitlab/gitaly_client.rb
index 47976389af6..9e3de910e3c 100644
--- a/lib/gitlab/gitaly_client.rb
+++ b/lib/gitlab/gitaly_client.rb
@@ -33,11 +33,6 @@ module Gitlab
MUTEX = Mutex.new
- define_histogram :gitaly_controller_action_duration_seconds do
- docstring "Gitaly endpoint histogram by controller and action combination"
- base_labels Gitlab::Metrics::Transaction::BASE_LABELS.merge(gitaly_service: nil, rpc: nil)
- end
-
def self.stub(name, storage)
MUTEX.synchronize do
@stubs ||= {}
@@ -161,10 +156,6 @@ module Gitlab
# Keep track, separately, for the performance bar
self.query_time += duration
- gitaly_controller_action_duration_seconds.observe(
- current_transaction_labels.merge(gitaly_service: service.to_s, rpc: rpc.to_s),
- duration)
-
if peek_enabled?
add_call_details(feature: "#{service}##{rpc}", duration: duration, request: request_hash, rpc: rpc,
backtrace: Gitlab::Profiler.clean_backtrace(caller))