diff options
| author | Victor Zagorodny <vzagorodny@gitlab.com> | 2019-07-09 15:05:40 +0300 |
|---|---|---|
| committer | Victor Zagorodny <vzagorodny@gitlab.com> | 2019-07-09 15:43:06 +0300 |
| commit | a1d2ba46363eb6f761940de689c1dcc7afacbdf8 (patch) | |
| tree | 748d2e73ef1d3cb8de87a593e972c5c89d8e74aa | |
| parent | 272b9b8b8d49a3b2877e629f6373db2df9f7d5f3 (diff) | |
| download | gitlab-ce-a1d2ba46363eb6f761940de689c1dcc7afacbdf8.tar.gz | |
Remove GL CI/CD code for shfmt
| -rw-r--r-- | doc/development/shell_scripting_guide/index.md | 23 |
1 files changed, 0 insertions, 23 deletions
diff --git a/doc/development/shell_scripting_guide/index.md b/doc/development/shell_scripting_guide/index.md index 2ada0560040..08c40974c79 100644 --- a/doc/development/shell_scripting_guide/index.md +++ b/doc/development/shell_scripting_guide/index.md @@ -80,34 +80,11 @@ shfmt -i 2 -ci -ln posix scripts/**/*.sh TIP: **Tip:** Use `-ln` flag to specify the shell dialect (`-ln posix` or `-ln bash`). -This tool should be also used in the GitLab CI/CD to check for the formatting instead of writing formatted files. - NOTE: **Note:** Currently, the `shfmt` tool [is not shipped](https://github.com/mvdan/sh/issues/68) as a Docker image containing a Linux shell. This makes it impossible to use the [official Docker image](https://hub.docker.com/r/mvdan/shfmt) in GitLab Runner. This [may change](https://github.com/mvdan/sh/issues/68#issuecomment-507721371) in future. -For instance, - -```yaml -shell fmt lint: - image: alpine - stage: test - before_script: - - | - if [ ! -f ./bin/shfmt ]; then - mkdir -p .bin - wget https://github.com/mvdan/sh/releases/download/v2.6.4/shfmt_v2.6.4_linux_amd64 > .bin/shfmt - fi - - chmod +x .bin/shfmt - - .bin/shfmt -version - script: - - .bin/shfmt -i 2 -ci -l -ln posix scripts/**/*.sh - cache: - paths: - - .bin/shfmt -``` - ## Testing NOTE: **Note:** |