summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEvan Read <eread@gitlab.com>2019-08-09 00:28:31 +0000
committerEvan Read <eread@gitlab.com>2019-08-09 00:28:31 +0000
commit6cb4dc6190acd23379b79647d65f5b67b48fa966 (patch)
tree884e1b307ea84cf5fdbe4f8fd1fe82b86ca3555d
parent00223f91f316a0d09b158595990cf1cd237c27ec (diff)
parent19f36a34521d9fb5921f3422b4ef6b3a412fa394 (diff)
downloadgitlab-ce-6cb4dc6190acd23379b79647d65f5b67b48fa966.tar.gz
Merge branch 'migration-style-guide-docs' into 'master'
Update Migration Style Guide. Remove MySQL mentions See merge request gitlab-org/gitlab-ce!31531
-rw-r--r--doc/development/migration_style_guide.md11
1 files changed, 3 insertions, 8 deletions
diff --git a/doc/development/migration_style_guide.md b/doc/development/migration_style_guide.md
index 0c7601b415e..3181b3a88cc 100644
--- a/doc/development/migration_style_guide.md
+++ b/doc/development/migration_style_guide.md
@@ -10,9 +10,7 @@ migrations are written carefully, can be applied online and adhere to the style
guide below.
Migrations are **not** allowed to require GitLab installations to be taken
-offline unless _absolutely necessary_. Downtime assumptions should be based on
-the behaviour of a migration when performed using PostgreSQL, as various
-operations in MySQL may require downtime without there being alternatives.
+offline unless _absolutely necessary_.
When downtime is necessary the migration has to be approved by:
@@ -343,10 +341,7 @@ class AddOptionsToBuildMetadata < ActiveRecord::Migration[5.0]
end
```
-On MySQL the `JSON` and `JSONB` is translated to `TEXT 1MB`, as `JSONB` is PostgreSQL only feature.
-
-For above reason you have to use a serializer to provide a translation layer
-in order to support PostgreSQL and MySQL seamlessly:
+You have to use a serializer to provide a translation layer:
```ruby
class BuildMetadata
@@ -356,7 +351,7 @@ end
## Testing
-Make sure that your migration works with MySQL and PostgreSQL with data. An
+Make sure that your migration works for databases with data. An
empty database does not guarantee that your migration is correct.
Make sure your migration can be reversed.