diff options
| author | rpereira2 <rpereira@gitlab.com> | 2019-02-01 16:31:51 +0530 |
|---|---|---|
| committer | rpereira2 <rpereira@gitlab.com> | 2019-02-06 21:04:37 +0530 |
| commit | 1bb4686670c30286df3742d0acd9a613cdb51f28 (patch) | |
| tree | 4b8eabe5d2bfbe51bc321aca1c432e411deb7401 | |
| parent | 29c3c93b9aa61b5a2f243835ba81a052b1d429f4 (diff) | |
| download | gitlab-ce-1bb4686670c30286df3742d0acd9a613cdb51f28.tar.gz | |
Reduce cognitive complexity of execute method
| -rw-r--r-- | app/services/error_tracking/list_sentry_projects_service.rb | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/app/services/error_tracking/list_sentry_projects_service.rb b/app/services/error_tracking/list_sentry_projects_service.rb index 955fe7d4a09..c07ab0e84a2 100644 --- a/app/services/error_tracking/list_sentry_projects_service.rb +++ b/app/services/error_tracking/list_sentry_projects_service.rb @@ -11,14 +11,15 @@ module ErrorTracking return error(e.errors.full_messages.join(', '), :bad_request) end - result = e.list_sentry_projects + begin + result = e.list_sentry_projects + rescue Sentry::Client::Error => e + return error(e.message, :bad_request) + rescue Sentry::Client::SentryError => e + return error(e.message, :unprocessable_entity) + end success(projects: result[:projects]) - - rescue Sentry::Client::Error => e - error(e.message, :bad_request) - rescue Sentry::Client::SentryError => e - error(e.message, :unprocessable_entity) end private |
