diff options
author | Filipa Lacerda <filipa@gitlab.com> | 2018-09-28 08:04:23 +0000 |
---|---|---|
committer | Filipa Lacerda <filipa@gitlab.com> | 2018-09-28 08:04:23 +0000 |
commit | 71891664a1bdd0c766f27e24fe7141f0f48cf751 (patch) | |
tree | f5fd625e36ae755b61f0398b301d93ee90bf87e3 | |
parent | bfa94a5fa2542f8822c8aba83b2b903fcced0ba4 (diff) | |
parent | 7f395e862a60699823fdb9813da66ae060336b6c (diff) | |
download | gitlab-ce-71891664a1bdd0c766f27e24fe7141f0f48cf751.tar.gz |
Merge branch 'rename-local-variable' into 'master'
Rename block scope local variable in table pagination spec
See merge request gitlab-org/gitlab-ce!21969
-rw-r--r-- | changelogs/unreleased/rename-local-variable.yml | 5 | ||||
-rw-r--r-- | spec/javascripts/vue_shared/components/table_pagination_spec.js | 22 |
2 files changed, 16 insertions, 11 deletions
diff --git a/changelogs/unreleased/rename-local-variable.yml b/changelogs/unreleased/rename-local-variable.yml new file mode 100644 index 00000000000..70281dfef08 --- /dev/null +++ b/changelogs/unreleased/rename-local-variable.yml @@ -0,0 +1,5 @@ +--- +title: Rename block scope local variable in table pagination spec +merge_request: 21969 +author: George Tsiolis +type: other diff --git a/spec/javascripts/vue_shared/components/table_pagination_spec.js b/spec/javascripts/vue_shared/components/table_pagination_spec.js index c36b607a34e..d193667210b 100644 --- a/spec/javascripts/vue_shared/components/table_pagination_spec.js +++ b/spec/javascripts/vue_shared/components/table_pagination_spec.js @@ -5,13 +5,13 @@ describe('Pagination component', () => { let component; let PaginationComponent; let spy; - let mountComponet; + let mountComponent; beforeEach(() => { spy = jasmine.createSpy('spy'); PaginationComponent = Vue.extend(paginationComp); - mountComponet = function (props) { + mountComponent = function (props) { return new PaginationComponent({ propsData: props, }).$mount(); @@ -20,7 +20,7 @@ describe('Pagination component', () => { describe('render', () => { it('should not render anything', () => { - component = mountComponet({ + component = mountComponent({ pageInfo: { nextPage: 1, page: 1, @@ -37,7 +37,7 @@ describe('Pagination component', () => { describe('prev button', () => { it('should be disabled and non clickable', () => { - component = mountComponet({ + component = mountComponent({ pageInfo: { nextPage: 2, page: 1, @@ -59,7 +59,7 @@ describe('Pagination component', () => { }); it('should be enabled and clickable', () => { - component = mountComponet({ + component = mountComponent({ pageInfo: { nextPage: 3, page: 2, @@ -78,7 +78,7 @@ describe('Pagination component', () => { describe('first button', () => { it('should call the change callback with the first page', () => { - component = mountComponet({ + component = mountComponent({ pageInfo: { nextPage: 3, page: 2, @@ -102,7 +102,7 @@ describe('Pagination component', () => { describe('last button', () => { it('should call the change callback with the last page', () => { - component = mountComponet({ + component = mountComponent({ pageInfo: { nextPage: 3, page: 2, @@ -126,7 +126,7 @@ describe('Pagination component', () => { describe('next button', () => { it('should be disabled and non clickable', () => { - component = mountComponet({ + component = mountComponent({ pageInfo: { nextPage: 5, page: 5, @@ -148,7 +148,7 @@ describe('Pagination component', () => { }); it('should be enabled and clickable', () => { - component = mountComponet({ + component = mountComponent({ pageInfo: { nextPage: 4, page: 3, @@ -168,7 +168,7 @@ describe('Pagination component', () => { describe('numbered buttons', () => { it('should render 5 pages', () => { - component = mountComponet({ + component = mountComponent({ pageInfo: { nextPage: 4, page: 3, @@ -185,7 +185,7 @@ describe('Pagination component', () => { }); it('should render the spread operator', () => { - component = mountComponet({ + component = mountComponent({ pageInfo: { nextPage: 4, page: 3, |