summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFilipa Lacerda <filipa@gitlab.com>2017-05-05 07:32:36 +0000
committerPhil Hughes <me@iamphill.com>2017-05-05 07:32:36 +0000
commitf7a5ce923a3c0db9fc34f611b1a655c472503941 (patch)
tree99baa1fd9dc6e1b7c6fc9aec72a434df51da3759
parent64014b1595c6c55e01f017bb01c189a74726a8a0 (diff)
downloadgitlab-ce-f7a5ce923a3c0db9fc34f611b1a655c472503941.tar.gz
Remove # char for commit
-rw-r--r--app/assets/javascripts/merge_request_widget.js2
-rw-r--r--changelogs/unreleased/31810-commit-link.yml4
2 files changed, 5 insertions, 1 deletions
diff --git a/app/assets/javascripts/merge_request_widget.js b/app/assets/javascripts/merge_request_widget.js
index 42ecf0d6cb2..6f6ae9bde92 100644
--- a/app/assets/javascripts/merge_request_widget.js
+++ b/app/assets/javascripts/merge_request_widget.js
@@ -291,7 +291,7 @@ import MiniPipelineGraph from './mini_pipeline_graph_dropdown';
MergeRequestWidget.prototype.updateCommitUrls = function(id) {
const commitsUrl = this.opts.commits_path;
- $('.js-commit-link').text(`#${id}`).attr('href', [commitsUrl, id].join('/'));
+ $('.js-commit-link').text(id).attr('href', [commitsUrl, id].join('/'));
};
MergeRequestWidget.prototype.initMiniPipelineGraph = function() {
diff --git a/changelogs/unreleased/31810-commit-link.yml b/changelogs/unreleased/31810-commit-link.yml
new file mode 100644
index 00000000000..857c9cb95c5
--- /dev/null
+++ b/changelogs/unreleased/31810-commit-link.yml
@@ -0,0 +1,4 @@
+---
+title: Remove `#` being added on commit sha in MR widget
+merge_request:
+author: