diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2022-07-20 15:40:28 +0000 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2022-07-20 15:40:28 +0000 |
| commit | b595cb0c1dec83de5bdee18284abe86614bed33b (patch) | |
| tree | 8c3d4540f193c5ff98019352f554e921b3a41a72 /.rubocop_todo | |
| parent | 2f9104a328fc8a4bddeaa4627b595166d24671d0 (diff) | |
| download | gitlab-ce-b595cb0c1dec83de5bdee18284abe86614bed33b.tar.gz | |
Add latest changes from gitlab-org/gitlab@15-2-stable-eev15.2.0-rc42
Diffstat (limited to '.rubocop_todo')
56 files changed, 48 insertions, 661 deletions
diff --git a/.rubocop_todo/capybara/visibility_matcher.yml b/.rubocop_todo/capybara/visibility_matcher.yml index 015e246344d..90d71fe2d3a 100644 --- a/.rubocop_todo/capybara/visibility_matcher.yml +++ b/.rubocop_todo/capybara/visibility_matcher.yml @@ -18,7 +18,6 @@ Capybara/VisibilityMatcher: - 'ee/spec/features/projects/requirements_management/requirements_list_spec.rb' - 'ee/spec/features/projects/settings/ee/repository_mirrors_settings_spec.rb' - 'ee/spec/features/promotion_spec.rb' - - 'ee/spec/features/refactor_blob_viewer_disabled/projects/path_locks_spec.rb' - 'ee/spec/features/registrations/welcome_spec.rb' - 'ee/spec/support/shared_examples/views/issuable_bulk_dropdown_shared_examples.rb' - 'ee/spec/views/layouts/_search.html.haml_spec.rb' @@ -62,8 +61,6 @@ Capybara/VisibilityMatcher: - 'spec/features/projects/tags/user_edits_tags_spec.rb' - 'spec/features/projects/user_changes_project_visibility_spec.rb' - 'spec/features/projects/user_sees_user_popover_spec.rb' - - 'spec/features/refactor_blob_viewer_disabled/projects/blobs/blob_show_spec.rb' - - 'spec/features/refactor_blob_viewer_disabled/projects/blobs/user_follows_pipeline_suggest_nudge_spec.rb' - 'spec/features/search/user_searches_for_commits_spec.rb' - 'spec/features/snippets/notes_on_personal_snippets_spec.rb' - 'spec/features/task_lists_spec.rb' diff --git a/.rubocop_todo/cop/user_admin.yml b/.rubocop_todo/cop/user_admin.yml index ab5f76a002d..c9eed57e74d 100644 --- a/.rubocop_todo/cop/user_admin.yml +++ b/.rubocop_todo/cop/user_admin.yml @@ -2,7 +2,6 @@ Cop/UserAdmin: Exclude: - app/controllers/admin/impersonations_controller.rb - - app/controllers/concerns/spammable_actions.rb - app/controllers/sessions_controller.rb - app/finders/autocomplete/routes_finder.rb - app/finders/ci/jobs_finder.rb @@ -32,8 +31,6 @@ Cop/UserAdmin: - app/services/projects/fork_service.rb - app/services/users/build_service.rb - ee/app/controllers/ee/projects_controller.rb - - ee/app/graphql/mutations/admin/analytics/devops_adoption/segments/mixins.rb - - ee/app/graphql/resolvers/admin/analytics/devops_adoption/segments_resolver.rb - ee/app/helpers/ee/dashboard_helper.rb - ee/app/helpers/ee/import_helper.rb - ee/app/helpers/ee/subscribable_banner_helper.rb @@ -53,7 +50,6 @@ Cop/UserAdmin: - lib/api/award_emoji.rb - lib/api/ci/runners.rb - lib/api/entities/ci/runner_details.rb - - lib/api/entities/ci/user_safe.rb - lib/api/groups.rb - lib/api/helpers.rb - lib/api/personal_access_tokens.rb @@ -61,7 +57,6 @@ Cop/UserAdmin: - lib/api/v3/github.rb - lib/constraints/admin_constrainer.rb - lib/gitlab/auth.rb - - lib/gitlab/background_migration/user_mentions/models/group.rb - lib/gitlab/ci/runner_instructions.rb - lib/gitlab/import_export/members_mapper.rb - lib/gitlab/performance_bar.rb diff --git a/.rubocop_todo/database/rescue_query_canceled.yml b/.rubocop_todo/database/rescue_query_canceled.yml new file mode 100644 index 00000000000..76635ca4018 --- /dev/null +++ b/.rubocop_todo/database/rescue_query_canceled.yml @@ -0,0 +1,9 @@ +--- +Database/RescueQueryCanceled: + Exclude: + - 'app/services/issues/relative_position_rebalancing_service.rb' + - 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb' + - 'lib/gitlab/background_migration/backfill_work_item_type_id_for_issues.rb' + - 'lib/gitlab/database/batch_counter.rb' + - 'lib/gitlab/issuables_count_for_state.rb' + - 'lib/tasks/gitlab/db/lock_writes.rake' diff --git a/.rubocop_todo/database/rescue_statement_timeout.yml b/.rubocop_todo/database/rescue_statement_timeout.yml new file mode 100644 index 00000000000..dc6b0bdfab3 --- /dev/null +++ b/.rubocop_todo/database/rescue_statement_timeout.yml @@ -0,0 +1,5 @@ +--- +Database/RescueStatementTimeout: + Exclude: + - 'app/services/issues/relative_position_rebalancing_service.rb' + - 'lib/gitlab/background_migration/backfill_work_item_type_id_for_issues.rb' diff --git a/.rubocop_todo/fips/open_ssl.yml b/.rubocop_todo/fips/open_ssl.yml deleted file mode 100644 index 03a551112ab..00000000000 --- a/.rubocop_todo/fips/open_ssl.yml +++ /dev/null @@ -1,222 +0,0 @@ ---- -# Cop supports --auto-correct. -Fips/OpenSSL: - Exclude: - - 'app/controllers/application_controller.rb' - - 'app/controllers/concerns/authenticates_with_two_factor.rb' - - 'app/controllers/projects/merge_requests/diffs_controller.rb' - - 'app/controllers/projects/merge_requests_controller.rb' - - 'app/helpers/application_helper.rb' - - 'app/models/ci/artifact_blob.rb' - - 'app/models/concerns/analytics/cycle_analytics/stage.rb' - - 'app/models/concerns/checksummable.rb' - - 'app/models/concerns/token_authenticatable_strategies/encryption_helper.rb' - - 'app/models/diff_discussion.rb' - - 'app/models/discussion.rb' - - 'app/models/legacy_diff_note.rb' - - 'app/models/namespace.rb' - - 'app/models/note.rb' - - 'app/models/performance_monitoring/prometheus_panel.rb' - - 'app/models/protected_branch.rb' - - 'app/models/release_highlight.rb' - - 'app/models/repository.rb' - - 'app/models/resource_event.rb' - - 'app/models/snippet.rb' - - 'app/models/storage/hashed.rb' - - 'app/models/token_with_iv.rb' - - 'app/presenters/packages/composer/packages_presenter.rb' - - 'app/services/ci/build_report_result_service.rb' - - 'app/services/metrics/dashboard/transient_embed_service.rb' - - 'app/services/packages/debian/generate_distribution_service.rb' - - 'app/services/packages/go/create_package_service.rb' - - 'app/services/packages/maven/metadata/append_package_file_service.rb' - - 'app/services/packages/rubygems/create_gemspec_service.rb' - - 'app/services/pages/migrate_legacy_storage_to_deployment_service.rb' - - 'app/services/projects/lfs_pointers/lfs_download_service.rb' - - 'app/uploaders/ci/secure_file_uploader.rb' - - 'config/initializers/doorkeeper_openid_connect.rb' - - 'config/initializers/session_store.rb' - - 'config/settings.rb' - - 'db/post_migrate/20210731132939_backfill_stage_event_hash.rb' - - 'ee/app/models/storage_shard.rb' - - 'ee/app/services/elastic/bookkeeping_shard_service.rb' - - 'ee/app/services/security/track_scan_service.rb' - - 'ee/app/services/vulnerabilities/create_service_base.rb' - - 'ee/app/services/vulnerabilities/manually_create_service.rb' - - 'ee/app/services/vulnerabilities/starboard_vulnerability_create_service.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'ee/lib/gitlab/analytics/cycle_analytics/stage_events/label_based_stage_event.rb' - - 'ee/lib/gitlab/ci/reports/dependency_list/dependency.rb' - - 'ee/lib/gitlab/ci/reports/security/remediation.rb' - - 'ee/lib/gitlab/geo/replication/blob_downloader.rb' - - 'ee/spec/factories/vulnerabilities/feedback.rb' - - 'ee/spec/factories/vulnerabilities/finding_signatures.rb' - - 'ee/spec/factories/vulnerabilities/remediations.rb' - - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' - - 'ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/issue_label_added_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/issue_label_removed_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/merge_request_label_added_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/merge_request_label_removed_spec.rb' - - 'ee/spec/lib/gitlab/ci/reports/security/locations/cluster_image_scanning_spec.rb' - - 'ee/spec/lib/gitlab/ci/reports/security/locations/container_scanning_spec.rb' - - 'ee/spec/lib/gitlab/ci/reports/security/locations/dast_spec.rb' - - 'ee/spec/lib/gitlab/ci/reports/security/locations/dependency_scanning_spec.rb' - - 'ee/spec/migrations/update_vulnerability_occurrences_location_spec.rb' - - 'ee/spec/models/merge_train_spec.rb' - - 'ee/spec/models/resource_weight_event_spec.rb' - - 'ee/spec/models/vulnerabilities/finding_signature_spec.rb' - - 'ee/spec/models/vulnerabilities/finding_spec.rb' - - 'ee/spec/services/alert_management/process_prometheus_alert_service_spec.rb' - - 'ee/spec/services/merge_trains/check_status_service_spec.rb' - - 'ee/spec/services/projects/alerting/notify_service_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/ingest_identifiers_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/ingest_remediations_spec.rb' - - 'ee/spec/services/security/override_uuids_service_spec.rb' - - 'ee/spec/services/security/track_scan_service_spec.rb' - - 'ee/spec/services/vulnerabilities/manually_create_service_spec.rb' - - 'ee/spec/support/matchers/locked_schema.rb' - - 'lib/api/files.rb' - - 'lib/api/maven_packages.rb' - - 'lib/atlassian/jira_connect/serializers/branch_entity.rb' - - 'lib/container_registry/client.rb' - - 'lib/extracts_path.rb' - - 'lib/gitlab/alert_management/fingerprint.rb' - - 'lib/gitlab/analytics/cycle_analytics/stage_events/stage_event.rb' - - 'lib/gitlab/background_migration/backfill_note_discussion_id.rb' - - 'lib/gitlab/background_migration/backfill_project_repositories.rb' - - 'lib/gitlab/ci/pipeline/seed/build/cache.rb' - - 'lib/gitlab/ci/reports/security/finding.rb' - - 'lib/gitlab/ci/reports/security/finding_signature.rb' - - 'lib/gitlab/ci/reports/security/identifier.rb' - - 'lib/gitlab/ci/reports/security/locations/base.rb' - - 'lib/gitlab/ci/reports/test_case.rb' - - 'lib/gitlab/color.rb' - - 'lib/gitlab/composer/version_index.rb' - - 'lib/gitlab/crypto_helper.rb' - - 'lib/gitlab/database/migration_helpers.rb' - - 'lib/gitlab/database/migration_helpers/v2.rb' - - 'lib/gitlab/database/partitioning_migration_helpers/foreign_key_helpers.rb' - - 'lib/gitlab/database/schema_helpers.rb' - - 'lib/gitlab/database/schema_migrations/migrations.rb' - - 'lib/gitlab/database/unidirectional_copy_trigger.rb' - - 'lib/gitlab/diff/file.rb' - - 'lib/gitlab/diff/formatters/base_formatter.rb' - - 'lib/gitlab/diff/position.rb' - - 'lib/gitlab/experimentation/controller_concern.rb' - - 'lib/gitlab/git.rb' - - 'lib/gitlab/git/branch.rb' - - 'lib/gitlab/git/lfs_pointer_file.rb' - - 'lib/gitlab/git/tag.rb' - - 'lib/gitlab/hashed_path.rb' - - 'lib/gitlab/insecure_key_fingerprint.rb' - - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' - - 'lib/gitlab/slug/environment.rb' - - 'lib/gitlab/verify/job_artifacts.rb' - - 'lib/json_web_token/rsa_token.rb' - - 'lib/tasks/gitlab/assets.rake' - - 'lib/tasks/tanuki_emoji.rake' - - 'qa/qa/service/praefect_manager.rb' - - 'qa/qa/specs/features/browser_ui/6_release/deploy_key/clone_using_deploy_key_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb' - - 'scripts/security-harness' - - 'spec/components/diffs/stats_component_spec.rb' - - 'spec/controllers/projects/blob_controller_spec.rb' - - 'spec/factories/ci/job_artifacts.rb' - - 'spec/factories/ci/reports/security/finding_keys.rb' - - 'spec/factories/ci/unit_test.rb' - - 'spec/factories/commit_signature/gpg_signature.rb' - - 'spec/factories/commit_signature/ssh_signature.rb' - - 'spec/factories/commit_signature/x509_commit_signature.rb' - - 'spec/factories/design_management/designs.rb' - - 'spec/factories/diff_position.rb' - - 'spec/factories/gitaly/commit.rb' - - 'spec/factories/merge_request_context_commit.rb' - - 'spec/factories/merge_request_context_commit_diff_file.rb' - - 'spec/factories/merge_request_diff_commits.rb' - - 'spec/factories/merge_request_diffs.rb' - - 'spec/factories/pages_deployments.rb' - - 'spec/factories/sequences.rb' - - 'spec/factories/token_with_ivs.rb' - - 'spec/features/file_uploads/git_lfs_spec.rb' - - 'spec/features/merge_request/user_sees_diff_spec.rb' - - 'spec/features/merge_request/user_suggests_changes_on_diff_spec.rb' - - 'spec/finders/merge_requests/oldest_per_commit_finder_spec.rb' - - 'spec/lib/gitlab/alert_management/fingerprint_spec.rb' - - 'spec/lib/gitlab/alert_management/payload/base_spec.rb' - - 'spec/lib/gitlab/alert_management/payload/generic_spec.rb' - - 'spec/lib/gitlab/alert_management/payload/prometheus_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_note_discussion_id_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb' - - 'spec/lib/gitlab/ci/reports/security/finding_signature_spec.rb' - - 'spec/lib/gitlab/ci/reports/security/locations/sast_spec.rb' - - 'spec/lib/gitlab/ci/reports/security/locations/secret_detection_spec.rb' - - 'spec/lib/gitlab/ci/reports/test_case_spec.rb' - - 'spec/lib/gitlab/crypto_helper_spec.rb' - - 'spec/lib/gitlab/database/migration_helpers_spec.rb' - - 'spec/lib/gitlab/database/schema_migrations/migrations_spec.rb' - - 'spec/lib/gitlab/diff/file_spec.rb' - - 'spec/lib/gitlab/diff/position_spec.rb' - - 'spec/lib/gitlab/diff/position_tracer/image_strategy_spec.rb' - - 'spec/lib/gitlab/diff/position_tracer/line_strategy_spec.rb' - - 'spec/lib/gitlab/experimentation/controller_concern_spec.rb' - - 'spec/lib/gitlab/git/branch_spec.rb' - - 'spec/lib/gitlab/git/tag_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job_spec.rb' - - 'spec/lib/gitlab/slug/environment_spec.rb' - - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb' - - 'spec/migrations/20220524074947_finalize_backfill_null_note_discussion_ids_spec.rb' - - 'spec/migrations/delete_security_findings_without_uuid_spec.rb' - - 'spec/migrations/schedule_recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - - 'spec/models/ci/artifact_blob_spec.rb' - - 'spec/models/ci/job_artifact_spec.rb' - - 'spec/models/ci/pipeline_spec.rb' - - 'spec/models/ci/secure_file_spec.rb' - - 'spec/models/ci/unit_test_spec.rb' - - 'spec/models/concerns/checksummable_spec.rb' - - 'spec/models/concerns/token_authenticatable_strategies/encryption_helper_spec.rb' - - 'spec/models/design_management/version_spec.rb' - - 'spec/models/diff_discussion_spec.rb' - - 'spec/models/discussion_spec.rb' - - 'spec/models/lfs_object_spec.rb' - - 'spec/models/merge_request_diff_spec.rb' - - 'spec/models/merge_request_spec.rb' - - 'spec/models/note_spec.rb' - - 'spec/models/pages_deployment_spec.rb' - - 'spec/models/performance_monitoring/prometheus_panel_spec.rb' - - 'spec/models/project_spec.rb' - - 'spec/models/release_highlight_spec.rb' - - 'spec/models/repository_spec.rb' - - 'spec/models/token_with_iv_spec.rb' - - 'spec/models/upload_spec.rb' - - 'spec/requests/api/ci/runner/jobs_artifacts_spec.rb' - - 'spec/requests/api/ci/secure_files_spec.rb' - - 'spec/requests/openid_connect_spec.rb' - - 'spec/services/dependency_proxy/find_cached_manifest_service_spec.rb' - - 'spec/services/dependency_proxy/head_manifest_service_spec.rb' - - 'spec/services/dependency_proxy/request_token_service_spec.rb' - - 'spec/services/import_export_clean_up_service_spec.rb' - - 'spec/services/pages/migrate_legacy_storage_to_deployment_service_spec.rb' - - 'spec/services/projects/after_rename_service_spec.rb' - - 'spec/services/projects/create_service_spec.rb' - - 'spec/services/projects/lfs_pointers/lfs_download_service_spec.rb' - - 'spec/support/helpers/workhorse_helpers.rb' - - 'spec/support/migrations_helpers/vulnerabilities_findings_helper.rb' - - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' - - 'spec/support/shared_examples/lib/gitlab/cycle_analytics/event_shared_examples.rb' - - 'spec/support/shared_examples/lib/gitlab/position_formatters_shared_examples.rb' - - 'spec/support/shared_examples/services/alert_management/alert_processing/alert_firing_shared_examples.rb' - - 'spec/support/shared_examples/services/alert_management/alert_processing/alert_recovery_shared_examples.rb' - - 'spec/support/shared_examples/services/metrics/dashboard_shared_examples.rb' - - 'spec/support/shared_examples/services/packages/debian/generate_distribution_shared_examples.rb' - - 'spec/support/shared_examples/uploaders/object_storage_shared_examples.rb' - - 'spec/support/trace/trace_helpers.rb' - - 'spec/uploaders/ci/secure_file_uploader_spec.rb' - - 'spec/uploaders/job_artifact_uploader_spec.rb' - - 'spec/validators/sha_validator_spec.rb' - - 'spec/workers/update_head_pipeline_for_merge_request_worker_spec.rb' diff --git a/.rubocop_todo/gitlab/delegate_predicate_methods.yml b/.rubocop_todo/gitlab/delegate_predicate_methods.yml index 854cd3e0a83..44d603b3206 100644 --- a/.rubocop_todo/gitlab/delegate_predicate_methods.yml +++ b/.rubocop_todo/gitlab/delegate_predicate_methods.yml @@ -2,5 +2,3 @@ Gitlab/DelegatePredicateMethods: Exclude: - app/models/clusters/cluster.rb - - app/models/project.rb - - ee/app/models/concerns/ee/ci/metadatable.rb diff --git a/.rubocop_todo/gitlab/feature_available_usage.yml b/.rubocop_todo/gitlab/feature_available_usage.yml index 168edd94f90..92aad8b990e 100644 --- a/.rubocop_todo/gitlab/feature_available_usage.yml +++ b/.rubocop_todo/gitlab/feature_available_usage.yml @@ -6,7 +6,6 @@ Gitlab/FeatureAvailableUsage: - app/helpers/events_helper.rb - app/helpers/labels_helper.rb - app/policies/project_policy.rb - - app/views/shared/boards/_switcher.html.haml - ee/app/controllers/concerns/description_diff_actions.rb - ee/app/controllers/concerns/ee/boards_actions.rb - ee/app/controllers/concerns/security_dashboards_permissions.rb @@ -18,23 +17,18 @@ Gitlab/FeatureAvailableUsage: - ee/app/controllers/ee/projects/settings/operations_controller.rb - ee/app/controllers/ee/projects/settings/repository_controller.rb - ee/app/controllers/projects/audit_events_controller.rb - - ee/app/controllers/projects/cluster_agents_controller.rb - - ee/app/controllers/projects/iterations/inherited_controller.rb - ee/app/controllers/projects/iterations_controller.rb - ee/app/controllers/projects/path_locks_controller.rb - ee/app/controllers/projects/subscriptions_controller.rb - ee/app/finders/autocomplete/vulnerabilities_autocomplete_finder.rb - - ee/app/finders/clusters/agents_finder.rb - ee/app/finders/ee/alert_management/http_integrations_finder.rb - ee/app/graphql/ee/types/group_type.rb - ee/app/graphql/mutations/dast/profiles/create.rb - ee/app/graphql/mutations/dast/profiles/run.rb - ee/app/graphql/mutations/dast/profiles/update.rb - ee/app/graphql/mutations/instance_security_dashboard/remove_project.rb - - ee/app/graphql/resolvers/clusters/agent_tokens_resolver.rb - ee/app/helpers/ee/application_helper.rb - ee/app/helpers/ee/boards_helper.rb - - ee/app/helpers/ee/clusters_helper.rb - ee/app/helpers/ee/dashboard_helper.rb - ee/app/helpers/ee/form_helper.rb - ee/app/helpers/ee/graph_helper.rb @@ -50,7 +44,6 @@ Gitlab/FeatureAvailableUsage: - ee/app/models/concerns/approvable.rb - ee/app/models/concerns/ee/project_security_scanners_information.rb - ee/app/models/concerns/ee/protected_ref_access.rb - - ee/app/models/concerns/has_timelogs_report.rb - ee/app/models/concerns/insights_feature.rb - ee/app/models/ee/board.rb - ee/app/models/ee/ci/build.rb @@ -66,11 +59,9 @@ Gitlab/FeatureAvailableUsage: - ee/app/models/ee/namespace_setting.rb - ee/app/models/ee/project.rb - ee/app/models/ee/project_ci_cd_setting.rb - - ee/app/models/namespace_statistics.rb - ee/app/models/project_security_setting.rb - ee/app/policies/compliance_management/framework_policy.rb - ee/app/policies/ee/group_policy.rb - - ee/app/policies/ee/namespace_policy.rb - ee/app/policies/ee/project_policy.rb - ee/app/policies/ee/protected_branch_policy.rb - ee/app/presenters/ee/label_presenter.rb @@ -81,17 +72,8 @@ Gitlab/FeatureAvailableUsage: - ee/app/serializers/ee/note_entity.rb - ee/app/services/boards/epic_boards/update_service.rb - ee/app/services/ci/audit_variable_change_service.rb - - ee/app/services/clusters/agent_tokens/create_service.rb - - ee/app/services/clusters/agents/create_service.rb - ee/app/services/dashboard/projects/create_service.rb - ee/app/services/dashboard/projects/list_service.rb - - ee/app/services/dast/profiles/create_service.rb - - ee/app/services/dast/profiles/update_service.rb - - ee/app/services/dast_on_demand_scans/create_service.rb - - ee/app/services/dast_site_tokens/create_service.rb - - ee/app/services/dast_site_validations/create_service.rb - - ee/app/services/dast_site_validations/revoke_service.rb - - ee/app/services/dast_site_validations/validate_service.rb - ee/app/services/ee/alert_management/http_integrations/create_service.rb - ee/app/services/ee/audit_event_service.rb - ee/app/services/ee/boards/issues/list_service.rb @@ -119,8 +101,6 @@ Gitlab/FeatureAvailableUsage: - ee/app/services/quality_management/test_cases/create_service.rb - ee/app/services/requirements_management/process_test_reports_service.rb - ee/app/services/security/store_scans_service.rb - - ee/app/views/layouts/nav/_test_cases_link.html.haml - - ee/app/views/layouts/nav/sidebar/_project_iterations_link.html.haml - ee/app/views/projects/_merge_request_approvals_settings.html.haml - ee/app/views/projects/_merge_request_settings.html.haml - ee/app/views/projects/_merge_request_settings_description_text.html.haml @@ -128,14 +108,6 @@ Gitlab/FeatureAvailableUsage: - ee/app/views/projects/blob/_header_file_locks.html.haml - ee/app/views/projects/issues/_related_issues.html.haml - ee/app/views/projects/merge_requests/show.html.haml - - ee/app/views/projects/merge_requests/show.html.haml - - ee/app/views/projects/merge_requests/show.html.haml - - ee/app/views/projects/merge_requests/show.html.haml - - ee/app/views/projects/merge_requests/show.html.haml - - ee/app/views/projects/merge_requests/show.html.haml - - ee/app/views/projects/merge_requests/show.html.haml - - ee/app/views/projects/merge_requests/show.html.haml - - ee/app/views/projects/merge_requests/show.html.haml - ee/app/views/projects/pipelines/_tabs_content.html.haml - ee/app/views/projects/protected_branches/ee/_code_owner_approval_form.html.haml - ee/app/views/projects/protected_branches/ee/_code_owner_approval_table.html.haml @@ -148,28 +120,19 @@ Gitlab/FeatureAvailableUsage: - ee/app/views/projects/settings/ci_cd/_pipeline_subscriptions.html.haml - ee/app/views/projects/settings/operations/_status_page.html.haml - ee/app/views/projects/settings/repository/_protected_branches.html.haml - - ee/app/views/projects/sidebar/_repository_locked_files.html.haml - ee/app/views/shared/issuable/_group_bulk_update_sidebar.html.haml - ee/app/views/shared/issuable/form/_default_templates.html.haml - ee/app/views/shared/labels/_create_label_help_text.html.haml - ee/app/views/shared/promotions/_promote_mr_features.html.haml - - ee/app/views/shared/promotions/_promote_mr_features.html.haml - - ee/app/views/shared/promotions/_promote_repository_features.html.haml - - ee/app/views/shared/promotions/_promote_repository_features.html.haml - - ee/app/views/shared/promotions/_promote_repository_features.html.haml - - ee/app/views/shared/promotions/_promote_repository_features.html.haml - - ee/app/views/shared/promotions/_promote_repository_features.html.haml - ee/app/views/shared/promotions/_promote_repository_features.html.haml - ee/app/workers/analytics/code_review_metrics_worker.rb - ee/app/workers/group_saml_group_sync_worker.rb - - ee/lib/api/external_status_checks.rb - ee/lib/ee/api/entities/approval_state.rb - ee/lib/ee/api/entities/board.rb - ee/lib/ee/api/entities/issue.rb - ee/lib/ee/api/entities/project.rb - ee/lib/ee/api/helpers.rb - ee/lib/ee/api/internal/kubernetes.rb - - ee/lib/ee/api/job_artifacts.rb - ee/lib/ee/api/projects.rb - ee/lib/ee/gitlab/alert_management/payload/generic.rb - ee/lib/ee/gitlab/checks/diff_check.rb diff --git a/.rubocop_todo/gitlab/namespaced_class.yml b/.rubocop_todo/gitlab/namespaced_class.yml index 23ff86ba289..ac5edc05265 100644 --- a/.rubocop_todo/gitlab/namespaced_class.yml +++ b/.rubocop_todo/gitlab/namespaced_class.yml @@ -285,7 +285,6 @@ Gitlab/NamespacedClass: - 'app/models/project_snippet.rb' - 'app/models/project_statistics.rb' - 'app/models/project_team.rb' - - 'app/models/project_tracing_setting.rb' - 'app/models/project_wiki.rb' - 'app/models/prometheus_alert.rb' - 'app/models/prometheus_alert_event.rb' @@ -429,7 +428,6 @@ Gitlab/NamespacedClass: - 'app/presenters/group_clusterable_presenter.rb' - 'app/presenters/group_member_presenter.rb' - 'app/presenters/instance_clusterable_presenter.rb' - - 'app/presenters/invitation_presenter.rb' - 'app/presenters/issue_presenter.rb' - 'app/presenters/label_presenter.rb' - 'app/presenters/member_presenter.rb' @@ -767,7 +765,6 @@ Gitlab/NamespacedClass: - 'app/workers/emails_on_push_worker.rb' - 'app/workers/error_tracking_issue_link_worker.rb' - 'app/workers/expire_build_artifacts_worker.rb' - - 'app/workers/expire_job_cache_worker.rb' - 'app/workers/export_csv_worker.rb' - 'app/workers/external_service_reactive_caching_worker.rb' - 'app/workers/file_hook_worker.rb' @@ -783,8 +780,6 @@ Gitlab/NamespacedClass: - 'app/workers/invalid_gpg_signature_update_worker.rb' - 'app/workers/issuable_export_csv_worker.rb' - 'app/workers/issue_due_scheduler_worker.rb' - - 'app/workers/issue_placement_worker.rb' - - 'app/workers/issue_rebalancing_worker.rb' - 'app/workers/member_invitation_reminder_emails_worker.rb' - 'app/workers/merge_request_cleanup_refs_worker.rb' - 'app/workers/merge_request_mergeability_check_worker.rb' @@ -798,7 +793,6 @@ Gitlab/NamespacedClass: - 'app/workers/pages_domain_ssl_renewal_worker.rb' - 'app/workers/pages_domain_verification_cron_worker.rb' - 'app/workers/pages_domain_verification_worker.rb' - - 'app/workers/pages_transfer_worker.rb' - 'app/workers/pages_worker.rb' - 'app/workers/partition_creation_worker.rb' - 'app/workers/pipeline_hooks_worker.rb' @@ -829,7 +823,6 @@ Gitlab/NamespacedClass: - 'app/workers/repository_cleanup_worker.rb' - 'app/workers/repository_fork_worker.rb' - 'app/workers/repository_import_worker.rb' - - 'app/workers/repository_remove_remote_worker.rb' - 'app/workers/repository_update_remote_mirror_worker.rb' - 'app/workers/run_pipeline_schedule_worker.rb' - 'app/workers/schedule_merge_request_cleanup_refs_worker.rb' @@ -861,10 +854,9 @@ Gitlab/NamespacedClass: - 'ee/app/controllers/sitemap_controller.rb' - 'ee/app/controllers/smartcard_controller.rb' - 'ee/app/controllers/subscriptions_controller.rb' - - 'ee/app/controllers/survey_responses_controller.rb' - 'ee/app/controllers/trial_registrations_controller.rb' - 'ee/app/controllers/trials_controller.rb' - - 'ee/app/finders/audit_log_finder.rb' + - 'ee/app/finders/audit_event_finder.rb' - 'ee/app/finders/billed_users_finder.rb' - 'ee/app/finders/custom_project_templates_finder.rb' - 'ee/app/finders/dast_scanner_profiles_finder.rb' @@ -1013,7 +1005,6 @@ Gitlab/NamespacedClass: - 'ee/app/serializers/group_analytics_serializer.rb' - 'ee/app/serializers/group_vulnerability_autocomplete_entity.rb' - 'ee/app/serializers/group_vulnerability_autocomplete_serializer.rb' - - 'ee/app/serializers/invited_group_serializer.rb' - 'ee/app/serializers/iteration_serializer.rb' - 'ee/app/serializers/license_entity.rb' - 'ee/app/serializers/license_scanning_reports_serializer.rb' @@ -1052,7 +1043,6 @@ Gitlab/NamespacedClass: - 'ee/app/workers/admin_emails_worker.rb' - 'ee/app/workers/clear_shared_runners_minutes_worker.rb' - 'ee/app/workers/create_github_webhook_worker.rb' - - 'ee/app/workers/dast_site_validation_worker.rb' - 'ee/app/workers/elastic_association_indexer_worker.rb' - 'ee/app/workers/elastic_cluster_reindexing_cron_worker.rb' - 'ee/app/workers/elastic_commit_indexer_worker.rb' @@ -1094,7 +1084,6 @@ Gitlab/NamespacedClass: - 'ee/lib/gitlab/group_plans_preloader.rb' - 'ee/lib/gitlab/ip_address_state.rb' - 'ee/lib/gitlab/items_collection.rb' - - 'ee/lib/gitlab/manual_banner.rb' - 'ee/lib/gitlab/manual_quarterly_co_term_banner.rb' - 'ee/lib/gitlab/pagination_delegate.rb' - 'ee/lib/gitlab/path_locks_finder.rb' @@ -1106,11 +1095,6 @@ Gitlab/NamespacedClass: - 'lib/carrier_wave_string_file.rb' - 'lib/csv_builder.rb' - 'lib/event_filter.rb' - - 'lib/feature.rb' - - 'lib/feature/definition.rb' - - 'lib/feature/gitaly.rb' - - 'lib/feature/logger.rb' - - 'lib/feature/shared.rb' - 'lib/file_size_validator.rb' - 'lib/forever.rb' - 'lib/generators/gitlab/snowplow_event_definition_generator.rb' diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml index e889a05ad36..1977bedd143 100644 --- a/.rubocop_todo/layout/argument_alignment.yml +++ b/.rubocop_todo/layout/argument_alignment.yml @@ -397,7 +397,6 @@ Layout/ArgumentAlignment: - 'ee/spec/graphql/mutations/requirements_management/export_requirements_spec.rb' - 'ee/spec/helpers/billing_plans_helper_spec.rb' - 'ee/spec/helpers/ee/users/callouts_helper_spec.rb' - - 'ee/spec/helpers/projects/security/policies_helper_spec.rb' - 'ee/spec/helpers/routing/pseudonymization_helper_spec.rb' - 'ee/spec/helpers/trial_status_widget_helper_spec.rb' - 'ee/spec/lib/analytics/group_activity_calculator_spec.rb' @@ -475,10 +474,8 @@ Layout/ArgumentAlignment: - 'ee/spec/services/epics/update_service_spec.rb' - 'ee/spec/services/geo/file_registry_removal_service_spec.rb' - 'ee/spec/services/geo/repository_verification_primary_service_spec.rb' - - 'ee/spec/services/groups/recent_merge_requests_count_service_spec.rb' - 'ee/spec/services/merge_requests/reset_approvals_service_spec.rb' - 'ee/spec/services/merge_trains/create_pipeline_service_spec.rb' - - 'ee/spec/services/namespaces/check_storage_size_service_spec.rb' - 'ee/spec/services/projects/mark_for_deletion_service_spec.rb' - 'ee/spec/services/projects/restore_service_spec.rb' - 'ee/spec/services/security/merge_reports_service_spec.rb' @@ -536,7 +533,6 @@ Layout/ArgumentAlignment: - 'lib/gitlab/background_migration/backfill_project_repositories.rb' - 'lib/gitlab/background_migration/batching_strategies/base_strategy.rb' - 'lib/gitlab/background_migration/legacy_upload_mover.rb' - - 'lib/gitlab/background_migration/migrate_stage_status.rb' - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/ci/config/entry/artifacts.rb' - 'lib/gitlab/ci/config/entry/bridge.rb' @@ -570,7 +566,6 @@ Layout/ArgumentAlignment: - 'lib/gitlab/database_importers/instance_administrators/create_group.rb' - 'lib/gitlab/database_importers/self_monitoring/project/create_service.rb' - 'lib/gitlab/database_importers/self_monitoring/project/delete_service.rb' - - 'lib/gitlab/diff/custom_diff.rb' - 'lib/gitlab/diff/file.rb' - 'lib/gitlab/diff/file_collection/base.rb' - 'lib/gitlab/diff/suggestion.rb' @@ -633,7 +628,6 @@ Layout/ArgumentAlignment: - 'spec/controllers/projects/pipeline_schedules_controller_spec.rb' - 'spec/controllers/projects/pipelines/tests_controller_spec.rb' - 'spec/controllers/projects/pipelines_controller_spec.rb' - - 'spec/controllers/projects/serverless/functions_controller_spec.rb' - 'spec/controllers/projects/settings/operations_controller_spec.rb' - 'spec/controllers/projects/tags_controller_spec.rb' - 'spec/controllers/projects/todos_controller_spec.rb' @@ -674,9 +668,6 @@ Layout/ArgumentAlignment: - 'spec/features/projects/milestones/milestones_sorting_spec.rb' - 'spec/features/projects/pipelines/pipeline_spec.rb' - 'spec/features/projects/pipelines/pipelines_spec.rb' - - 'spec/features/projects/serverless/functions_spec.rb' - - 'spec/features/refactor_blob_viewer_disabled/projects/files/editing_a_file_spec.rb' - - 'spec/features/refactor_blob_viewer_disabled/projects/files/project_owner_creates_license_file_spec.rb' - 'spec/finders/ci/commit_statuses_finder_spec.rb' - 'spec/finders/ci/pipelines_for_merge_request_finder_spec.rb' - 'spec/finders/clusters/knative_services_finder_spec.rb' @@ -897,7 +888,6 @@ Layout/ArgumentAlignment: - 'spec/services/namespaces/package_settings/update_service_spec.rb' - 'spec/services/notification_service_spec.rb' - 'spec/services/packages/debian/extract_metadata_service_spec.rb' - - 'spec/services/pod_logs/kubernetes_service_spec.rb' - 'spec/services/projects/destroy_service_spec.rb' - 'spec/services/security/merge_reports_service_spec.rb' - 'spec/services/system_notes/design_management_service_spec.rb' @@ -940,8 +930,6 @@ Layout/ArgumentAlignment: - 'spec/views/projects/merge_requests/_commits.html.haml_spec.rb' - 'spec/views/projects/merge_requests/edit.html.haml_spec.rb' - 'spec/views/projects/tags/index.html.haml_spec.rb' - - 'spec/workers/expire_job_cache_worker_spec.rb' - - 'spec/workers/expire_pipeline_cache_worker_spec.rb' - 'spec/workers/pipeline_notification_worker_spec.rb' - 'spec/workers/remove_unreferenced_lfs_objects_worker_spec.rb' - 'spec/workers/update_external_pull_requests_worker_spec.rb' diff --git a/.rubocop_todo/layout/first_array_element_indentation.yml b/.rubocop_todo/layout/first_array_element_indentation.yml index d613d083f9f..e3bbf9dc25a 100644 --- a/.rubocop_todo/layout/first_array_element_indentation.yml +++ b/.rubocop_todo/layout/first_array_element_indentation.yml @@ -51,7 +51,6 @@ Layout/FirstArrayElementIndentation: - 'ee/app/models/ee/user.rb' - 'ee/app/models/protected_environment.rb' - 'ee/app/serializers/dashboard_environments_serializer.rb' - - 'ee/app/serializers/merge_request_compliance_entity.rb' - 'ee/app/services/app_sec/dast/profiles/update_service.rb' - 'ee/app/services/vulnerabilities/create_service_base.rb' - 'ee/lib/ee/api/helpers/award_emoji.rb' @@ -90,7 +89,7 @@ Layout/FirstArrayElementIndentation: - 'ee/spec/lib/gitlab/ci/templates/Jobs/load_performance_testing_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/yaml_processor_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/epics/epic_node_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_block_aggregate_spec.rb' + - 'ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_links_aggregate_spec.rb' - 'ee/spec/lib/gitlab/graphql/loaders/bulk_epic_aggregate_loader_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_ci_builds_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_users_creating_ci_builds_metric_spec.rb' @@ -147,7 +146,6 @@ Layout/FirstArrayElementIndentation: - 'lib/gitlab/email/message/in_product_marketing/verify.rb' - 'lib/gitlab/import_export/base/relation_factory.rb' - 'lib/gitlab/import_export/json/streaming_serializer.rb' - - 'lib/gitlab/integrations/sti_type.rb' - 'lib/gitlab/kroki.rb' - 'lib/gitlab/object_hierarchy.rb' - 'lib/gitlab/pagination/keyset/simple_order_builder.rb' @@ -190,7 +188,6 @@ Layout/FirstArrayElementIndentation: - 'spec/controllers/projects/pipelines/tests_controller_spec.rb' - 'spec/controllers/projects/pipelines_controller_spec.rb' - 'spec/deprecation_toolkit_env.rb' - - 'spec/experiments/new_project_sast_enabled_experiment_spec.rb' - 'spec/features/clusters/create_agent_spec.rb' - 'spec/features/issues/filtered_search/filter_issues_spec.rb' - 'spec/features/issues/filtered_search/visual_tokens_spec.rb' @@ -243,7 +240,6 @@ Layout/FirstArrayElementIndentation: - 'spec/lib/gitlab/database/similarity_score_spec.rb' - 'spec/lib/gitlab/diff/char_diff_spec.rb' - 'spec/lib/gitlab/diff/file_collection_sorter_spec.rb' - - 'spec/lib/gitlab/elasticsearch/logs/pods_spec.rb' - 'spec/lib/gitlab/error_tracking/stack_trace_highlight_decorator_spec.rb' - 'spec/lib/gitlab/gitaly_client/blob_service_spec.rb' - 'spec/lib/gitlab/github_import/parallel_scheduling_spec.rb' @@ -285,7 +281,6 @@ Layout/FirstArrayElementIndentation: - 'spec/models/ci/pipeline_spec.rb' - 'spec/models/ci/unit_test_spec.rb' - 'spec/models/clusters/applications/cert_manager_spec.rb' - - 'spec/models/clusters/applications/elastic_stack_spec.rb' - 'spec/models/clusters/platforms/kubernetes_spec.rb' - 'spec/models/commit_collection_spec.rb' - 'spec/models/compare_spec.rb' diff --git a/.rubocop_todo/layout/first_hash_element_indentation.yml b/.rubocop_todo/layout/first_hash_element_indentation.yml index 6000d3ea1af..22d66dcb8c1 100644 --- a/.rubocop_todo/layout/first_hash_element_indentation.yml +++ b/.rubocop_todo/layout/first_hash_element_indentation.yml @@ -84,7 +84,6 @@ Layout/FirstHashElementIndentation: - 'ee/app/helpers/ee/ci/jobs_helper.rb' - 'ee/app/helpers/ee/geo_helper.rb' - 'ee/app/helpers/ee/groups/group_members_helper.rb' - - 'ee/app/helpers/ee/ide_helper.rb' - 'ee/app/helpers/ee/projects_helper.rb' - 'ee/app/helpers/ee/sidebars_helper.rb' - 'ee/app/helpers/ee/tree_helper.rb' @@ -149,8 +148,6 @@ Layout/FirstHashElementIndentation: - 'ee/spec/helpers/ee/projects/security/sast_configuration_helper_spec.rb' - 'ee/spec/helpers/groups/sso_helper_spec.rb' - 'ee/spec/helpers/nav/new_dropdown_helper_spec.rb' - - 'ee/spec/helpers/projects/security/policies_helper_spec.rb' - - 'ee/spec/helpers/projects/threat_monitoring_helper_spec.rb' - 'ee/spec/helpers/projects_helper_spec.rb' - 'ee/spec/helpers/routing/pseudonymization_helper_spec.rb' - 'ee/spec/helpers/search_helper_spec.rb' @@ -267,8 +264,6 @@ Layout/FirstHashElementIndentation: - 'lib/gitlab/github_import/importer/diff_note_importer.rb' - 'lib/gitlab/github_import/importer/pull_request_merged_by_importer.rb' - 'lib/gitlab/gitlab_import/client.rb' - - 'lib/gitlab/graphql/query_analyzers/logger_analyzer.rb' - - 'lib/gitlab/graphql/query_analyzers/recursion_analyzer.rb' - 'lib/gitlab/hook_data/issue_builder.rb' - 'lib/gitlab/hook_data/release_builder.rb' - 'lib/gitlab/kubernetes.rb' @@ -410,7 +405,6 @@ Layout/FirstHashElementIndentation: - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/populate_spec.rb' - 'spec/lib/gitlab/ci/pipeline/seed/build/cache_spec.rb' - - 'spec/lib/gitlab/ci/reports/coverage_reports_spec.rb' - 'spec/lib/gitlab/ci/reports/security/identifier_spec.rb' - 'spec/lib/gitlab/ci/reports/security/scanner_spec.rb' - 'spec/lib/gitlab/ci/reports/terraform_reports_spec.rb' @@ -434,10 +428,8 @@ Layout/FirstHashElementIndentation: - 'spec/lib/gitlab/github_import/logger_spec.rb' - 'spec/lib/gitlab/github_import/object_counter_spec.rb' - 'spec/lib/gitlab/gpg_spec.rb' - - 'spec/lib/gitlab/graphql/query_analyzers/logger_analyzer_spec.rb' - 'spec/lib/gitlab/graphql/tracers/logger_tracer_spec.rb' - 'spec/lib/gitlab/graphql/tracers/timer_tracer_spec.rb' - - 'spec/lib/gitlab/hook_data/issuable_builder_spec.rb' - 'spec/lib/gitlab/http_spec.rb' - 'spec/lib/gitlab/i18n_spec.rb' - 'spec/lib/gitlab/import/logger_spec.rb' @@ -531,9 +523,6 @@ Layout/FirstHashElementIndentation: - 'spec/services/metrics/dashboard/transient_embed_service_spec.rb' - 'spec/services/notes/render_service_spec.rb' - 'spec/services/packages/debian/parse_debian822_service_spec.rb' - - 'spec/services/pod_logs/base_service_spec.rb' - - 'spec/services/pod_logs/elasticsearch_service_spec.rb' - - 'spec/services/pod_logs/kubernetes_service_spec.rb' - 'spec/services/projects/container_repository/delete_tags_service_spec.rb' - 'spec/services/projects/create_from_template_service_spec.rb' - 'spec/services/projects/lfs_pointers/lfs_download_service_spec.rb' @@ -555,7 +544,6 @@ Layout/FirstHashElementIndentation: - 'spec/support/shared_examples/metrics/active_record_subscriber_shared_examples.rb' - 'spec/support/shared_examples/models/clusters/prometheus_client_shared.rb' - 'spec/support/shared_examples/models/cycle_analytics_stage_shared_examples.rb' - - 'spec/support/shared_examples/models/issuable_hook_data_shared_examples.rb' - 'spec/support/shared_examples/requests/rack_attack_shared_examples.rb' - 'spec/support_specs/graphql/arguments_spec.rb' - 'spec/support_specs/graphql/field_selection_spec.rb' diff --git a/.rubocop_todo/layout/hash_alignment.yml b/.rubocop_todo/layout/hash_alignment.yml index 2125c032437..d6772537f47 100644 --- a/.rubocop_todo/layout/hash_alignment.yml +++ b/.rubocop_todo/layout/hash_alignment.yml @@ -356,7 +356,6 @@ Layout/HashAlignment: - 'ee/app/services/epics/issue_promote_service.rb' - 'ee/app/services/external_status_checks/create_service.rb' - 'ee/app/services/groups/memberships/export_service.rb' - - 'ee/app/services/namespaces/check_excess_storage_size_service.rb' - 'ee/app/services/projects/setup_ci_cd.rb' - 'ee/app/services/security/security_orchestration_policies/on_demand_scan_pipeline_configuration_service.rb' - 'ee/config/routes/project.rb' @@ -382,7 +381,6 @@ Layout/HashAlignment: - 'ee/lib/gitlab/ci/parsers/security/formatters/dependency_list.rb' - 'ee/lib/gitlab/elastic/helper.rb' - 'ee/lib/gitlab/elastic/indexer.rb' - - 'ee/lib/gitlab/geo/replication/base_transfer.rb' - 'ee/spec/controllers/ee/projects/variables_controller_spec.rb' - 'ee/spec/controllers/groups/epic_boards_controller_spec.rb' - 'ee/spec/controllers/groups/issues_controller_spec.rb' @@ -610,7 +608,6 @@ Layout/HashAlignment: - 'spec/lib/gitlab/etag_caching/router/graphql_spec.rb' - 'spec/lib/gitlab/git/repository_spec.rb' - 'spec/lib/gitlab/grape_logging/formatters/lograge_with_timestamp_spec.rb' - - 'spec/lib/gitlab/hook_data/issuable_builder_spec.rb' - 'spec/lib/gitlab/import_export/attributes_finder_spec.rb' - 'spec/lib/gitlab/import_export/group/object_builder_spec.rb' - 'spec/lib/gitlab/import_export/group/relation_tree_restorer_spec.rb' @@ -688,7 +685,6 @@ Layout/HashAlignment: - 'spec/services/ci/create_pipeline_service/logger_spec.rb' - 'spec/services/ci/create_pipeline_service/tags_spec.rb' - 'spec/services/ci/job_artifacts/create_service_spec.rb' - - 'spec/services/ci/retry_build_service_spec.rb' - 'spec/services/deployments/link_merge_requests_service_spec.rb' - 'spec/services/discussions/capture_diff_note_positions_service_spec.rb' - 'spec/services/groups/import_export/import_service_spec.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 6315f5dd28b..7d2674c34f8 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -88,7 +88,6 @@ Layout/LineLength: - 'app/controllers/projects/issues_controller.rb' - 'app/controllers/projects/jobs_controller.rb' - 'app/controllers/projects/labels_controller.rb' - - 'app/controllers/projects/logs_controller.rb' - 'app/controllers/projects/merge_requests/conflicts_controller.rb' - 'app/controllers/projects/merge_requests/creations_controller.rb' - 'app/controllers/projects/merge_requests/diffs_controller.rb' @@ -341,7 +340,6 @@ Layout/LineLength: - 'app/models/ci/unit_test.rb' - 'app/models/clusters/agent.rb' - 'app/models/clusters/applications/cert_manager.rb' - - 'app/models/clusters/applications/elastic_stack.rb' - 'app/models/clusters/applications/knative.rb' - 'app/models/clusters/applications/prometheus.rb' - 'app/models/clusters/cluster.rb' @@ -566,7 +564,6 @@ Layout/LineLength: - 'app/services/ci/pipeline_artifacts/create_code_quality_mr_diff_report_service.rb' - 'app/services/ci/pipelines/add_job_service.rb' - 'app/services/ci/prometheus_metrics/observe_histograms_service.rb' - - 'app/services/ci/queue/builds_table_strategy.rb' - 'app/services/ci/queue/pending_builds_strategy.rb' - 'app/services/ci/runners/register_runner_service.rb' - 'app/services/ci/runners/unregister_runner_service.rb' @@ -619,7 +616,6 @@ Layout/LineLength: - 'app/services/import/bitbucket_server_service.rb' - 'app/services/import/github_service.rb' - 'app/services/import/validate_remote_git_endpoint_service.rb' - - 'app/services/issuable/clone/attributes_rewriter.rb' - 'app/services/issuable/import_csv/base_service.rb' - 'app/services/issuable/process_assignees.rb' - 'app/services/issuable_base_service.rb' @@ -696,8 +692,6 @@ Layout/LineLength: - 'app/services/pages/migrate_legacy_storage_to_deployment_service.rb' - 'app/services/personal_access_tokens/create_service.rb' - 'app/services/personal_access_tokens/revoke_service.rb' - - 'app/services/pod_logs/elasticsearch_service.rb' - - 'app/services/pod_logs/kubernetes_service.rb' - 'app/services/projects/branches_by_mode_service.rb' - 'app/services/projects/container_repository/cleanup_tags_service.rb' - 'app/services/projects/container_repository/gitlab/delete_tags_service.rb' @@ -733,7 +727,6 @@ Layout/LineLength: - 'app/services/security/ci_configuration/sast_iac_create_service.rb' - 'app/services/security/ci_configuration/sast_parser_service.rb' - 'app/services/security/ci_configuration/secret_detection_create_service.rb' - - 'app/services/service_ping/devops_report_service.rb' - 'app/services/service_ping/submit_service.rb' - 'app/services/snippets/count_service.rb' - 'app/services/snippets/create_service.rb' @@ -782,7 +775,6 @@ Layout/LineLength: - 'app/workers/gitlab/jira_import/stage/import_notes_worker.rb' - 'app/workers/integrations/create_external_cross_reference_worker.rb' - 'app/workers/issuable_export_csv_worker.rb' - - 'app/workers/issue_rebalancing_worker.rb' - 'app/workers/issues/rebalancing_worker.rb' - 'app/workers/jira_connect/sync_branch_worker.rb' - 'app/workers/jira_connect/sync_merge_request_worker.rb' @@ -984,7 +976,6 @@ Layout/LineLength: - 'db/migrate/20220215164709_update_application_settings_container_registry_exp_pol_worker_capacity_default.rb' - 'db/migrate/20220216110023_create_saved_replies.rb' - 'db/migrate/20220217100008_add_container_registry_expiration_policies_caching_to_application_settings.rb' - - 'db/migrate/20220221102333_change_maintenance_note_limit_in_ci_runner.rb db/migrate/20220221102333_change_maintainer_note_limit_in_ci_runner.rb' - 'db/migrate/20220222072536_add_target_access_levels_to_broadcast_messages.rb' - 'db/migrate/20220301003502_add_security_orchestration_policy_configuration_namespace_index.rb' - 'db/migrate/20220301175104_change_security_orchestration_policy_configuration_project_index.rb' @@ -1127,7 +1118,7 @@ Layout/LineLength: - 'ee/app/controllers/admin/geo/application_controller.rb' - 'ee/app/controllers/admin/geo/projects_controller.rb' - 'ee/app/controllers/admin/licenses_controller.rb' - - 'ee/app/controllers/concerns/audit_events/audit_logs_params.rb' + - 'ee/app/controllers/concerns/audit_events/audit_events_params.rb' - 'ee/app/controllers/concerns/audit_events/date_range.rb' - 'ee/app/controllers/concerns/credentials_inventory_actions.rb' - 'ee/app/controllers/concerns/ee/issuable_collections.rb' @@ -1319,7 +1310,6 @@ Layout/LineLength: - 'ee/app/helpers/projects/security/dast_profiles_helper.rb' - 'ee/app/helpers/projects/security/discover_helper.rb' - 'ee/app/helpers/push_rules_helper.rb' - - 'ee/app/helpers/seats_count_alert_helper.rb' - 'ee/app/helpers/security_helper.rb' - 'ee/app/helpers/trial_status_widget_helper.rb' - 'ee/app/helpers/vulnerabilities_helper.rb' @@ -1394,7 +1384,6 @@ Layout/LineLength: - 'ee/app/models/gitlab_subscriptions/features.rb' - 'ee/app/models/incident_management/escalation_policy.rb' - 'ee/app/models/incident_management/oncall_rotation.rb' - - 'ee/app/models/incident_management/timeline_event.rb' - 'ee/app/models/integrations/github.rb' - 'ee/app/models/issuable_sla.rb' - 'ee/app/models/iterations/cadence.rb' @@ -1428,7 +1417,6 @@ Layout/LineLength: - 'ee/app/policies/ee/identity_provider_policy.rb' - 'ee/app/policies/ee/project_policy.rb' - 'ee/app/presenters/dast/site_profile_presenter.rb' - - 'ee/app/presenters/ee/commit_status_presenter.rb' - 'ee/app/presenters/ee/merge_request_presenter.rb' - 'ee/app/serializers/dashboard_environment_entity.rb' - 'ee/app/serializers/ee/environment_entity.rb' @@ -1438,7 +1426,6 @@ Layout/LineLength: - 'ee/app/serializers/ee/note_user_entity.rb' - 'ee/app/serializers/ee/user_entity.rb' - 'ee/app/serializers/vulnerabilities/feedback_entity.rb' - - 'ee/app/services/alert_management/metric_images/upload_service.rb' - 'ee/app/services/analytics/cycle_analytics/consistency_check_service.rb' - 'ee/app/services/analytics/cycle_analytics/value_streams/create_service.rb' - 'ee/app/services/analytics/devops_adoption/enabled_namespaces/find_or_create_service.rb' @@ -1517,7 +1504,6 @@ Layout/LineLength: - 'ee/app/services/ee/users/update_service.rb' - 'ee/app/services/elastic/cluster_reindexing_service.rb' - 'ee/app/services/elastic/indexing_control_service.rb' - - 'ee/app/services/epic_links/list_service.rb' - 'ee/app/services/epics/issue_promote_service.rb' - 'ee/app/services/epics/update_service.rb' - 'ee/app/services/external_status_checks/create_service.rb' @@ -1557,8 +1543,6 @@ Layout/LineLength: - 'ee/app/services/merge_requests/create_from_vulnerability_data_service.rb' - 'ee/app/services/merge_trains/create_pipeline_service.rb' - 'ee/app/services/merge_trains/refresh_merge_request_service.rb' - - 'ee/app/services/namespaces/check_excess_storage_size_service.rb' - - 'ee/app/services/namespaces/check_storage_size_service.rb' - 'ee/app/services/personal_access_tokens/rotation_verifier_service.rb' - 'ee/app/services/projects/licenses/create_policy_service.rb' - 'ee/app/services/projects/mark_for_deletion_service.rb' @@ -1567,7 +1551,6 @@ Layout/LineLength: - 'ee/app/services/resource_events/change_weight_service.rb' - 'ee/app/services/security/auto_fix_service.rb' - 'ee/app/services/security/dependency_list_service.rb' - - 'ee/app/services/security/ingestion/bulk_updatable_task.rb' - 'ee/app/services/security/ingestion/finding_map.rb' - 'ee/app/services/security/ingestion/tasks/ingest_remediations.rb' - 'ee/app/services/security/ingestion/tasks/ingest_vulnerabilities/create.rb' @@ -1661,7 +1644,6 @@ Layout/LineLength: - 'ee/elastic/migrate/20210510143200_delete_notes_from_original_index.rb' - 'ee/lib/analytics/devops_adoption/snapshot_calculator.rb' - 'ee/lib/analytics/productivity_analytics_request_params.rb' - - 'ee/lib/api/alert_management_alerts.rb' - 'ee/lib/api/analytics/code_review_analytics.rb' - 'ee/lib/api/audit_events.rb' - 'ee/lib/api/ci/minutes.rb' @@ -1810,7 +1792,6 @@ Layout/LineLength: - 'ee/lib/gitlab/geo/jwt_request_decoder.rb' - 'ee/lib/gitlab/geo/log_cursor/events/repository_created_event.rb' - 'ee/lib/gitlab/geo/registry_batcher.rb' - - 'ee/lib/gitlab/geo/replication/base_transfer.rb' - 'ee/lib/gitlab/geo/replication/blob_downloader.rb' - 'ee/lib/gitlab/geo/replicator.rb' - 'ee/lib/gitlab/graphql/aggregations/epics/epic_node.rb' @@ -1832,7 +1813,6 @@ Layout/LineLength: - 'ee/lib/gitlab/usage/metrics/instrumentations/count_users_creating_ci_builds_metric.rb' - 'ee/lib/gitlab/usage/metrics/instrumentations/license_metric.rb' - 'ee/lib/gitlab/usage_data_counters/license_testing_counter.rb' - - 'ee/lib/system_check/app/elasticsearch_check.rb' - 'ee/lib/system_check/geo/authorized_keys_check.rb' - 'ee/lib/system_check/geo/current_node_check.rb' - 'ee/lib/system_check/geo/geo_database_configured_check.rb' @@ -1861,7 +1841,6 @@ Layout/LineLength: - 'ee/spec/controllers/groups/analytics/tasks_by_type_controller_spec.rb' - 'ee/spec/controllers/groups/audit_events_controller_spec.rb' - 'ee/spec/controllers/groups/epic_issues_controller_spec.rb' - - 'ee/spec/controllers/groups/epic_links_controller_spec.rb' - 'ee/spec/controllers/groups/epics_controller_spec.rb' - 'ee/spec/controllers/groups/group_members_controller_spec.rb' - 'ee/spec/controllers/groups/groups_controller_spec.rb' @@ -1889,7 +1868,6 @@ Layout/LineLength: - 'ee/spec/controllers/projects/security/configuration_controller_spec.rb' - 'ee/spec/controllers/projects/security/vulnerabilities_controller_spec.rb' - 'ee/spec/controllers/projects/subscriptions_controller_spec.rb' - - 'ee/spec/controllers/projects/threat_monitoring_controller_spec.rb' - 'ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb' - 'ee/spec/controllers/projects_controller_spec.rb' - 'ee/spec/controllers/registrations/groups_controller_spec.rb' @@ -1924,7 +1902,6 @@ Layout/LineLength: - 'ee/spec/features/admin/geo/admin_geo_nodes_spec.rb' - 'ee/spec/features/admin/groups/admin_changes_plan_spec.rb' - 'ee/spec/features/admin/groups/admin_subscription_alerts_spec.rb' - - 'ee/spec/features/admin/licenses/admin_uploads_license_spec.rb' - 'ee/spec/features/admin/subscriptions/admin_views_subscription_spec.rb' - 'ee/spec/features/billings/billing_plans_spec.rb' - 'ee/spec/features/billings/extend_reactivate_trial_spec.rb' @@ -1942,7 +1919,6 @@ Layout/LineLength: - 'ee/spec/features/epics/epics_list_spec.rb' - 'ee/spec/features/epics/issue_promotion_spec.rb' - 'ee/spec/features/geo_node_spec.rb' - - 'ee/spec/features/gitlab_subscriptions/seats_count_alert_spec.rb' - 'ee/spec/features/google_analytics_datalayer_spec.rb' - 'ee/spec/features/groups/analytics/cycle_analytics/charts_spec.rb' - 'ee/spec/features/groups/analytics/cycle_analytics/filters_and_data_spec.rb' @@ -1967,7 +1943,6 @@ Layout/LineLength: - 'ee/spec/features/groups/security/compliance_dashboards_spec.rb' - 'ee/spec/features/groups/sso_spec.rb' - 'ee/spec/features/groups/usage_quotas_spec.rb' - - 'ee/spec/features/incidents/incident_details_spec.rb' - 'ee/spec/features/integrations/jira/jira_issues_list_spec.rb' - 'ee/spec/features/invites_spec.rb' - 'ee/spec/features/issues/filtered_search/filter_issues_weight_spec.rb' @@ -2022,7 +1997,7 @@ Layout/LineLength: - 'ee/spec/features/users/login_spec.rb' - 'ee/spec/finders/analytics/devops_adoption/enabled_namespaces_finder_spec.rb' - 'ee/spec/finders/analytics/devops_adoption/snapshots_finder_spec.rb' - - 'ee/spec/finders/audit_log_finder_spec.rb' + - 'ee/spec/finders/audit_event_finder_spec.rb' - 'ee/spec/finders/billed_users_finder_spec.rb' - 'ee/spec/finders/boards/users_finder_spec.rb' - 'ee/spec/finders/compliance_management/merge_requests/compliance_violations_finder_spec.rb' @@ -2033,7 +2008,6 @@ Layout/LineLength: - 'ee/spec/finders/ee/projects_finder_spec.rb' - 'ee/spec/finders/epics_finder_spec.rb' - 'ee/spec/finders/geo/container_repository_registry_finder_spec.rb' - - 'ee/spec/finders/geo/job_artifact_legacy_registry_finder_spec.rb' - 'ee/spec/finders/geo/project_registry_finder_spec.rb' - 'ee/spec/finders/geo/project_registry_status_finder_spec.rb' - 'ee/spec/finders/group_projects_finder_spec.rb' @@ -2042,7 +2016,6 @@ Layout/LineLength: - 'ee/spec/finders/incident_management/member_oncall_rotations_finder_spec.rb' - 'ee/spec/finders/incident_management/oncall_rotations_finder_spec.rb' - 'ee/spec/finders/incident_management/oncall_users_finder_spec.rb' - - 'ee/spec/finders/incident_management/timeline_events_finder_spec.rb' - 'ee/spec/finders/issues_finder_spec.rb' - 'ee/spec/finders/iterations/cadences_finder_spec.rb' - 'ee/spec/finders/iterations_finder_spec.rb' @@ -2093,7 +2066,6 @@ Layout/LineLength: - 'ee/spec/graphql/mutations/incident_management/oncall_rotation/update_spec.rb' - 'ee/spec/graphql/mutations/incident_management/oncall_schedule/create_spec.rb' - 'ee/spec/graphql/mutations/incident_management/oncall_schedule/update_spec.rb' - - 'ee/spec/graphql/mutations/incident_management/timeline_event/update_spec.rb' - 'ee/spec/graphql/mutations/instance_security_dashboard/add_project_spec.rb' - 'ee/spec/graphql/mutations/instance_security_dashboard/remove_project_spec.rb' - 'ee/spec/graphql/mutations/issues/create_spec.rb' @@ -2119,7 +2091,6 @@ Layout/LineLength: - 'ee/spec/graphql/resolvers/incident_management/escalation_policies_resolver_spec.rb' - 'ee/spec/graphql/resolvers/incident_management/oncall_rotations_resolver_spec.rb' - 'ee/spec/graphql/resolvers/incident_management/oncall_schedule_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/incident_management/timeline_events_resolver_spec.rb' - 'ee/spec/graphql/resolvers/iterations/cadences_resolver_spec.rb' - 'ee/spec/graphql/resolvers/iterations_resolver_spec.rb' - 'ee/spec/graphql/resolvers/network_policy_resolver_spec.rb' @@ -2203,7 +2174,6 @@ Layout/LineLength: - 'ee/spec/helpers/push_rules_helper_spec.rb' - 'ee/spec/helpers/routing/pseudonymization_helper_spec.rb' - 'ee/spec/helpers/search_helper_spec.rb' - - 'ee/spec/helpers/seats_count_alert_helper_spec.rb' - 'ee/spec/helpers/security_helper_spec.rb' - 'ee/spec/helpers/subscriptions_helper_spec.rb' - 'ee/spec/helpers/timeboxes_helper_spec.rb' @@ -2349,18 +2319,12 @@ Layout/LineLength: - 'ee/spec/lib/gitlab/geo/geo_tasks_spec.rb' - 'ee/spec/lib/gitlab/geo/git_ssh_proxy_spec.rb' - 'ee/spec/lib/gitlab/geo/health_check_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/job_artifact_deleted_event_spec.rb' - 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_created_event_spec.rb' - 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_updated_event_spec.rb' - 'ee/spec/lib/gitlab/geo/log_cursor/lease_spec.rb' - 'ee/spec/lib/gitlab/geo/oauth/login_state_spec.rb' - 'ee/spec/lib/gitlab/geo/oauth/logout_token_spec.rb' - 'ee/spec/lib/gitlab/geo/replication/blob_downloader_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/file_retriever_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/file_transfer_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/job_artifact_downloader_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/job_artifact_retriever_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/job_artifact_transfer_spec.rb' - 'ee/spec/lib/gitlab/geo_spec.rb' - 'ee/spec/lib/gitlab/git_access_spec.rb' - 'ee/spec/lib/gitlab/git_access_wiki_spec.rb' @@ -2408,7 +2372,6 @@ Layout/LineLength: - 'ee/spec/lib/omni_auth/strategies/group_saml_spec.rb' - 'ee/spec/lib/peek/views/elasticsearch_spec.rb' - 'ee/spec/lib/sidebars/groups/menus/security_compliance_menu_spec.rb' - - 'ee/spec/lib/system_check/app/elasticsearch_check_spec.rb' - 'ee/spec/lib/system_check/geo/authorized_keys_check_spec.rb' - 'ee/spec/lib/system_check/geo/http_connection_check_spec.rb' - 'ee/spec/mailers/ee/emails/issues_spec.rb' @@ -2447,7 +2410,6 @@ Layout/LineLength: - 'ee/spec/models/ci/daily_build_group_report_result_spec.rb' - 'ee/spec/models/ci/minutes/namespace_monthly_usage_spec.rb' - 'ee/spec/models/ci/minutes/project_monthly_usage_spec.rb' - - 'ee/spec/models/ci/minutes/quota_spec.rb' - 'ee/spec/models/ci/pipeline_spec.rb' - 'ee/spec/models/ci/subscriptions/project_spec.rb' - 'ee/spec/models/concerns/ee/clusters/agents/authorization_config_scopes_spec.rb' @@ -2523,7 +2485,6 @@ Layout/LineLength: - 'ee/spec/models/incident_management/issuable_escalation_status_spec.rb' - 'ee/spec/models/incident_management/oncall_rotation_spec.rb' - 'ee/spec/models/incident_management/oncall_shift_spec.rb' - - 'ee/spec/models/incident_management/timeline_event_spec.rb' - 'ee/spec/models/instance_security_dashboard_spec.rb' - 'ee/spec/models/integrations/chat_message/vulnerability_message_spec.rb' - 'ee/spec/models/integrations/github_spec.rb' @@ -2591,7 +2552,6 @@ Layout/LineLength: - 'ee/spec/requests/admin/credentials_controller_spec.rb' - 'ee/spec/requests/admin/geo/replicables_controller_spec.rb' - 'ee/spec/requests/admin/user_permission_exports_controller_spec.rb' - - 'ee/spec/requests/api/alert_management_alerts_spec.rb' - 'ee/spec/requests/api/analytics/code_review_analytics_spec.rb' - 'ee/spec/requests/api/audit_events_spec.rb' - 'ee/spec/requests/api/branches_spec.rb' @@ -2643,7 +2603,6 @@ Layout/LineLength: - 'ee/spec/requests/api/graphql/mutations/environments/canary_ingress/update_spec.rb' - 'ee/spec/requests/api/graphql/mutations/epic_tree/reorder_spec.rb' - 'ee/spec/requests/api/graphql/mutations/epics/add_issue_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/incident_management/timeline_event/update_spec.rb' - 'ee/spec/requests/api/graphql/mutations/issues/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/issues/set_weight_spec.rb' - 'ee/spec/requests/api/graphql/mutations/iterations/cadences/create_spec.rb' @@ -2667,7 +2626,6 @@ Layout/LineLength: - 'ee/spec/requests/api/graphql/project/incident_management/escalation_policies_spec.rb' - 'ee/spec/requests/api/graphql/project/incident_management/escalation_policy/rules_spec.rb' - 'ee/spec/requests/api/graphql/project/incident_management/oncall_shifts_spec.rb' - - 'ee/spec/requests/api/graphql/project/incident_management/timeline_events_spec.rb' - 'ee/spec/requests/api/graphql/project/issues_spec.rb' - 'ee/spec/requests/api/graphql/project/pipeline/security_report_summary_spec.rb' - 'ee/spec/requests/api/graphql/project/requirements_management/requirements_spec.rb' @@ -2733,7 +2691,6 @@ Layout/LineLength: - 'ee/spec/requests/rack_attack_global_spec.rb' - 'ee/spec/requests/repositories/git_http_controller_spec.rb' - 'ee/spec/requests/smartcard_controller_spec.rb' - - 'ee/spec/requests/survey_responses_controller_spec.rb' - 'ee/spec/routing/admin_routing_spec.rb' - 'ee/spec/routing/group_routing_spec.rb' - 'ee/spec/routing/groups/cadences_routing_spec.rb' @@ -2750,7 +2707,6 @@ Layout/LineLength: - 'ee/spec/serializers/integrations/jira_serializers/issue_detail_entity_spec.rb' - 'ee/spec/serializers/integrations/jira_serializers/issue_entity_spec.rb' - 'ee/spec/serializers/member_entity_spec.rb' - - 'ee/spec/serializers/merge_request_compliance_entity_spec.rb' - 'ee/spec/serializers/project_mirror_entity_spec.rb' - 'ee/spec/serializers/security/license_policy_entity_spec.rb' - 'ee/spec/serializers/status_page/renderer_spec.rb' @@ -2758,7 +2714,6 @@ Layout/LineLength: - 'ee/spec/serializers/vulnerabilities/finding_entity_spec.rb' - 'ee/spec/serializers/vulnerabilities/finding_reports_comparer_entity_spec.rb' - 'ee/spec/serializers/vulnerabilities/finding_serializer_spec.rb' - - 'ee/spec/services/alert_management/metric_images/upload_service_spec.rb' - 'ee/spec/services/alert_management/process_prometheus_alert_service_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/consistency_check_service_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/data_loader_service_spec.rb' @@ -2824,13 +2779,10 @@ Layout/LineLength: - 'ee/spec/services/ee/boards/issues/list_service_spec.rb' - 'ee/spec/services/ee/boards/lists/max_limits_spec.rb' - 'ee/spec/services/ee/ci/pipeline_processing/atomic_processing_service_spec.rb' - - 'ee/spec/services/ee/commits/create_service_spec.rb' - 'ee/spec/services/ee/git/wiki_push_service_spec.rb' - 'ee/spec/services/ee/groups/autocomplete_service_spec.rb' - 'ee/spec/services/ee/groups/deploy_tokens/create_service_spec.rb' - 'ee/spec/services/ee/groups/import_export/export_service_spec.rb' - - 'ee/spec/services/ee/incident_management/issuable_escalation_statuses/after_update_service_spec.rb' - - 'ee/spec/services/ee/incident_management/issuable_escalation_statuses/prepare_update_service_spec.rb' - 'ee/spec/services/ee/ip_restrictions/update_service_spec.rb' - 'ee/spec/services/ee/issuable/common_system_notes_service_spec.rb' - 'ee/spec/services/ee/issuable/destroy_service_spec.rb' @@ -2852,7 +2804,6 @@ Layout/LineLength: - 'ee/spec/services/ee/projects/autocomplete_service_spec.rb' - 'ee/spec/services/ee/projects/deploy_tokens/create_service_spec.rb' - 'ee/spec/services/ee/resource_events/merge_into_notes_service_spec.rb' - - 'ee/spec/services/ee/service_ping/service_ping_settings_spec.rb' - 'ee/spec/services/ee/system_notes/issuables_service_spec.rb' - 'ee/spec/services/ee/users/destroy_service_spec.rb' - 'ee/spec/services/ee/users/migrate_to_ghost_user_service_spec.rb' @@ -2862,7 +2813,6 @@ Layout/LineLength: - 'ee/spec/services/elastic/indexing_control_service_spec.rb' - 'ee/spec/services/elastic/process_initial_bookkeeping_service_spec.rb' - 'ee/spec/services/epic_issues/create_service_spec.rb' - - 'ee/spec/services/epic_links/create_service_spec.rb' - 'ee/spec/services/epics/issue_promote_service_spec.rb' - 'ee/spec/services/epics/related_epic_links/create_service_spec.rb' - 'ee/spec/services/epics/tree_reorder_service_spec.rb' @@ -2923,7 +2873,6 @@ Layout/LineLength: - 'ee/spec/services/merge_trains/create_pipeline_service_spec.rb' - 'ee/spec/services/merge_trains/refresh_merge_request_service_spec.rb' - 'ee/spec/services/merge_trains/refresh_service_spec.rb' - - 'ee/spec/services/namespaces/check_excess_storage_size_service_spec.rb' - 'ee/spec/services/personal_access_tokens/create_service_audit_log_spec.rb' - 'ee/spec/services/personal_access_tokens/rotation_verifier_service_spec.rb' - 'ee/spec/services/projects/alerting/notify_service_spec.rb' @@ -2981,7 +2930,6 @@ Layout/LineLength: - 'ee/spec/services/start_pull_mirroring_service_spec.rb' - 'ee/spec/services/status_page/publish_attachments_service_spec.rb' - 'ee/spec/services/system_notes/escalations_service_spec.rb' - - 'ee/spec/services/system_notes/incidents_service_spec.rb' - 'ee/spec/services/system_notes/merge_train_service_spec.rb' - 'ee/spec/services/timebox_report_service_spec.rb' - 'ee/spec/services/todo_service_spec.rb' @@ -3049,7 +2997,6 @@ Layout/LineLength: - 'ee/spec/support/shared_examples/quick_actions/merge_request/unassign_reviewer_shared_examples.rb' - 'ee/spec/support/shared_examples/requests/api/graphql/geo/registries_shared_examples.rb' - 'ee/spec/support/shared_examples/requests/api/project_approval_rules_api_shared_examples.rb' - - 'ee/spec/support/shared_examples/serializers/license_compliance/comparer_entity_examples.rb' - 'ee/spec/support/shared_examples/services/alert_management/alert_processing/alert_firing_shared_examples.rb' - 'ee/spec/support/shared_examples/services/alert_management/alert_processing/alert_recovery_shared_examples.rb' - 'ee/spec/support/shared_examples/services/base_sync_service_shared_examples.rb' @@ -3068,7 +3015,6 @@ Layout/LineLength: - 'ee/spec/tasks/geo/git_rake_spec.rb' - 'ee/spec/tasks/geo_rake_spec.rb' - 'ee/spec/tasks/gitlab/geo_rake_spec.rb' - - 'ee/spec/uploaders/every_gitlab_uploader_spec.rb' - 'ee/spec/validators/json_schema_validator_spec.rb' - 'ee/spec/views/admin/application_settings/_elasticsearch_form.html.haml_spec.rb' - 'ee/spec/views/admin/application_settings/general.html.haml_spec.rb' @@ -3080,7 +3026,6 @@ Layout/LineLength: - 'ee/spec/views/layouts/header/help_dropdown/_cross_stage_fdm.html.haml_spec.rb' - 'ee/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' - 'ee/spec/views/operations/environments.html.haml_spec.rb' - - 'ee/spec/views/projects/protected_environments/_protected_environment.html.haml_spec.rb' - 'ee/spec/views/projects/security/discover/show.html.haml_spec.rb' - 'ee/spec/views/registrations/groups_projects/new.html.haml_spec.rb' - 'ee/spec/views/registrations/welcome/show.html.haml_spec.rb' @@ -3134,7 +3079,6 @@ Layout/LineLength: - 'ee/spec/workers/iterations/roll_over_issues_worker_spec.rb' - 'ee/spec/workers/iterations_update_status_worker_spec.rb' - 'ee/spec/workers/merge_request_reset_approvals_worker_spec.rb' - - 'ee/spec/workers/network_policy_metrics_worker_spec.rb' - 'ee/spec/workers/new_epic_worker_spec.rb' - 'ee/spec/workers/refresh_license_compliance_checks_worker_spec.rb' - 'ee/spec/workers/repository_import_worker_spec.rb' @@ -3273,7 +3217,6 @@ Layout/LineLength: - 'lib/api/todos.rb' - 'lib/api/users.rb' - 'lib/api/wikis.rb' - - 'lib/atlassian/jira_connect/asymmetric_jwt.rb' - 'lib/atlassian/jira_connect/client.rb' - 'lib/atlassian/jira_connect/serializers/repository_entity.rb' - 'lib/backup.rb' @@ -3324,7 +3267,6 @@ Layout/LineLength: - 'lib/gitlab/analytics/cycle_analytics/stage_events/issue_stage_end.rb' - 'lib/gitlab/analytics/cycle_analytics/stage_events/plan_stage_start.rb' - 'lib/gitlab/analytics/cycle_analytics/stage_query_helpers.rb' - - 'lib/gitlab/analytics/unique_visits.rb' - 'lib/gitlab/application_context.rb' - 'lib/gitlab/application_rate_limiter.rb' - 'lib/gitlab/asciidoc.rb' @@ -3485,7 +3427,6 @@ Layout/LineLength: - 'lib/gitlab/diff/highlight_cache.rb' - 'lib/gitlab/diff/parser.rb' - 'lib/gitlab/diff/rendered/notebook/diff_file.rb' - - 'lib/gitlab/elasticsearch/logs/lines.rb' - 'lib/gitlab/email/failure_handler.rb' - 'lib/gitlab/email/handler/create_issue_handler.rb' - 'lib/gitlab/email/handler/create_merge_request_handler.rb' @@ -3550,8 +3491,6 @@ Layout/LineLength: - 'lib/gitlab/grape_logging/loggers/client_env_logger.rb' - 'lib/gitlab/graphql/pagination/keyset/generic_keyset_pagination.rb' - 'lib/gitlab/graphql/pagination/keyset/query_builder.rb' - - 'lib/gitlab/graphql/query_analyzers/logger_analyzer.rb' - - 'lib/gitlab/graphql/query_analyzers/recursion_analyzer.rb' - 'lib/gitlab/graphql/timeout.rb' - 'lib/gitlab/group_search_results.rb' - 'lib/gitlab/hashed_storage/migrator.rb' @@ -3583,10 +3522,8 @@ Layout/LineLength: - 'lib/gitlab/jira_import.rb' - 'lib/gitlab/jira_import/base_importer.rb' - 'lib/gitlab/jira_import/issues_importer.rb' - - 'lib/gitlab/kubernetes/cilium_network_policy.rb' - 'lib/gitlab/kubernetes/helm/pod.rb' - 'lib/gitlab/kubernetes/kubectl_cmd.rb' - - 'lib/gitlab/kubernetes/network_policy.rb' - 'lib/gitlab/kubernetes/pod_cmd.rb' - 'lib/gitlab/legacy_github_import/importer.rb' - 'lib/gitlab/legacy_github_import/project_creator.rb' @@ -3597,7 +3534,6 @@ Layout/LineLength: - 'lib/gitlab/merge_requests/commit_message_generator.rb' - 'lib/gitlab/metrics/dashboard/importer.rb' - 'lib/gitlab/metrics/dashboard/importers/prometheus_metrics.rb' - - 'lib/gitlab/metrics/dashboard/stages/alerts_inserter.rb' - 'lib/gitlab/metrics/dashboard/stages/cluster_endpoint_inserter.rb' - 'lib/gitlab/metrics/dashboard/stages/custom_metrics_details_inserter.rb' - 'lib/gitlab/metrics/dashboard/stages/metric_endpoint_inserter.rb' @@ -3794,7 +3730,6 @@ Layout/LineLength: - 'qa/qa/scenario/template.rb' - 'qa/qa/service/cluster_provider/gcloud.rb' - 'qa/qa/service/cluster_provider/k3s.rb' - - 'qa/qa/service/cluster_provider/k3s_cilium.rb' - 'qa/qa/service/kubernetes_cluster.rb' - 'qa/qa/service/praefect_manager.rb' - 'qa/qa/specs/features/api/1_manage/project_access_token_spec.rb' @@ -3817,9 +3752,6 @@ Layout/LineLength: - 'qa/qa/specs/features/api/3_create/snippet/snippet_repository_storage_move_spec.rb' - 'qa/qa/specs/features/api/4_verify/cancel_pipeline_when_block_user_spec.rb' - 'qa/qa/specs/features/api/5_package/container_registry_spec.rb' - - 'qa/qa/specs/features/browser_ui/14_non_devops/performance_bar_spec.rb' - - 'qa/qa/specs/features/browser_ui/14_non_devops/service_ping_default_enabled_spec.rb' - - 'qa/qa/specs/features/browser_ui/14_non_devops/service_ping_disabled_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/group/create_group_with_mattermost_team_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/2fa_recovery_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/2fa_ssh_recovery_spec.rb' @@ -3832,7 +3764,6 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/1_manage/project/create_project_badge_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/project/dashboard_images_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/project/invite_group_to_project_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/personal_project_permissions_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/project/project_access_token_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/user/follow_user_activity_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/user/user_access_termination_spec.rb' @@ -3927,9 +3858,6 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/rubygems_registry_spec.rb' - 'qa/qa/specs/features/browser_ui/6_release/pages/pages_pipeline_spec.rb' - - 'qa/qa/specs/features/browser_ui/6_release/pipeline/multi-project_pipelines_spec.rb' - - 'qa/qa/specs/features/browser_ui/6_release/pipeline/parent_child_pipelines_dependent_relationship_spec.rb' - - 'qa/qa/specs/features/browser_ui/6_release/pipeline/parent_child_pipelines_independent_relationship_spec.rb' - 'qa/qa/specs/features/browser_ui/7_configure/kubernetes/kubernetes_integration_spec.rb' - 'qa/qa/specs/features/ee/api/12_geo/geo_nodes_spec.rb' - 'qa/qa/specs/features/ee/api/1_manage/user/minimal_access_user_spec.rb' @@ -3944,7 +3872,6 @@ Layout/LineLength: - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/notes_index/note_index_spec.rb' - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/nightly_elasticsearch_test_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/10_protect/policies_list_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/10_protect/policy_alerts_list_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/cloud_activation_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/license_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/free_trial_spec.rb' @@ -4014,7 +3941,6 @@ Layout/LineLength: - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/pull_mirroring_over_ssh_with_key_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/restrict_push_protected_branch_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/4_verify/cancelling_merge_request_in_merge_train_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/pipeline_status_on_operation_dashboard_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/pipeline_subscription_with_group_owned_project_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/transient/merge_trains_transient_bug_spec.rb' @@ -4040,7 +3966,6 @@ Layout/LineLength: - 'qa/qa/vendor/jenkins/page/login.rb' - 'qa/spec/git/repository_spec.rb' - 'qa/spec/page/logging_spec.rb' - - 'qa/spec/qa_deprecation_toolkit_env.rb' - 'qa/spec/resource/api_fabricator_spec.rb' - 'qa/spec/runtime/env_spec.rb' - 'qa/spec/runtime/feature_spec.rb' @@ -4100,7 +4025,6 @@ Layout/LineLength: - 'spec/controllers/admin/groups_controller_spec.rb' - 'spec/controllers/admin/impersonations_controller_spec.rb' - 'spec/controllers/admin/projects_controller_spec.rb' - - 'spec/controllers/admin/requests_profiles_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb' - 'spec/controllers/application_controller_spec.rb' - 'spec/controllers/boards/issues_controller_spec.rb' @@ -4184,7 +4108,6 @@ Layout/LineLength: - 'spec/controllers/projects/registry/tags_controller_spec.rb' - 'spec/controllers/projects/repositories_controller_spec.rb' - 'spec/controllers/projects/runners_controller_spec.rb' - - 'spec/controllers/projects/serverless/functions_controller_spec.rb' - 'spec/controllers/projects/service_desk_controller_spec.rb' - 'spec/controllers/projects/service_ping_controller_spec.rb' - 'spec/controllers/projects/settings/ci_cd_controller_spec.rb' @@ -4229,7 +4152,6 @@ Layout/LineLength: - 'spec/features/action_cable_logging_spec.rb' - 'spec/features/admin/admin_abuse_reports_spec.rb' - 'spec/features/admin/admin_mode/login_spec.rb' - - 'spec/features/admin/admin_runners_spec.rb' - 'spec/features/admin/admin_sees_background_migrations_spec.rb' - 'spec/features/admin/admin_sees_project_statistics_spec.rb' - 'spec/features/admin/admin_settings_spec.rb' @@ -4309,7 +4231,6 @@ Layout/LineLength: - 'spec/features/labels_hierarchy_spec.rb' - 'spec/features/markdown/copy_as_gfm_spec.rb' - 'spec/features/markdown/gitlab_flavored_markdown_spec.rb' - - 'spec/features/markdown/mermaid_spec.rb' - 'spec/features/markdown/metrics_spec.rb' - 'spec/features/merge_request/batch_comments_spec.rb' - 'spec/features/merge_request/maintainer_edits_fork_spec.rb' @@ -4430,13 +4351,6 @@ Layout/LineLength: - 'spec/features/projects/tree/upload_file_spec.rb' - 'spec/features/projects/view_on_env_spec.rb' - 'spec/features/projects_spec.rb' - - 'spec/features/refactor_blob_viewer_disabled/projects/blobs/blob_line_permalink_updater_spec.rb' - - 'spec/features/refactor_blob_viewer_disabled/projects/blobs/blob_show_spec.rb' - - 'spec/features/refactor_blob_viewer_disabled/projects/blobs/edit_spec.rb' - - 'spec/features/refactor_blob_viewer_disabled/projects/blobs/shortcuts_blob_spec.rb' - - 'spec/features/refactor_blob_viewer_disabled/projects/blobs/user_follows_pipeline_suggest_nudge_spec.rb' - - 'spec/features/refactor_blob_viewer_disabled/projects/blobs/user_views_pipeline_editor_button_spec.rb' - - 'spec/features/refactor_blob_viewer_disabled/projects/files/user_browses_files_spec.rb' - 'spec/features/runners_spec.rb' - 'spec/features/search/user_searches_for_comments_spec.rb' - 'spec/features/search/user_searches_for_merge_requests_spec.rb' @@ -4477,7 +4391,6 @@ Layout/LineLength: - 'spec/finders/deployments_finder_spec.rb' - 'spec/finders/environments/environments_by_deployments_finder_spec.rb' - 'spec/finders/environments/environments_finder_spec.rb' - - 'spec/finders/error_tracking/errors_finder_spec.rb' - 'spec/finders/events_finder_spec.rb' - 'spec/finders/fork_targets_finder_spec.rb' - 'spec/finders/group_descendants_finder_spec.rb' @@ -4583,7 +4496,7 @@ Layout/LineLength: - 'spec/graphql/resolvers/projects/jira_projects_resolver_spec.rb' - 'spec/graphql/resolvers/releases_resolver_spec.rb' - 'spec/graphql/resolvers/snippets_resolver_spec.rb' - - 'spec/graphql/resolvers/todo_resolver_spec.rb' + - 'spec/graphql/resolvers/todos_resolver_spec.rb' - 'spec/graphql/resolvers/user_discussions_count_resolver_spec.rb' - 'spec/graphql/resolvers/users/group_count_resolver_spec.rb' - 'spec/graphql/resolvers/users/groups_resolver_spec.rb' @@ -4707,20 +4620,14 @@ Layout/LineLength: - 'spec/lib/api/helpers/packages_helpers_spec.rb' - 'spec/lib/api/helpers/rate_limiter_spec.rb' - 'spec/lib/api/helpers_spec.rb' - - 'spec/lib/atlassian/jira_connect/asymmetric_jwt_spec.rb' - 'spec/lib/atlassian/jira_connect/client_spec.rb' - 'spec/lib/atlassian/jira_connect/serializers/feature_flag_entity_spec.rb' - 'spec/lib/atlassian/jira_issue_key_extractor_spec.rb' - - 'spec/lib/backup/artifacts_spec.rb' - 'spec/lib/backup/database_spec.rb' - 'spec/lib/backup/files_spec.rb' - 'spec/lib/backup/gitaly_backup_spec.rb' - - 'spec/lib/backup/lfs_spec.rb' - 'spec/lib/backup/manager_spec.rb' - - 'spec/lib/backup/object_backup_spec.rb' - - 'spec/lib/backup/pages_spec.rb' - 'spec/lib/backup/repositories_spec.rb' - - 'spec/lib/backup/uploads_spec.rb' - 'spec/lib/banzai/commit_renderer_spec.rb' - 'spec/lib/banzai/filter/ascii_doc_post_processing_filter_spec.rb' - 'spec/lib/banzai/filter/ascii_doc_sanitization_filter_spec.rb' @@ -4922,7 +4829,6 @@ Layout/LineLength: - 'spec/lib/gitlab/ci/templates/5_minute_production_app_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/Jobs/deploy_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/auto_devops_gitlab_ci_yaml_spec.rb' - - 'spec/lib/gitlab/ci/templates/managed_cluster_applications_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/npm_spec.rb' - 'spec/lib/gitlab/ci/variables/builder_spec.rb' - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' @@ -5007,7 +4913,6 @@ Layout/LineLength: - 'spec/lib/gitlab/diff/position_tracer/image_strategy_spec.rb' - 'spec/lib/gitlab/diff/position_tracer/line_strategy_spec.rb' - 'spec/lib/gitlab/diff/suggestion_spec.rb' - - 'spec/lib/gitlab/elasticsearch/logs/lines_spec.rb' - 'spec/lib/gitlab/email/failure_handler_spec.rb' - 'spec/lib/gitlab/email/handler/create_issue_handler_spec.rb' - 'spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb' @@ -5127,14 +5032,12 @@ Layout/LineLength: - 'spec/lib/gitlab/jira_import_spec.rb' - 'spec/lib/gitlab/kas/client_spec.rb' - 'spec/lib/gitlab/kas_spec.rb' - - 'spec/lib/gitlab/kubernetes/cilium_network_policy_spec.rb' - 'spec/lib/gitlab/kubernetes/deployment_spec.rb' - 'spec/lib/gitlab/kubernetes/helm/api_spec.rb' - 'spec/lib/gitlab/kubernetes/helm/pod_spec.rb' - 'spec/lib/gitlab/kubernetes/kubeconfig/template_spec.rb' - 'spec/lib/gitlab/kubernetes/kubectl_cmd_spec.rb' - 'spec/lib/gitlab/kubernetes/namespace_spec.rb' - - 'spec/lib/gitlab/kubernetes/network_policy_spec.rb' - 'spec/lib/gitlab/kubernetes/pod_cmd_spec.rb' - 'spec/lib/gitlab/kubernetes/rollout_status_spec.rb' - 'spec/lib/gitlab/kubernetes_spec.rb' @@ -5346,7 +5249,6 @@ Layout/LineLength: - 'spec/migrations/backfill_escalation_policies_for_oncall_schedules_spec.rb' - 'spec/migrations/backfill_nuget_temporary_packages_to_processing_status_spec.rb' - 'spec/migrations/backfill_project_namespaces_for_group_spec.rb' - - 'spec/migrations/backfill_work_item_type_id_on_issues_spec.rb' - 'spec/migrations/cleanup_after_add_primary_email_to_emails_if_user_confirmed_spec.rb' - 'spec/migrations/cleanup_after_fixing_issue_when_admin_changed_primary_email_spec.rb' - 'spec/migrations/cleanup_move_container_registry_enabled_to_project_feature_spec.rb' @@ -5369,7 +5271,6 @@ Layout/LineLength: - 'spec/migrations/reset_severity_levels_to_new_default_spec.rb' - 'spec/migrations/schedule_add_primary_email_to_emails_if_user_confirmed_spec.rb' - 'spec/migrations/schedule_copy_ci_builds_columns_to_security_scans2_spec.rb' - - 'spec/migrations/schedule_migrate_pages_to_zip_storage_spec.rb' - 'spec/migrations/schedule_populate_status_column_of_security_scans_spec.rb' - 'spec/migrations/schedule_recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - 'spec/migrations/schedule_update_timelogs_null_spent_at_spec.rb' @@ -5591,7 +5492,6 @@ Layout/LineLength: - 'spec/presenters/alert_management/alert_presenter_spec.rb' - 'spec/presenters/blob_presenter_spec.rb' - 'spec/presenters/blobs/notebook_presenter_spec.rb' - - 'spec/presenters/ci/legacy_stage_presenter_spec.rb' - 'spec/presenters/ci/pipeline_artifacts/code_quality_mr_diff_presenter_spec.rb' - 'spec/presenters/ci/pipeline_presenter_spec.rb' - 'spec/presenters/clusters/cluster_presenter_spec.rb' @@ -5607,7 +5507,6 @@ Layout/LineLength: - 'spec/presenters/packages/nuget/package_metadata_presenter_spec.rb' - 'spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb' - 'spec/presenters/packages/nuget/search_results_presenter_spec.rb' - - 'spec/presenters/packages/pypi/package_presenter_spec.rb' - 'spec/presenters/projects/security/configuration_presenter_spec.rb' - 'spec/presenters/prometheus_alert_presenter_spec.rb' - 'spec/presenters/service_hook_presenter_spec.rb' @@ -5837,7 +5736,6 @@ Layout/LineLength: - 'spec/rubocop/cop/migration/safer_boolean_column_spec.rb' - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb' - 'spec/rubocop/cop/performance/readlines_each_spec.rb' - - 'spec/rubocop/cop/qa/testcase_link_format_spec.rb' - 'spec/rubocop/cop/rspec/env_assignment_spec.rb' - 'spec/rubocop/cop/rspec/expect_gitlab_tracking_spec.rb' - 'spec/rubocop/cop/scalability/file_uploads_spec.rb' @@ -5884,7 +5782,6 @@ Layout/LineLength: - 'spec/services/alert_management/http_integrations/update_service_spec.rb' - 'spec/services/application_settings/update_service_spec.rb' - 'spec/services/authorized_project_update/find_records_due_for_refresh_service_spec.rb' - - 'spec/services/authorized_project_update/project_create_service_spec.rb' - 'spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb' - 'spec/services/boards/issues/create_service_spec.rb' - 'spec/services/boards/issues/list_service_spec.rb' @@ -5918,7 +5815,6 @@ Layout/LineLength: - 'spec/services/clusters/applications/check_installation_progress_service_spec.rb' - 'spec/services/clusters/applications/check_uninstall_progress_service_spec.rb' - 'spec/services/clusters/applications/create_service_spec.rb' - - 'spec/services/clusters/applications/schedule_update_service_spec.rb' - 'spec/services/clusters/applications/uninstall_service_spec.rb' - 'spec/services/clusters/aws/fetch_credentials_service_spec.rb' - 'spec/services/clusters/aws/provision_service_spec.rb' @@ -5981,7 +5877,6 @@ Layout/LineLength: - 'spec/services/incident_management/pager_duty/process_webhook_service_spec.rb' - 'spec/services/integrations/propagate_service_spec.rb' - 'spec/services/issuable/bulk_update_service_spec.rb' - - 'spec/services/issuable/clone/attributes_rewriter_spec.rb' - 'spec/services/issuable/common_system_notes_service_spec.rb' - 'spec/services/issuable/destroy_service_spec.rb' - 'spec/services/issue_links/create_service_spec.rb' @@ -6090,8 +5985,6 @@ Layout/LineLength: - 'spec/services/pages/migrate_legacy_storage_to_deployment_service_spec.rb' - 'spec/services/personal_access_tokens/create_service_spec.rb' - 'spec/services/personal_access_tokens/revoke_service_spec.rb' - - 'spec/services/pod_logs/elasticsearch_service_spec.rb' - - 'spec/services/pod_logs/kubernetes_service_spec.rb' - 'spec/services/post_receive_service_spec.rb' - 'spec/services/projects/apple_target_platform_detector_service_spec.rb' - 'spec/services/projects/autocomplete_service_spec.rb' @@ -6142,7 +6035,6 @@ Layout/LineLength: - 'spec/services/search_service_spec.rb' - 'spec/services/security/ci_configuration/sast_create_service_spec.rb' - 'spec/services/security/merge_reports_service_spec.rb' - - 'spec/services/service_ping/service_ping_settings_spec.rb' - 'spec/services/service_ping/submit_service_ping_service_spec.rb' - 'spec/services/snippets/create_service_spec.rb' - 'spec/services/snippets/update_repository_storage_service_spec.rb' @@ -6508,8 +6400,6 @@ Layout/LineLength: - 'spec/workers/incident_management/pager_duty/process_incident_worker_spec.rb' - 'spec/workers/incident_management/process_alert_worker_v2_spec.rb' - 'spec/workers/invalid_gpg_signature_update_worker_spec.rb' - - 'spec/workers/issue_placement_worker_spec.rb' - - 'spec/workers/issue_rebalancing_worker_spec.rb' - 'spec/workers/issues/placement_worker_spec.rb' - 'spec/workers/issues/rebalancing_worker_spec.rb' - 'spec/workers/issues/reschedule_stuck_issue_rebalances_worker_spec.rb' @@ -6544,9 +6434,7 @@ Layout/LineLength: - 'spec/workers/todos_destroyer/confidential_issue_worker_spec.rb' - 'spec/workers/update_head_pipeline_for_merge_request_worker_spec.rb' - 'spec/workers/users/deactivate_dormant_users_worker_spec.rb' - - 'spec/workers/web_hooks/destroy_worker_spec.rb' - 'tooling/bin/find_changes' - - 'tooling/bin/qa/check_if_qa_only_spec_changes' - 'tooling/danger/product_intelligence.rb' - 'tooling/danger/project_helper.rb' - 'tooling/danger/specs.rb' diff --git a/.rubocop_todo/layout/multiline_operation_indentation.yml b/.rubocop_todo/layout/multiline_operation_indentation.yml index 0f2404ee3cc..51ecf97d318 100644 --- a/.rubocop_todo/layout/multiline_operation_indentation.yml +++ b/.rubocop_todo/layout/multiline_operation_indentation.yml @@ -71,7 +71,6 @@ Layout/MultilineOperationIndentation: - 'lib/gitlab/ci/reports/security/finding_key.rb' - 'lib/gitlab/database/load_balancing/connection_proxy.rb' - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' - - 'lib/gitlab/elasticsearch/logs/lines.rb' - 'lib/gitlab/form_builders/gitlab_ui_form_builder.rb' - 'lib/gitlab/git_access.rb' - 'lib/gitlab/gl_repository/repo_type.rb' @@ -96,7 +95,6 @@ Layout/MultilineOperationIndentation: - 'qa/qa/page/component/snippet.rb' - 'qa/qa/runtime/api/repository_storage_moves.rb' - 'rubocop/cop/gitlab/keys_first_and_values_first.rb' - - 'rubocop/cop/migration/hash_index.rb' - 'rubocop/migration_helpers.rb' - 'spec/frontend/fixtures/tabs.rb' - 'spec/lib/gitlab/ci/pipeline/seed/build_spec.rb' diff --git a/.rubocop_todo/layout/space_in_lambda_literal.yml b/.rubocop_todo/layout/space_in_lambda_literal.yml index e633f51209d..c88fdf5a3b0 100644 --- a/.rubocop_todo/layout/space_in_lambda_literal.yml +++ b/.rubocop_todo/layout/space_in_lambda_literal.yml @@ -141,7 +141,6 @@ Layout/SpaceInLambdaLiteral: - 'app/serializers/concerns/user_status_tooltip.rb' - 'app/serializers/container_repository_entity.rb' - 'app/serializers/container_tag_entity.rb' - - 'app/serializers/deploy_key_entity.rb' - 'app/serializers/deployment_cluster_entity.rb' - 'app/serializers/deployment_entity.rb' - 'app/serializers/detailed_status_entity.rb' @@ -276,7 +275,6 @@ Layout/SpaceInLambdaLiteral: - 'ee/app/serializers/epic_entity.rb' - 'ee/app/serializers/epic_note_entity.rb' - 'ee/app/serializers/linked_epic_issue_entity.rb' - - 'ee/app/serializers/merge_request_compliance_entity.rb' - 'ee/app/serializers/metrics_report_metric_entity.rb' - 'ee/app/serializers/vulnerabilities/feedback_entity.rb' - 'ee/app/serializers/vulnerabilities/finding_entity.rb' diff --git a/.rubocop_todo/layout/space_inside_block_braces.yml b/.rubocop_todo/layout/space_inside_block_braces.yml index 961b27f26e7..c084147eb58 100644 --- a/.rubocop_todo/layout/space_inside_block_braces.yml +++ b/.rubocop_todo/layout/space_inside_block_braces.yml @@ -11,7 +11,6 @@ Layout/SpaceInsideBlockBraces: - 'app/controllers/projects/boards_controller.rb' - 'app/experiments/security_reports_mr_widget_prompt_experiment.rb' - 'app/experiments/video_tutorials_continuous_onboarding_experiment.rb' - - 'app/graphql/types/concerns/find_closest.rb' - 'app/helpers/favicon_helper.rb' - 'app/helpers/time_zone_helper.rb' - 'app/helpers/todos_helper.rb' @@ -192,7 +191,6 @@ Layout/SpaceInsideBlockBraces: - 'ee/spec/requests/groups/contribution_analytics_spec.rb' - 'ee/spec/requests/lfs_http_spec.rb' - 'ee/spec/requests/projects/security/policies_controller_spec.rb' - - 'ee/spec/requests/survey_responses_controller_spec.rb' - 'ee/spec/serializers/member_user_entity_spec.rb' - 'ee/spec/serializers/merge_request_poll_widget_entity_spec.rb' - 'ee/spec/serializers/vulnerabilities/finding_reports_comparer_entity_spec.rb' @@ -245,7 +243,6 @@ Layout/SpaceInsideBlockBraces: - 'ee/spec/support/shared_examples/services/boards/base_service_shared_examples.rb' - 'ee/spec/support/shared_examples/services/search_notes_shared_examples.rb' - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' - - 'ee/spec/uploaders/every_gitlab_uploader_spec.rb' - 'ee/spec/views/registrations/groups_projects/new.html.haml_spec.rb' - 'ee/spec/views/shared/billings/_eoa_bronze_plan_banner.html.haml_spec.rb' - 'ee/spec/views/shared/credentials_inventory/_expiry_date.html.haml_spec.rb' @@ -266,7 +263,6 @@ Layout/SpaceInsideBlockBraces: - 'lib/gitlab/contributions_calendar.rb' - 'lib/gitlab/database/migrations/test_background_runner.rb' - 'lib/gitlab/database/postgres_hll/buckets.rb' - - 'lib/gitlab/elasticsearch/logs/lines.rb' - 'lib/gitlab/email/message/in_product_marketing/helper.rb' - 'lib/gitlab/issues/rebalancing/state.rb' - 'lib/gitlab/profiler.rb' @@ -350,7 +346,6 @@ Layout/SpaceInsideBlockBraces: - 'spec/features/projects/pipelines/pipelines_spec.rb' - 'spec/features/projects/settings/service_desk_setting_spec.rb' - 'spec/features/projects/tree/tree_show_spec.rb' - - 'spec/features/refactor_blob_viewer_disabled/projects/files/user_browses_files_spec.rb' - 'spec/features/users/login_spec.rb' - 'spec/finders/ci/jobs_finder_spec.rb' - 'spec/finders/ci/runners_finder_spec.rb' @@ -378,9 +373,7 @@ Layout/SpaceInsideBlockBraces: - 'spec/frontend/fixtures/pipeline_schedules.rb' - 'spec/frontend/fixtures/pipelines.rb' - 'spec/frontend/fixtures/projects.rb' - - 'spec/frontend/fixtures/prometheus_service.rb' - 'spec/frontend/fixtures/raw.rb' - - 'spec/frontend/fixtures/services.rb' - 'spec/frontend/fixtures/snippet.rb' - 'spec/frontend/fixtures/todos.rb' - 'spec/graphql/mutations/merge_requests/set_labels_spec.rb' @@ -469,7 +462,6 @@ Layout/SpaceInsideBlockBraces: - 'spec/lib/gitlab/database/with_lock_retries_spec.rb' - 'spec/lib/gitlab/database_importers/common_metrics/importer_spec.rb' - 'spec/lib/gitlab/database_spec.rb' - - 'spec/lib/gitlab/elasticsearch/logs/lines_spec.rb' - 'spec/lib/gitlab/email/handler/create_note_handler_spec.rb' - 'spec/lib/gitlab/email/handler/service_desk_handler_spec.rb' - 'spec/lib/gitlab/email/message/in_product_marketing/admin_verify_spec.rb' @@ -557,7 +549,6 @@ Layout/SpaceInsideBlockBraces: - 'spec/models/ci/pipeline_schedule_spec.rb' - 'spec/models/ci/pipeline_spec.rb' - 'spec/models/ci/runner_spec.rb' - - 'spec/models/clusters/applications/elastic_stack_spec.rb' - 'spec/models/clusters/cluster_spec.rb' - 'spec/models/commit_status_spec.rb' - 'spec/models/concerns/chronic_duration_attribute_spec.rb' @@ -604,7 +595,6 @@ Layout/SpaceInsideBlockBraces: - 'spec/presenters/packages/composer/packages_presenter_spec.rb' - 'spec/presenters/packages/conan/package_presenter_spec.rb' - 'spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb' - - 'spec/presenters/packages/pypi/package_presenter_spec.rb' - 'spec/presenters/project_presenter_spec.rb' - 'spec/requests/api/branches_spec.rb' - 'spec/requests/api/ci/jobs_spec.rb' @@ -659,7 +649,6 @@ Layout/SpaceInsideBlockBraces: - 'spec/requests/oauth/tokens_controller_spec.rb' - 'spec/rubocop/cop/migration/create_table_with_foreign_keys_spec.rb' - 'spec/serializers/cluster_entity_spec.rb' - - 'spec/serializers/deploy_key_entity_spec.rb' - 'spec/serializers/import/provider_repo_serializer_spec.rb' - 'spec/services/auto_merge/base_service_spec.rb' - 'spec/services/auto_merge_service_spec.rb' @@ -762,4 +751,3 @@ Layout/SpaceInsideBlockBraces: - 'spec/workers/pages_worker_spec.rb' - 'spec/workers/purge_dependency_proxy_cache_worker_spec.rb' - 'spec/workers/releases/manage_evidence_worker_spec.rb' - - 'spec/workers/repository_remove_remote_worker_spec.rb' diff --git a/.rubocop_todo/layout/space_inside_parens.yml b/.rubocop_todo/layout/space_inside_parens.yml index 9022d41aeeb..301568f0ec4 100644 --- a/.rubocop_todo/layout/space_inside_parens.yml +++ b/.rubocop_todo/layout/space_inside_parens.yml @@ -44,7 +44,6 @@ Layout/SpaceInsideParens: - 'ee/app/services/compliance_management/frameworks/destroy_service.rb' - 'ee/app/services/compliance_management/frameworks/update_service.rb' - 'ee/app/services/elastic/cluster_reindexing_service.rb' - - 'ee/app/services/namespaces/check_storage_size_service.rb' - 'ee/app/services/sitemap/create_service.rb' - 'ee/lib/ee/gitlab/auth/ldap/access.rb' - 'ee/lib/gitlab/auth/smartcard/session.rb' @@ -71,7 +70,6 @@ Layout/SpaceInsideParens: - 'ee/spec/features/merge_requests/user_resets_approvers_spec.rb' - 'ee/spec/features/merge_requests/user_views_all_merge_requests_spec.rb' - 'ee/spec/features/merge_trains/two_merge_requests_on_train_spec.rb' - - 'ee/spec/finders/ee/alert_management/alerts_finder_spec.rb' - 'ee/spec/finders/ee/alert_management/http_integrations_finder_spec.rb' - 'ee/spec/finders/epics_finder_spec.rb' - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' @@ -89,7 +87,6 @@ Layout/SpaceInsideParens: - 'ee/spec/lib/gitlab/auth/group_saml/group_lookup_spec.rb' - 'ee/spec/lib/gitlab/auth/otp/session_enforcer_spec.rb' - 'ee/spec/lib/gitlab/auth/smartcard/ldap_certificate_spec.rb' - - 'ee/spec/lib/gitlab/auth_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/coverage_fuzzing_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/dast_api_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/dast_api_latest_gitlab_ci_yaml_spec.rb' @@ -132,7 +129,6 @@ Layout/SpaceInsideParens: - 'ee/spec/requests/api/ldap_group_links_spec.rb' - 'ee/spec/requests/api/project_milestones_spec.rb' - 'ee/spec/requests/customers_dot/proxy_controller_spec.rb' - - 'ee/spec/requests/survey_responses_controller_spec.rb' - 'ee/spec/serializers/member_user_entity_spec.rb' - 'ee/spec/services/app_sec/dast/profiles/create_service_spec.rb' - 'ee/spec/services/app_sec/dast/site_profile_secret_variables/create_or_update_service_spec.rb' @@ -188,7 +184,6 @@ Layout/SpaceInsideParens: - 'spec/controllers/projects/runners_controller_spec.rb' - 'spec/dependencies/omniauth_saml_spec.rb' - 'spec/factories/usage_data.rb' - - 'spec/features/admin/admin_runners_spec.rb' - 'spec/features/boards/board_filters_spec.rb' - 'spec/features/boards/user_visits_board_spec.rb' - 'spec/features/dashboard/datetime_on_tooltips_spec.rb' @@ -228,9 +223,7 @@ Layout/SpaceInsideParens: - 'spec/frontend/fixtures/pipeline_schedules.rb' - 'spec/frontend/fixtures/pipelines.rb' - 'spec/frontend/fixtures/projects.rb' - - 'spec/frontend/fixtures/prometheus_service.rb' - 'spec/frontend/fixtures/raw.rb' - - 'spec/frontend/fixtures/services.rb' - 'spec/frontend/fixtures/snippet.rb' - 'spec/frontend/fixtures/todos.rb' - 'spec/graphql/mutations/todos/restore_many_spec.rb' @@ -281,7 +274,6 @@ Layout/SpaceInsideParens: - 'spec/lib/gitlab/ci/templates/auto_devops_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/flutter_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/kaniko_gitlab_ci_yaml_spec.rb' - - 'spec/lib/gitlab/ci/templates/managed_cluster_applications_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/npm_spec.rb' - 'spec/lib/gitlab/ci/templates/terraform_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/terraform_latest_gitlab_ci_yaml_spec.rb' @@ -387,8 +379,6 @@ Layout/SpaceInsideParens: - 'spec/requests/search_controller_spec.rb' - 'spec/serializers/analytics_build_entity_spec.rb' - 'spec/serializers/merge_request_user_entity_spec.rb' - - 'spec/services/authorized_project_update/project_create_service_spec.rb' - - 'spec/services/authorized_project_update/project_group_link_create_service_spec.rb' - 'spec/services/boards/issues/list_service_spec.rb' - 'spec/services/ci/compare_test_reports_service_spec.rb' - 'spec/services/ci/pipeline_processing/atomic_processing_service/status_collection_spec.rb' diff --git a/.rubocop_todo/lint/constant_definition_in_block.yml b/.rubocop_todo/lint/constant_definition_in_block.yml index 1ffea85dfb0..fc70f4870b1 100644 --- a/.rubocop_todo/lint/constant_definition_in_block.yml +++ b/.rubocop_todo/lint/constant_definition_in_block.yml @@ -21,10 +21,8 @@ Lint/ConstantDefinitionInBlock: - 'ee/app/models/ee/project_import_state.rb' - 'ee/app/models/ee/user.rb' - 'ee/app/models/ee/vulnerability.rb' - - 'ee/app/presenters/ee/commit_status_presenter.rb' - 'ee/app/services/ee/notes/quick_actions_service.rb' - 'ee/lib/ee/api/search.rb' - - 'ee/lib/ee/gitlab/ci/status/build/failed.rb' - 'ee/lib/gitlab/subscription_portal/clients/rest.rb' - 'ee/lib/tasks/geo.rake' - 'ee/spec/db/schema_support.rb' diff --git a/.rubocop_todo/lint/redundant_cop_disable_directive.yml b/.rubocop_todo/lint/redundant_cop_disable_directive.yml index d058e23109b..e4925aa2cfd 100644 --- a/.rubocop_todo/lint/redundant_cop_disable_directive.yml +++ b/.rubocop_todo/lint/redundant_cop_disable_directive.yml @@ -44,7 +44,6 @@ Lint/RedundantCopDisableDirective: - 'app/workers/bulk_imports/entity_worker.rb' - 'app/workers/container_expiration_policy_worker.rb' - 'app/workers/create_note_diff_file_worker.rb' - - 'app/workers/expire_job_cache_worker.rb' - 'app/workers/import_issues_csv_worker.rb' - 'app/workers/incident_management/process_alert_worker_v2.rb' - 'app/workers/merge_worker.rb' @@ -152,7 +151,6 @@ Lint/RedundantCopDisableDirective: - 'lib/gitlab/profiler.rb' - 'lib/gitlab/project_search_results.rb' - 'lib/gitlab/redis/hll.rb' - - 'lib/gitlab/request_profiler.rb' - 'lib/gitlab/slash_commands/issue_search.rb' - 'lib/gitlab/usage_data.rb' - 'lib/gitlab/usage_data_queries.rb' diff --git a/.rubocop_todo/migration/background_migration_base_class.yml b/.rubocop_todo/migration/background_migration_base_class.yml index f026ec19c7b..495b4a51e56 100644 --- a/.rubocop_todo/migration/background_migration_base_class.yml +++ b/.rubocop_todo/migration/background_migration_base_class.yml @@ -57,7 +57,6 @@ Migration/BackgroundMigrationBaseClass: - 'lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics.rb' - 'lib/gitlab/background_migration/migrate_requirements_to_work_items.rb' - 'lib/gitlab/background_migration/migrate_shimo_confluence_integration_category.rb' - - 'lib/gitlab/background_migration/migrate_stage_status.rb' - 'lib/gitlab/background_migration/migrate_u2f_webauthn.rb' - 'lib/gitlab/background_migration/move_container_registry_enabled_to_project_feature.rb' - 'lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds.rb' diff --git a/.rubocop_todo/migration/background_migration_record.yml b/.rubocop_todo/migration/background_migration_record.yml index cbf39285a7d..b4feb944d75 100644 --- a/.rubocop_todo/migration/background_migration_record.yml +++ b/.rubocop_todo/migration/background_migration_record.yml @@ -43,7 +43,6 @@ Migration/BackgroundMigrationRecord: - ee/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb - ee/lib/ee/gitlab/background_migration/create_security_setting.rb - ee/lib/ee/gitlab/background_migration/drop_invalid_remediations.rb - - ee/lib/ee/gitlab/background_migration/drop_invalid_remediations.rb - ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb - ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb - ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb diff --git a/.rubocop_todo/naming/rescued_exceptions_variable_name.yml b/.rubocop_todo/naming/rescued_exceptions_variable_name.yml index 0e753a53dc3..b557ca8f06e 100644 --- a/.rubocop_todo/naming/rescued_exceptions_variable_name.yml +++ b/.rubocop_todo/naming/rescued_exceptions_variable_name.yml @@ -22,7 +22,6 @@ Naming/RescuedExceptionsVariableName: - 'app/models/blob_viewer/metrics_dashboard_yml.rb' - 'app/models/ci/build.rb' - 'app/models/ci/deleted_object.rb' - - 'app/models/clusters/concerns/elasticsearch_client.rb' - 'app/models/concerns/prometheus_adapter.rb' - 'app/models/concerns/repository_storage_movable.rb' - 'app/models/concerns/x509_serial_number_attribute.rb' @@ -116,9 +115,6 @@ Naming/RescuedExceptionsVariableName: - 'ee/app/services/geo/repository_base_sync_service.rb' - 'ee/app/services/incident_management/oncall_rotations/create_service.rb' - 'ee/app/services/incident_management/oncall_rotations/edit_service.rb' - - 'ee/app/services/namespaces/deactivate_members_over_limit_service.rb' - - 'ee/app/services/namespaces/remove_project_group_links_outside_hierarchy_service.rb' - - 'ee/app/services/namespaces/update_prevent_sharing_outside_hierarchy_service.rb' - 'ee/app/services/projects/licenses/create_policy_service.rb' - 'ee/app/services/projects/licenses/update_policy_service.rb' - 'ee/app/services/security/ingestion/ingest_report_service.rb' @@ -132,7 +128,6 @@ Naming/RescuedExceptionsVariableName: - 'ee/app/workers/geo/file_removal_worker.rb' - 'ee/app/workers/geo/repositories_clean_up_worker.rb' - 'ee/app/workers/geo/scheduler/scheduler_worker.rb' - - 'ee/app/workers/namespaces/free_user_cap_worker.rb' - 'ee/app/workers/refresh_license_compliance_checks_worker.rb' - 'ee/app/workers/repository_update_mirror_worker.rb' - 'ee/app/workers/sync_seat_link_request_worker.rb' diff --git a/.rubocop_todo/performance/block_given_with_explicit_block.yml b/.rubocop_todo/performance/block_given_with_explicit_block.yml index ff1f5e568ea..b919dbd19e6 100644 --- a/.rubocop_todo/performance/block_given_with_explicit_block.yml +++ b/.rubocop_todo/performance/block_given_with_explicit_block.yml @@ -1,9 +1,6 @@ --- # Cop supports --auto-correct. Performance/BlockGivenWithExplicitBlock: - # Offense count: 53 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'app/controllers/concerns/redis_tracking.rb' - 'app/helpers/badges_helper.rb' @@ -26,11 +23,14 @@ Performance/BlockGivenWithExplicitBlock: - 'lib/gitlab/metrics/methods/metric_options.rb' - 'lib/gitlab/null_request_store.rb' - 'lib/gitlab/quick_actions/dsl.rb' + - 'lib/gitlab/redis/multi_store.rb' - 'lib/gitlab/safe_request_loader.rb' - 'lib/gitlab/search/query.rb' - 'lib/gitlab/string_placeholder_replacer.rb' - 'lib/gitlab/terraform/state_migration_helper.rb' + - 'lib/gitlab/usage/metrics/instrumentations/base_metric.rb' - 'lib/gitlab/usage/metrics/instrumentations/database_metric.rb' + - 'lib/gitlab/usage/metrics/instrumentations/numbers_metric.rb' - 'lib/gitlab/usage_data_queries.rb' - 'lib/gitlab/utils/usage_data.rb' - 'qa/qa/page/view.rb' @@ -38,5 +38,6 @@ Performance/BlockGivenWithExplicitBlock: - 'spec/lib/gitlab/slash_commands/deploy_spec.rb' - 'spec/support/helpers/graphql_helpers.rb' - 'spec/support/helpers/query_recorder.rb' + - 'spec/support/helpers/stub_method_calls.rb' - 'tooling/lib/tooling/helm3_client.rb' - 'tooling/lib/tooling/test_map_packer.rb' diff --git a/.rubocop_todo/performance/collection_literal_in_loop.yml b/.rubocop_todo/performance/collection_literal_in_loop.yml index 4b012bf6645..50fd75827fb 100644 --- a/.rubocop_todo/performance/collection_literal_in_loop.yml +++ b/.rubocop_todo/performance/collection_literal_in_loop.yml @@ -1,12 +1,8 @@ --- Performance/CollectionLiteralInLoop: - # Offense count: 45 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'config/application.rb' - 'config/initializers/1_settings.rb' - - 'ee/app/models/ee/merge_request.rb' - 'ee/spec/features/admin/admin_settings_spec.rb' - 'ee/spec/support/shared_examples/features/protected_branches_access_control_shared_examples.rb' - 'ee/spec/workers/app_sec/dast/profile_schedule_worker_spec.rb' @@ -20,15 +16,18 @@ Performance/CollectionLiteralInLoop: - 'lib/tasks/gitlab/seed/group_seed.rake' - 'spec/bin/sidekiq_cluster_spec.rb' - 'spec/controllers/groups_controller_spec.rb' + - 'spec/finders/ci/runners_finder_spec.rb' - 'spec/lib/banzai/reference_parser/base_parser_spec.rb' - 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb' - 'spec/lib/gitlab/file_detector_spec.rb' - 'spec/lib/gitlab/search/abuse_detection_spec.rb' - 'spec/lib/gitlab/utils/markdown_spec.rb' + - 'spec/metrics_server/metrics_server_spec.rb' - 'spec/models/analytics/cycle_analytics/aggregation_spec.rb' - 'spec/models/ci/build_spec.rb' - 'spec/models/ci/pipeline_spec.rb' - 'spec/models/namespace_statistics_spec.rb' + - 'spec/models/project_spec.rb' - 'spec/presenters/ci/build_runner_presenter_spec.rb' - 'spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb' - 'spec/presenters/packages/nuget/service_index_presenter_spec.rb' diff --git a/.rubocop_todo/performance/constant_regexp.yml b/.rubocop_todo/performance/constant_regexp.yml index 4ed40db498f..23d03ced8d7 100644 --- a/.rubocop_todo/performance/constant_regexp.yml +++ b/.rubocop_todo/performance/constant_regexp.yml @@ -1,15 +1,13 @@ --- # Cop supports --auto-correct. Performance/ConstantRegexp: - # Offense count: 46 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'app/models/commit.rb' - 'app/models/commit_range.rb' - 'app/models/custom_emoji.rb' - 'app/models/gpg_key.rb' - 'app/models/merge_request.rb' + - 'app/models/packages/package.rb' - 'app/models/project.rb' - 'app/models/wiki.rb' - 'ee/app/models/ee/epic.rb' @@ -27,5 +25,6 @@ Performance/ConstantRegexp: - 'lib/gitlab/regex.rb' - 'scripts/perf/query_limiting_report.rb' - 'scripts/validate_migration_schema' + - 'spec/features/users/email_verification_on_login_spec.rb' - 'spec/models/concerns/token_authenticatable_spec.rb' - 'spec/services/notes/copy_service_spec.rb' diff --git a/.rubocop_todo/performance/method_object_as_block.yml b/.rubocop_todo/performance/method_object_as_block.yml index 265e03073db..1bc82ff05ec 100644 --- a/.rubocop_todo/performance/method_object_as_block.yml +++ b/.rubocop_todo/performance/method_object_as_block.yml @@ -1,8 +1,5 @@ --- Performance/MethodObjectAsBlock: - # Offense count: 150 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'app/controllers/concerns/metrics_dashboard.rb' - 'app/controllers/concerns/requires_whitelisted_monitoring_client.rb' @@ -30,7 +27,6 @@ Performance/MethodObjectAsBlock: - 'ee/app/graphql/resolvers/vulnerabilities/scanners_resolver.rb' - 'ee/app/services/dashboard/projects/create_service.rb' - 'ee/app/services/security/findings/cleanup_service.rb' - - 'ee/app/services/security/ingestion/bulk_insertable_task.rb' - 'ee/app/services/security/ingestion/ingest_reports_service.rb' - 'ee/app/services/security/ingestion/tasks/ingest_vulnerability_statistics.rb' - 'ee/app/services/security/store_findings_metadata_service.rb' @@ -38,6 +34,7 @@ Performance/MethodObjectAsBlock: - 'ee/lib/ee/container_registry/client.rb' - 'ee/lib/ee/gitlab/ci/config_ee.rb' - 'ee/lib/ee/gitlab/etag_caching/router/rails.rb' + - 'ee/lib/gitlab/ingestion/bulk_insertable_task.rb' - 'ee/spec/services/groups/participants_service_spec.rb' - 'lib/api/helpers/packages/conan/api_helpers.rb' - 'lib/bulk_imports/pipeline.rb' @@ -80,6 +77,7 @@ Performance/MethodObjectAsBlock: - 'lib/gitlab/utils.rb' - 'lib/peek/views/detailed_view.rb' - 'lib/tasks/gitlab/assets.rake' + - 'lib/unnested_in_filters/rewriter.rb' - 'qa/qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb' - 'rubocop/cop/avoid_return_from_blocks.rb' - 'rubocop/cop/gitlab/mark_used_feature_flags.rb' @@ -95,5 +93,6 @@ Performance/MethodObjectAsBlock: - 'spec/support/helpers/migrations_helpers.rb' - 'spec/support/shared_examples/models/active_record_enum_shared_examples.rb' - 'spec/support_specs/helpers/stub_feature_flags_spec.rb' + - 'tooling/lib/tooling/find_codeowners.rb' - 'tooling/lib/tooling/test_map_packer.rb' - 'tooling/quality/test_level.rb' diff --git a/.rubocop_todo/rails/file_path.yml b/.rubocop_todo/rails/file_path.yml index 1c442dcdec7..467073eb2db 100644 --- a/.rubocop_todo/rails/file_path.yml +++ b/.rubocop_todo/rails/file_path.yml @@ -8,7 +8,6 @@ Rails/FilePath: - 'app/controllers/help_controller.rb' - 'app/helpers/startupjs_helper.rb' - 'app/models/clusters/applications/cert_manager.rb' - - 'app/models/clusters/applications/elastic_stack.rb' - 'app/models/clusters/concerns/application_data.rb' - 'app/models/concerns/cross_database_modification.rb' - 'app/models/release_highlight.rb' @@ -103,7 +102,6 @@ Rails/FilePath: - 'spec/features/projects/snippets/create_snippet_spec.rb' - 'spec/features/projects/tags/user_edits_tags_spec.rb' - 'spec/features/projects/tree/upload_file_spec.rb' - - 'spec/features/refactor_blob_viewer_disabled/projects/files/user_replaces_files_spec.rb' - 'spec/features/snippets/user_creates_snippet_spec.rb' - 'spec/features/snippets/user_edits_snippet_spec.rb' - 'spec/features/uploads/user_uploads_avatar_to_group_spec.rb' diff --git a/.rubocop_todo/rails/helper_instance_variable.yml b/.rubocop_todo/rails/helper_instance_variable.yml index 8a1a6093c3d..006e66ed0b2 100644 --- a/.rubocop_todo/rails/helper_instance_variable.yml +++ b/.rubocop_todo/rails/helper_instance_variable.yml @@ -71,7 +71,6 @@ Rails/HelperInstanceVariable: - 'ee/app/helpers/ee/lock_helper.rb' - 'ee/app/helpers/ee/merge_requests_helper.rb' - 'ee/app/helpers/ee/mirror_helper.rb' - - 'ee/app/helpers/ee/namespace_storage_limit_alert_helper.rb' - 'ee/app/helpers/ee/notes_helper.rb' - 'ee/app/helpers/ee/operations_helper.rb' - 'ee/app/helpers/ee/projects/security/configuration_helper.rb' @@ -82,4 +81,3 @@ Rails/HelperInstanceVariable: - 'ee/app/helpers/ee/wiki_helper.rb' - 'ee/app/helpers/path_locks_helper.rb' - 'ee/app/helpers/projects/security/discover_helper.rb' - - 'ee/app/helpers/seats_count_alert_helper.rb' diff --git a/.rubocop_todo/rails/inverse_of.yml b/.rubocop_todo/rails/inverse_of.yml index 7a757ec8a9d..98d116c3319 100644 --- a/.rubocop_todo/rails/inverse_of.yml +++ b/.rubocop_todo/rails/inverse_of.yml @@ -31,7 +31,6 @@ Rails/InverseOf: - 'app/models/clusters/applications/runner.rb' - 'app/models/clusters/cluster.rb' - 'app/models/clusters/concerns/application_core.rb' - - 'app/models/clusters/integrations/elastic_stack.rb' - 'app/models/clusters/integrations/prometheus.rb' - 'app/models/clusters/project.rb' - 'app/models/commit_signatures/x509_commit_signature.rb' diff --git a/.rubocop_todo/rails/pluck.yml b/.rubocop_todo/rails/pluck.yml index 860b772d913..5e875daa569 100644 --- a/.rubocop_todo/rails/pluck.yml +++ b/.rubocop_todo/rails/pluck.yml @@ -14,7 +14,6 @@ Rails/Pluck: - 'app/models/list.rb' - 'app/services/ci/pipeline_processing/atomic_processing_service/status_collection.rb' - 'app/services/feature_flags/update_service.rb' - - 'app/services/pod_logs/base_service.rb' - 'ee/app/graphql/mutations/incident_management/oncall_rotation/base.rb' - 'ee/app/models/boards/epic_list.rb' - 'ee/app/services/concerns/incident_management/oncall_rotations/shared_rotation_logic.rb' diff --git a/.rubocop_todo/rails/redundant_foreign_key.yml b/.rubocop_todo/rails/redundant_foreign_key.yml index db6e6cedc89..7e394849670 100644 --- a/.rubocop_todo/rails/redundant_foreign_key.yml +++ b/.rubocop_todo/rails/redundant_foreign_key.yml @@ -19,7 +19,6 @@ Rails/RedundantForeignKey: - 'app/models/ci/unit_test_failure.rb' - 'app/models/clusters/applications/runner.rb' - 'app/models/clusters/concerns/application_core.rb' - - 'app/models/clusters/integrations/elastic_stack.rb' - 'app/models/clusters/integrations/prometheus.rb' - 'app/models/commit_signatures/x509_commit_signature.rb' - 'app/models/concerns/analytics/cycle_analytics/stage.rb' diff --git a/.rubocop_todo/rails/skips_model_validations.yml b/.rubocop_todo/rails/skips_model_validations.yml index 75a0d49862e..5c573a484f6 100644 --- a/.rubocop_todo/rails/skips_model_validations.yml +++ b/.rubocop_todo/rails/skips_model_validations.yml @@ -483,7 +483,6 @@ Rails/SkipsModelValidations: - 'spec/features/projects/settings/user_manages_merge_requests_settings_spec.rb' - 'spec/features/projects/user_sees_sidebar_spec.rb' - 'spec/features/projects_spec.rb' - - 'spec/features/refactor_blob_viewer_disabled/projects/blobs/blob_show_spec.rb' - 'spec/features/u2f_spec.rb' - 'spec/features/users/show_spec.rb' - 'spec/features/webauthn_spec.rb' @@ -544,7 +543,6 @@ Rails/SkipsModelValidations: - 'spec/lib/gitlab/middleware/go_spec.rb' - 'spec/lib/gitlab/middleware/query_analyzer_spec.rb' - 'spec/lib/gitlab/object_hierarchy_spec.rb' - - 'spec/lib/gitlab/pages_transfer_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/query_analyzer_spec.rb' - 'spec/lib/sidebars/projects/menus/project_information_menu_spec.rb' - 'spec/mailers/notify_spec.rb' @@ -555,7 +553,6 @@ Rails/SkipsModelValidations: - 'spec/models/ci/build_dependencies_spec.rb' - 'spec/models/ci/build_spec.rb' - 'spec/models/ci/group_spec.rb' - - 'spec/models/ci/legacy_stage_spec.rb' - 'spec/models/ci/pipeline_schedule_spec.rb' - 'spec/models/ci/pipeline_spec.rb' - 'spec/models/ci/processable_spec.rb' @@ -718,7 +715,6 @@ Rails/SkipsModelValidations: - 'spec/uploaders/job_artifact_uploader_spec.rb' - 'spec/views/groups/edit.html.haml_spec.rb' - 'spec/views/projects/environments/terminal.html.haml_spec.rb' - - 'spec/views/projects/tracing/show.html.haml_spec.rb' - 'spec/workers/auto_devops/disable_worker_spec.rb' - 'spec/workers/build_finished_worker_spec.rb' - 'spec/workers/ci/merge_requests/add_todo_when_build_fails_worker_spec.rb' diff --git a/.rubocop_todo/rails/squished_sql_heredocs.yml b/.rubocop_todo/rails/squished_sql_heredocs.yml index dc71b7b32ce..3696f661893 100644 --- a/.rubocop_todo/rails/squished_sql_heredocs.yml +++ b/.rubocop_todo/rails/squished_sql_heredocs.yml @@ -108,7 +108,6 @@ Rails/SquishedSQLHeredocs: - 'ee/app/models/iterations/cadence.rb' - 'ee/app/models/vulnerabilities/statistic.rb' - 'ee/app/services/analytics/cycle_analytics/consistency_check_service.rb' - - 'ee/app/services/security/ingestion/bulk_updatable_task.rb' - 'ee/app/services/security/ingestion/tasks/ingest_vulnerability_statistics.rb' - 'ee/app/services/vulnerabilities/historical_statistics/adjustment_service.rb' - 'ee/app/services/vulnerabilities/statistics/adjustment_service.rb' diff --git a/.rubocop_todo/rails/time_zone.yml b/.rubocop_todo/rails/time_zone.yml index 48e559312f8..8931b337ce1 100644 --- a/.rubocop_todo/rails/time_zone.yml +++ b/.rubocop_todo/rails/time_zone.yml @@ -121,7 +121,6 @@ Rails/TimeZone: - spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb - spec/lib/gitlab/prometheus/queries/validate_query_spec.rb - spec/lib/gitlab/sidekiq_logging/json_formatter_spec.rb - - spec/lib/gitlab/updated_notes_paginator_spec.rb - spec/lib/gitlab/utils/json_size_estimator_spec.rb - spec/lib/gitlab/x509/signature_spec.rb - spec/lib/grafana/time_window_spec.rb diff --git a/.rubocop_todo/rspec/any_instance_of.yml b/.rubocop_todo/rspec/any_instance_of.yml index 399d1751687..2cc2478e530 100644 --- a/.rubocop_todo/rspec/any_instance_of.yml +++ b/.rubocop_todo/rspec/any_instance_of.yml @@ -47,7 +47,6 @@ RSpec/AnyInstanceOf: - ee/spec/lib/gitlab/ci/templates/Jobs/load_performance_testing_gitlab_ci_yaml_spec.rb - ee/spec/lib/gitlab/ci/templates/Verify/browser_performance_testing_gitlab_ci_yaml_spec.rb - ee/spec/lib/gitlab/ci/templates/Verify/load_performance_testing_gitlab_ci_yaml_spec.rb - - ee/spec/lib/gitlab/ci/templates/api_fuzzing_gitlab_ci_yaml_spec.rb - ee/spec/lib/gitlab/ci/templates/container_scanning_gitlab_ci_yaml_spec.rb - ee/spec/lib/gitlab/ci/templates/coverage_fuzzing_gitlab_ci_yaml_spec.rb - ee/spec/lib/gitlab/ci/templates/dast_gitlab_ci_yaml_spec.rb @@ -59,14 +58,7 @@ RSpec/AnyInstanceOf: - ee/spec/lib/gitlab/geo/log_cursor/daemon_spec.rb - ee/spec/lib/gitlab/legacy_github_import/project_creator_spec.rb - ee/spec/lib/omni_auth/strategies/group_saml_spec.rb - - ee/spec/lib/security/ci_configuration/sast_build_actions_spec.rb - ee/spec/lib/system_check/geo/geo_database_configured_check_spec.rb - - ee/spec/migrations/schedule_populate_resolved_on_default_branch_column_spec.rb - - ee/spec/migrations/update_location_fingerprint_column_for_cs_spec.rb - - ee/spec/migrations/update_occurrence_severity_column_spec.rb - - ee/spec/migrations/update_undefined_confidence_from_occurrences_spec.rb - - ee/spec/migrations/update_undefined_confidence_from_vulnerabilities_spec.rb - - ee/spec/migrations/update_vulnerability_severity_column_spec.rb - ee/spec/models/ee/namespace_spec.rb - ee/spec/models/geo_node_status_spec.rb - ee/spec/models/issue_spec.rb @@ -74,23 +66,18 @@ RSpec/AnyInstanceOf: - ee/spec/models/project_import_state_spec.rb - ee/spec/models/push_rule_spec.rb - ee/spec/presenters/ci/pipeline_presenter_spec.rb - - ee/spec/presenters/projects/security/configuration_presenter_spec.rb - ee/spec/requests/api/geo_nodes_spec.rb - ee/spec/requests/api/graphql/mutations/dast_on_demand_scans/create_spec.rb - ee/spec/requests/api/graphql/mutations/dast_site_profiles/delete_spec.rb - - ee/spec/requests/api/graphql/mutations/pipelines/run_dast_scan_spec.rb - ee/spec/requests/api/issues_spec.rb - ee/spec/requests/api/projects_spec.rb - ee/spec/requests/git_http_spec.rb - ee/spec/requests/groups_controller_spec.rb - ee/spec/requests/omniauth_kerberos_spnego_spec.rb - ee/spec/requests/repositories/git_http_controller_spec.rb - - ee/spec/services/ci/expire_pipeline_cache_service_spec.rb - - ee/spec/services/ci/run_dast_scan_service_spec.rb - ee/spec/services/ee/git/branch_push_service_spec.rb - ee/spec/services/ee/merge_requests/create_from_vulnerability_data_service_spec.rb - ee/spec/services/ee/merge_requests/refresh_service_spec.rb - - ee/spec/services/ee/security/ingress_modsecurity_usage_service_spec.rb - ee/spec/services/ee/users/create_service_spec.rb - ee/spec/services/ee/users/destroy_service_spec.rb - ee/spec/services/geo/container_repository_sync_service_spec.rb @@ -118,7 +105,6 @@ RSpec/AnyInstanceOf: - ee/spec/support/shared_examples/models/member_shared_examples.rb - ee/spec/support/shared_examples/services/base_sync_service_shared_examples.rb - ee/spec/support/shared_examples/services/geo/geo_request_service_shared_examples.rb - - ee/spec/workers/build_finished_worker_spec.rb - ee/spec/workers/concerns/elastic/indexing_control_spec.rb - ee/spec/workers/elastic_commit_indexer_worker_spec.rb - ee/spec/workers/geo/design_repository_shard_sync_worker_spec.rb @@ -155,7 +141,6 @@ RSpec/AnyInstanceOf: - spec/controllers/projects/settings/integration_hook_logs_controller_spec.rb - spec/controllers/projects/settings/integrations_controller_spec.rb - spec/controllers/projects/tags_controller_spec.rb - - spec/controllers/registrations/experience_levels_controller_spec.rb - spec/controllers/registrations_controller_spec.rb - spec/controllers/sessions_controller_spec.rb - spec/controllers/snippets/notes_controller_spec.rb @@ -176,7 +161,6 @@ RSpec/AnyInstanceOf: - spec/features/projects/files/user_browses_lfs_files_spec.rb - spec/features/projects/jobs_spec.rb - spec/features/projects/navbar_spec.rb - - spec/features/projects/pages_spec.rb - spec/features/projects/settings/service_desk_setting_spec.rb - spec/features/projects/show/user_sees_setup_shortcut_buttons_spec.rb - spec/features/snippets/embedded_snippet_spec.rb @@ -190,7 +174,6 @@ RSpec/AnyInstanceOf: - spec/graphql/mutations/alert_management/prometheus_integration/create_spec.rb - spec/graphql/mutations/alert_management/prometheus_integration/reset_token_spec.rb - spec/graphql/mutations/alert_management/prometheus_integration/update_spec.rb - - spec/helpers/analytics/unique_visits_helper_spec.rb - spec/helpers/projects_helper_spec.rb - spec/initializers/lograge_spec.rb - spec/lib/api/entities/merge_request_basic_spec.rb @@ -211,8 +194,6 @@ RSpec/AnyInstanceOf: - spec/lib/gitlab/auth/blocked_user_tracker_spec.rb - spec/lib/gitlab/auth/request_authenticator_spec.rb - spec/lib/gitlab/auth_spec.rb - - spec/lib/gitlab/background_migration/populate_personal_snippet_statistics_spec.rb - - spec/lib/gitlab/background_migration/populate_project_snippet_statistics_spec.rb - spec/lib/gitlab/checks/diff_check_spec.rb - spec/lib/gitlab/checks/lfs_check_spec.rb - spec/lib/gitlab/checks/lfs_integrity_spec.rb @@ -231,8 +212,6 @@ RSpec/AnyInstanceOf: - spec/lib/gitlab/ci/templates/npm_spec.rb - spec/lib/gitlab/ci/trace_spec.rb - spec/lib/gitlab/current_settings_spec.rb - - spec/lib/gitlab/cycle_analytics/base_event_fetcher_spec.rb - - spec/lib/gitlab/database/multi_threaded_migration_spec.rb - spec/lib/gitlab/diff/highlight_cache_spec.rb - spec/lib/gitlab/diff/highlight_spec.rb - spec/lib/gitlab/diff/position_spec.rb @@ -272,10 +251,8 @@ RSpec/AnyInstanceOf: - spec/lib/gitlab/metrics/rack_middleware_spec.rb - spec/lib/gitlab/metrics/subscribers/active_record_spec.rb - spec/lib/gitlab/metrics_spec.rb - - spec/lib/gitlab/patch/action_dispatch_journey_formatter_spec.rb - spec/lib/gitlab/sidekiq_daemon/monitor_spec.rb - spec/lib/gitlab/sidekiq_middleware_spec.rb - - spec/lib/gitlab/tracking/destinations/product_analytics_spec.rb - spec/lib/gitlab/tracking/destinations/snowplow_spec.rb - spec/lib/gitlab/tracking_spec.rb - spec/lib/gitlab/usage_data_spec.rb @@ -335,21 +312,17 @@ RSpec/AnyInstanceOf: - spec/requests/git_http_spec.rb - spec/requests/import/gitlab_projects_controller_spec.rb - spec/routing/routing_spec.rb - - spec/serializers/analytics_stage_serializer_spec.rb - spec/serializers/merge_request_poll_cached_widget_entity_spec.rb - spec/serializers/merge_request_poll_widget_entity_spec.rb - spec/services/application_settings/update_service_spec.rb - spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb - spec/services/boards/lists/update_service_spec.rb - spec/services/ci/create_pipeline_service_spec.rb - - spec/services/ci/destroy_expired_job_artifacts_service_spec.rb - spec/services/ci/expire_pipeline_cache_service_spec.rb - spec/services/ci/list_config_variables_service_spec.rb - spec/services/ci/register_job_service_spec.rb - spec/services/ci/resource_groups/assign_resource_from_resource_group_service_spec.rb - - spec/services/ci/retry_build_service_spec.rb - spec/services/ci/retry_pipeline_service_spec.rb - - spec/services/ci/stop_environments_service_spec.rb - spec/services/clusters/applications/create_service_spec.rb - spec/services/clusters/cleanup/project_namespace_service_spec.rb - spec/services/clusters/cleanup/service_account_service_spec.rb @@ -380,9 +353,6 @@ RSpec/AnyInstanceOf: - spec/services/packages/conan/create_package_file_service_spec.rb - spec/services/packages/nuget/metadata_extraction_service_spec.rb - spec/services/packages/nuget/update_package_from_metadata_service_spec.rb - - spec/services/pages/delete_services_spec.rb - - spec/services/pod_logs/elasticsearch_service_spec.rb - - spec/services/pod_logs/kubernetes_service_spec.rb - spec/services/post_receive_service_spec.rb - spec/services/projects/after_rename_service_spec.rb - spec/services/projects/container_repository/cleanup_tags_service_spec.rb @@ -451,7 +421,6 @@ RSpec/AnyInstanceOf: - spec/support/shared_examples/uploaders/object_storage_shared_examples.rb - spec/support/shared_examples/workers/authorized_projects_worker_shared_example.rb - spec/support/shared_examples/workers/reactive_cacheable_shared_examples.rb - - spec/support/snowplow.rb - spec/tasks/gitlab/cleanup_rake_spec.rb - spec/tasks/gitlab/container_registry_rake_spec.rb - spec/tasks/gitlab/db_rake_spec.rb @@ -465,9 +434,7 @@ RSpec/AnyInstanceOf: - spec/views/layouts/_head.html.haml_spec.rb - spec/views/projects/artifacts/_artifact.html.haml_spec.rb - spec/workers/archive_trace_worker_spec.rb - - spec/workers/build_coverage_worker_spec.rb - spec/workers/build_hooks_worker_spec.rb - - spec/workers/build_trace_sections_worker_spec.rb - spec/workers/ci/build_schedule_worker_spec.rb - spec/workers/ci/daily_build_group_report_results_worker_spec.rb - spec/workers/cluster_configure_istio_worker_spec.rb @@ -481,14 +448,12 @@ RSpec/AnyInstanceOf: - spec/workers/email_receiver_worker_spec.rb - spec/workers/emails_on_push_worker_spec.rb - spec/workers/error_tracking_issue_link_worker_spec.rb - - spec/workers/expire_pipeline_cache_worker_spec.rb - spec/workers/group_export_worker_spec.rb - spec/workers/group_import_worker_spec.rb - spec/workers/namespaces/root_statistics_worker_spec.rb - spec/workers/new_note_worker_spec.rb - spec/workers/object_pool/create_worker_spec.rb - spec/workers/packages/nuget/extraction_worker_spec.rb - - spec/workers/pages_remove_worker_spec.rb - spec/workers/pipeline_hooks_worker_spec.rb - spec/workers/pipeline_process_worker_spec.rb - spec/workers/pipeline_schedule_worker_spec.rb diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index 0e313122b09..724aa420d89 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -154,7 +154,6 @@ RSpec/ContextWording: - 'ee/spec/features/groups/wiki/user_views_wiki_empty_spec.rb' - 'ee/spec/features/groups_spec.rb' - 'ee/spec/features/ide/user_opens_ide_spec.rb' - - 'ee/spec/features/incidents/incident_details_spec.rb' - 'ee/spec/features/integrations/jira/jira_issues_list_spec.rb' - 'ee/spec/features/issues/epic_in_issue_sidebar_spec.rb' - 'ee/spec/features/issues/filtered_search/filter_issues_by_iteration_spec.rb' @@ -223,7 +222,7 @@ RSpec/ContextWording: - 'ee/spec/features/trials/select_namespace_spec.rb' - 'ee/spec/features/users/login_spec.rb' - 'ee/spec/features/users/signup_spec.rb' - - 'ee/spec/finders/audit_log_finder_spec.rb' + - 'ee/spec/finders/audit_event_finder_spec.rb' - 'ee/spec/finders/autocomplete/vulnerabilities_autocomplete_finder_spec.rb' - 'ee/spec/finders/billed_users_finder_spec.rb' - 'ee/spec/finders/clusters/environments_finder_spec.rb' @@ -233,7 +232,6 @@ RSpec/ContextWording: - 'ee/spec/finders/dast_scanner_profiles_finder_spec.rb' - 'ee/spec/finders/dast_site_profiles_finder_spec.rb' - 'ee/spec/finders/dast_site_validations_finder_spec.rb' - - 'ee/spec/finders/ee/alert_management/alerts_finder_spec.rb' - 'ee/spec/finders/ee/alert_management/http_integrations_finder_spec.rb' - 'ee/spec/finders/ee/clusters/agent_authorizations_finder_spec.rb' - 'ee/spec/finders/ee/group_members_finder_spec.rb' @@ -487,11 +485,6 @@ RSpec/ContextWording: - 'ee/spec/lib/gitlab/geo/log_helpers_spec.rb' - 'ee/spec/lib/gitlab/geo/oauth/session_spec.rb' - 'ee/spec/lib/gitlab/geo/replication/blob_downloader_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/file_downloader_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/file_retriever_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/file_transfer_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/job_artifact_downloader_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/job_artifact_transfer_spec.rb' - 'ee/spec/lib/gitlab/geo/replicator_spec.rb' - 'ee/spec/lib/gitlab/geo/signed_data_spec.rb' - 'ee/spec/lib/gitlab/geo_spec.rb' @@ -501,7 +494,7 @@ RSpec/ContextWording: - 'ee/spec/lib/gitlab/gl_repository/repo_type_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/epics/epic_node_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_block_aggregate_spec.rb' + - 'ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_links_aggregate_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/security_orchestration_policies/lazy_dast_profile_aggregate_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/vulnerabilities/lazy_user_notes_count_aggregate_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/vulnerability_statistics/lazy_aggregate_spec.rb' @@ -875,11 +868,9 @@ RSpec/ContextWording: - 'ee/spec/services/ee/ci/job_artifacts/destroy_batch_service_spec.rb' - 'ee/spec/services/ee/git/branch_push_service_spec.rb' - 'ee/spec/services/ee/groups/autocomplete_service_spec.rb' - - 'ee/spec/services/ee/incident_management/issuable_escalation_statuses/after_update_service_spec.rb' - 'ee/spec/services/ee/integrations/test/project_service_spec.rb' - 'ee/spec/services/ee/ip_restrictions/update_service_spec.rb' - 'ee/spec/services/ee/issuable/bulk_update_service_spec.rb' - - 'ee/spec/services/ee/issuable/clone/attributes_rewriter_spec.rb' - 'ee/spec/services/ee/issuable/common_system_notes_service_spec.rb' - 'ee/spec/services/ee/issues/clone_service_spec.rb' - 'ee/spec/services/ee/issues/close_service_spec.rb' @@ -908,8 +899,6 @@ RSpec/ContextWording: - 'ee/spec/services/ee/protected_branches/create_service_spec.rb' - 'ee/spec/services/ee/quick_actions/target_service_spec.rb' - 'ee/spec/services/ee/resource_events/merge_into_notes_service_spec.rb' - - 'ee/spec/services/ee/service_ping/build_payload_service_spec.rb' - - 'ee/spec/services/ee/service_ping/permit_data_categories_service_spec.rb' - 'ee/spec/services/ee/users/build_service_spec.rb' - 'ee/spec/services/ee/users/create_service_spec.rb' - 'ee/spec/services/ee/users/destroy_service_spec.rb' @@ -936,9 +925,7 @@ RSpec/ContextWording: - 'ee/spec/services/geo/container_repository_sync_service_spec.rb' - 'ee/spec/services/geo/container_repository_sync_spec.rb' - 'ee/spec/services/geo/design_repository_sync_service_spec.rb' - - 'ee/spec/services/geo/file_download_service_spec.rb' - 'ee/spec/services/geo/file_registry_removal_service_spec.rb' - - 'ee/spec/services/geo/file_upload_service_spec.rb' - 'ee/spec/services/geo/framework_repository_sync_service_spec.rb' - 'ee/spec/services/geo/hashed_storage_migration_service_spec.rb' - 'ee/spec/services/geo/move_repository_service_spec.rb' @@ -990,7 +977,6 @@ RSpec/ContextWording: - 'ee/spec/services/merge_requests/merge_service_spec.rb' - 'ee/spec/services/merge_requests/update_blocks_service_spec.rb' - 'ee/spec/services/milestones/update_service_spec.rb' - - 'ee/spec/services/namespaces/check_storage_size_service_spec.rb' - 'ee/spec/services/namespaces/in_product_marketing_emails_service_spec.rb' - 'ee/spec/services/namespaces/storage/email_notification_service_spec.rb' - 'ee/spec/services/personal_access_tokens/revoke_invalid_tokens_spec.rb' @@ -1113,7 +1099,6 @@ RSpec/ContextWording: - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' - 'ee/spec/tasks/gitlab/license_rake_spec.rb' - 'ee/spec/tasks/gitlab/uploads/migrate_rake_spec.rb' - - 'ee/spec/uploaders/every_gitlab_uploader_spec.rb' - 'ee/spec/views/admin/application_settings/_elasticsearch_form.html.haml_spec.rb' - 'ee/spec/views/admin/users/show.html.haml_spec.rb' - 'ee/spec/views/compliance_management/compliance_framework/_project_settings.html.haml_spec.rb' @@ -1160,7 +1145,6 @@ RSpec/ContextWording: - 'ee/spec/workers/elastic_index_bulk_cron_worker_spec.rb' - 'ee/spec/workers/elastic_indexing_control_worker_spec.rb' - 'ee/spec/workers/geo/create_repository_updated_event_worker_spec.rb' - - 'ee/spec/workers/geo/file_download_dispatch_worker_spec.rb' - 'ee/spec/workers/geo/prune_event_log_worker_spec.rb' - 'ee/spec/workers/geo/repository_shard_sync_worker_spec.rb' - 'ee/spec/workers/geo/repository_sync_worker_spec.rb' @@ -1178,7 +1162,6 @@ RSpec/ContextWording: - 'ee/spec/workers/post_receive_spec.rb' - 'ee/spec/workers/project_import_schedule_worker_spec.rb' - 'ee/spec/workers/requirements_management/process_requirements_reports_worker_spec.rb' - - 'ee/spec/workers/security/generate_scan_finding_rules_worker_spec.rb' - 'ee/spec/workers/security/track_secure_scans_worker_spec.rb' - 'ee/spec/workers/store_security_reports_worker_spec.rb' - 'ee/spec/workers/sync_seat_link_request_worker_spec.rb' @@ -1414,7 +1397,6 @@ RSpec/ContextWording: - 'spec/features/admin/admin_mode/logout_spec.rb' - 'spec/features/admin/admin_mode/workers_spec.rb' - 'spec/features/admin/admin_mode_spec.rb' - - 'spec/features/admin/admin_runners_spec.rb' - 'spec/features/admin/admin_search_settings_spec.rb' - 'spec/features/admin/admin_settings_spec.rb' - 'spec/features/admin/dashboard_spec.rb' @@ -1461,7 +1443,6 @@ RSpec/ContextWording: - 'spec/features/groups/dependency_proxy_for_containers_spec.rb' - 'spec/features/groups/dependency_proxy_spec.rb' - 'spec/features/groups/empty_states_spec.rb' - - 'spec/features/groups/group_runners_spec.rb' - 'spec/features/groups/group_settings_spec.rb' - 'spec/features/groups/issues_spec.rb' - 'spec/features/groups/labels/subscription_spec.rb' @@ -1484,7 +1465,6 @@ RSpec/ContextWording: - 'spec/features/ics/project_issues_spec.rb' - 'spec/features/ide/clientside_preview_csp_spec.rb' - 'spec/features/ide/static_object_external_storage_csp_spec.rb' - - 'spec/features/incidents/incident_details_spec.rb' - 'spec/features/incidents/user_creates_new_incident_spec.rb' - 'spec/features/invites_spec.rb' - 'spec/features/issuables/markdown_references/internal_references_spec.rb' @@ -1656,8 +1636,6 @@ RSpec/ContextWording: - 'spec/features/projects/wiki/user_views_wiki_empty_spec.rb' - 'spec/features/projects_spec.rb' - 'spec/features/protected_branches_spec.rb' - - 'spec/features/refactor_blob_viewer_disabled/projects/blobs/blob_show_spec.rb' - - 'spec/features/refactor_blob_viewer_disabled/projects/blobs/edit_spec.rb' - 'spec/features/reportable_note/commit_spec.rb' - 'spec/features/reportable_note/merge_request_spec.rb' - 'spec/features/runners_spec.rb' @@ -1859,7 +1837,6 @@ RSpec/ContextWording: - 'spec/helpers/events_helper_spec.rb' - 'spec/helpers/git_helper_spec.rb' - 'spec/helpers/gitlab_routing_helper_spec.rb' - - 'spec/helpers/groups/crm_settings_helper_spec.rb' - 'spec/helpers/groups/group_members_helper_spec.rb' - 'spec/helpers/groups_helper_spec.rb' - 'spec/helpers/ide_helper_spec.rb' @@ -2239,7 +2216,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/database_spec.rb' - 'spec/lib/gitlab/default_branch_spec.rb' - 'spec/lib/gitlab/deploy_key_access_spec.rb' - - 'spec/lib/gitlab/diff/custom_diff_spec.rb' - 'spec/lib/gitlab/diff/file_collection/merge_request_diff_batch_spec.rb' - 'spec/lib/gitlab/diff/file_spec.rb' - 'spec/lib/gitlab/diff/formatters/text_formatter_spec.rb' @@ -2636,7 +2612,6 @@ RSpec/ContextWording: - 'spec/models/ci/deleted_object_spec.rb' - 'spec/models/ci/job_artifact_spec.rb' - 'spec/models/ci/job_token/project_scope_link_spec.rb' - - 'spec/models/ci/legacy_stage_spec.rb' - 'spec/models/ci/namespace_mirror_spec.rb' - 'spec/models/ci/pending_build_spec.rb' - 'spec/models/ci/pipeline_artifact_spec.rb' @@ -2657,7 +2632,6 @@ RSpec/ContextWording: - 'spec/models/clusters/agent_spec.rb' - 'spec/models/clusters/applications/cert_manager_spec.rb' - 'spec/models/clusters/applications/crossplane_spec.rb' - - 'spec/models/clusters/applications/elastic_stack_spec.rb' - 'spec/models/clusters/applications/helm_spec.rb' - 'spec/models/clusters/applications/ingress_spec.rb' - 'spec/models/clusters/applications/jupyter_spec.rb' @@ -2894,7 +2868,6 @@ RSpec/ContextWording: - 'spec/presenters/packages/conan/package_presenter_spec.rb' - 'spec/presenters/packages/npm/package_presenter_spec.rb' - 'spec/presenters/packages/nuget/service_index_presenter_spec.rb' - - 'spec/presenters/packages/pypi/package_presenter_spec.rb' - 'spec/presenters/project_member_presenter_spec.rb' - 'spec/presenters/project_presenter_spec.rb' - 'spec/presenters/projects/import_export/project_export_presenter_spec.rb' @@ -3168,7 +3141,6 @@ RSpec/ContextWording: - 'spec/serializers/cluster_application_entity_spec.rb' - 'spec/serializers/cluster_entity_spec.rb' - 'spec/serializers/context_commits_diff_entity_spec.rb' - - 'spec/serializers/deploy_key_entity_spec.rb' - 'spec/serializers/diff_file_base_entity_spec.rb' - 'spec/serializers/diff_file_entity_spec.rb' - 'spec/serializers/diff_file_metadata_entity_spec.rb' @@ -3330,7 +3302,6 @@ RSpec/ContextWording: - 'spec/services/incident_management/issuable_escalation_statuses/create_service_spec.rb' - 'spec/services/integrations/propagate_service_spec.rb' - 'spec/services/integrations/test/project_service_spec.rb' - - 'spec/services/issuable/clone/attributes_rewriter_spec.rb' - 'spec/services/issuable/common_system_notes_service_spec.rb' - 'spec/services/issue_links/list_service_spec.rb' - 'spec/services/issues/build_service_spec.rb' @@ -3483,7 +3454,6 @@ RSpec/ContextWording: - 'spec/services/projects/update_remote_mirror_service_spec.rb' - 'spec/services/projects/update_repository_storage_service_spec.rb' - 'spec/services/projects/update_service_spec.rb' - - 'spec/services/prometheus/create_default_alerts_service_spec.rb' - 'spec/services/prometheus/proxy_service_spec.rb' - 'spec/services/prometheus/proxy_variable_substitution_service_spec.rb' - 'spec/services/protected_tags/create_service_spec.rb' @@ -3682,7 +3652,6 @@ RSpec/ContextWording: - 'spec/support/shared_examples/models/cluster_application_helm_cert_shared_examples.rb' - 'spec/support/shared_examples/models/cluster_application_status_shared_examples.rb' - 'spec/support/shared_examples/models/cluster_application_version_shared_examples.rb' - - 'spec/support/shared_examples/models/clusters/elastic_stack_client_shared.rb' - 'spec/support/shared_examples/models/clusters/prometheus_client_shared.rb' - 'spec/support/shared_examples/models/concerns/can_move_repository_storage_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/composite_id_shared_examples.rb' @@ -3883,11 +3852,9 @@ RSpec/ContextWording: - 'spec/workers/deployments/update_environment_worker_spec.rb' - 'spec/workers/design_management/new_version_worker_spec.rb' - 'spec/workers/every_sidekiq_worker_spec.rb' - - 'spec/workers/expire_build_instance_artifacts_worker_spec.rb' - 'spec/workers/group_import_worker_spec.rb' - 'spec/workers/incident_management/process_alert_worker_v2_spec.rb' - 'spec/workers/integrations/create_external_cross_reference_worker_spec.rb' - - 'spec/workers/issue_placement_worker_spec.rb' - 'spec/workers/issues/placement_worker_spec.rb' - 'spec/workers/merge_requests/delete_source_branch_worker_spec.rb' - 'spec/workers/metrics/dashboard/prune_old_annotations_worker_spec.rb' @@ -3902,7 +3869,6 @@ RSpec/ContextWording: - 'spec/workers/projects/git_garbage_collect_worker_spec.rb' - 'spec/workers/projects/post_creation_worker_spec.rb' - 'spec/workers/projects/refresh_build_artifacts_size_statistics_worker_spec.rb' - - 'spec/workers/prometheus/create_default_alerts_worker_spec.rb' - 'spec/workers/purge_dependency_proxy_cache_worker_spec.rb' - 'spec/workers/remove_expired_group_links_worker_spec.rb' - 'spec/workers/remove_expired_members_worker_spec.rb' diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml index 3b4d463ad69..b08830bd5a3 100644 --- a/.rubocop_todo/rspec/expect_change.yml +++ b/.rubocop_todo/rspec/expect_change.yml @@ -151,7 +151,6 @@ RSpec/ExpectChange: - 'ee/spec/services/ee/groups/deploy_tokens/create_service_spec.rb' - 'ee/spec/services/ee/groups/deploy_tokens/destroy_service_spec.rb' - 'ee/spec/services/ee/groups/deploy_tokens/revoke_service_spec.rb' - - 'ee/spec/services/ee/issuable/clone/attributes_rewriter_spec.rb' - 'ee/spec/services/ee/issuable/common_system_notes_service_spec.rb' - 'ee/spec/services/ee/issues/create_service_spec.rb' - 'ee/spec/services/ee/issues/update_service_spec.rb' @@ -181,7 +180,6 @@ RSpec/ExpectChange: - 'ee/spec/services/external_status_checks/destroy_service_spec.rb' - 'ee/spec/services/external_status_checks/update_service_spec.rb' - 'ee/spec/services/geo/blob_download_service_spec.rb' - - 'ee/spec/services/geo/file_download_service_spec.rb' - 'ee/spec/services/geo/metrics_update_service_spec.rb' - 'ee/spec/services/geo/project_housekeeping_service_spec.rb' - 'ee/spec/services/geo/registry_consistency_service_spec.rb' @@ -190,7 +188,6 @@ RSpec/ExpectChange: - 'ee/spec/services/group_saml/identity/destroy_service_spec.rb' - 'ee/spec/services/group_saml/sign_up_service_spec.rb' - 'ee/spec/services/groups/mark_for_deletion_service_spec.rb' - - 'ee/spec/services/groups/recent_merge_requests_count_service_spec.rb' - 'ee/spec/services/groups/restore_service_spec.rb' - 'ee/spec/services/groups/sync_service_spec.rb' - 'ee/spec/services/incident_management/oncall_rotations/edit_service_spec.rb' @@ -201,7 +198,6 @@ RSpec/ExpectChange: - 'ee/spec/services/lfs/unlock_file_service_spec.rb' - 'ee/spec/services/merge_request_approval_settings/update_service_spec.rb' - 'ee/spec/services/merge_requests/update_blocks_service_spec.rb' - - 'ee/spec/services/namespaces/update_prevent_sharing_outside_hierarchy_service_spec.rb' - 'ee/spec/services/projects/import_service_spec.rb' - 'ee/spec/services/projects/mark_for_deletion_service_spec.rb' - 'ee/spec/services/projects/restore_service_spec.rb' @@ -242,7 +238,6 @@ RSpec/ExpectChange: - 'ee/spec/workers/elastic_remove_expired_namespace_subscriptions_from_index_cron_worker_spec.rb' - 'ee/spec/workers/geo/verification_state_backfill_service_spec.rb' - 'ee/spec/workers/new_epic_worker_spec.rb' - - 'ee/spec/workers/security/generate_scan_finding_rules_worker_spec.rb' - 'ee/spec/workers/store_security_reports_worker_spec.rb' - 'spec/controllers/admin/clusters_controller_spec.rb' - 'spec/controllers/admin/groups_controller_spec.rb' @@ -632,4 +627,3 @@ RSpec/ExpectChange: - 'spec/workers/update_highest_role_worker_spec.rb' - 'spec/workers/user_status_cleanup/batch_worker_spec.rb' - 'spec/workers/users/create_statistics_worker_spec.rb' - - 'spec/workers/web_hooks/destroy_worker_spec.rb' diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml index 09a6f5e6192..cd73b76b14e 100644 --- a/.rubocop_todo/rspec/expect_in_hook.yml +++ b/.rubocop_todo/rspec/expect_in_hook.yml @@ -30,7 +30,6 @@ RSpec/ExpectInHook: - 'ee/spec/helpers/billing_plans_helper_spec.rb' - 'ee/spec/helpers/ee/ci/runners_helper_spec.rb' - 'ee/spec/helpers/ee/issues_helper_spec.rb' - - 'ee/spec/helpers/ee/namespace_storage_limit_alert_helper_spec.rb' - 'ee/spec/helpers/ee/welcome_helper_spec.rb' - 'ee/spec/helpers/kerberos_spnego_helper_spec.rb' - 'ee/spec/helpers/vulnerabilities_helper_spec.rb' @@ -42,11 +41,10 @@ RSpec/ExpectInHook: - 'ee/spec/lib/gitlab/ci/minutes/cost_factor_spec.rb' - 'ee/spec/lib/gitlab/code_owners/validator_spec.rb' - 'ee/spec/lib/gitlab/code_owners_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/job_artifact_retriever_spec.rb' - 'ee/spec/lib/gitlab/geo_spec.rb' - 'ee/spec/lib/gitlab/git_access_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_block_aggregate_spec.rb' + - 'ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_links_aggregate_spec.rb' - 'ee/spec/lib/gitlab/mirror_spec.rb' - 'ee/spec/lib/gitlab/sitemaps/generator_spec.rb' - 'ee/spec/lib/gitlab/subscription_portal/clients/graphql_spec.rb' @@ -90,13 +88,11 @@ RSpec/ExpectInHook: - 'ee/spec/services/groups/update_repository_storage_service_spec.rb' - 'ee/spec/services/members/activate_service_spec.rb' - 'ee/spec/services/merge_requests/approval_service_spec.rb' - - 'ee/spec/services/namespaces/check_storage_size_service_spec.rb' - 'ee/spec/services/projects/create_from_template_service_spec.rb' - 'ee/spec/services/projects/mark_for_deletion_service_spec.rb' - 'ee/spec/services/projects/update_mirror_service_spec.rb' - 'ee/spec/services/security/findings/cleanup_service_spec.rb' - 'ee/spec/services/upcoming_reconciliations/update_service_spec.rb' - - 'ee/spec/support/shared_examples/controllers/namespace_storage_limit_alert_shared_examples.rb' - 'ee/spec/support/shared_examples/controllers/registrations/projects_controller_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/elastic/cannot_read_cross_project_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb' @@ -448,7 +444,6 @@ RSpec/ExpectInHook: - 'spec/services/packages/update_package_file_service_spec.rb' - 'spec/services/pages/zip_directory_service_spec.rb' - 'spec/services/pages_domains/obtain_lets_encrypt_certificate_service_spec.rb' - - 'spec/services/projects/after_import_service_spec.rb' - 'spec/services/projects/after_rename_service_spec.rb' - 'spec/services/projects/branches_by_mode_service_spec.rb' - 'spec/services/projects/container_repository/cleanup_tags_service_spec.rb' @@ -456,7 +451,6 @@ RSpec/ExpectInHook: - 'spec/services/projects/container_repository/gitlab/delete_tags_service_spec.rb' - 'spec/services/projects/container_repository/third_party/delete_tags_service_spec.rb' - 'spec/services/projects/create_from_template_service_spec.rb' - - 'spec/services/projects/destroy_rollback_service_spec.rb' - 'spec/services/projects/destroy_service_spec.rb' - 'spec/services/projects/import_export/export_service_spec.rb' - 'spec/services/projects/import_service_spec.rb' @@ -471,7 +465,6 @@ RSpec/ExpectInHook: - 'spec/services/protected_branches/create_service_spec.rb' - 'spec/services/protected_branches/destroy_service_spec.rb' - 'spec/services/protected_branches/update_service_spec.rb' - - 'spec/services/repositories/destroy_rollback_service_spec.rb' - 'spec/services/repositories/destroy_service_spec.rb' - 'spec/services/search_service_spec.rb' - 'spec/services/serverless/associate_domain_service_spec.rb' diff --git a/.rubocop_todo/rspec/instance_variable.yml b/.rubocop_todo/rspec/instance_variable.yml index 7489aca5b51..df62a8b0f87 100644 --- a/.rubocop_todo/rspec/instance_variable.yml +++ b/.rubocop_todo/rspec/instance_variable.yml @@ -14,7 +14,6 @@ RSpec/InstanceVariable: - ee/spec/graphql/types/vulnerability_request_type_spec.rb - ee/spec/graphql/types/vulnerability_response_type_spec.rb - ee/spec/helpers/ee/issuables_helper_spec.rb - - ee/spec/helpers/ee/namespace_storage_limit_alert_helper_spec.rb - ee/spec/helpers/ee/wiki_helper_spec.rb - ee/spec/helpers/notes_helper_spec.rb - ee/spec/helpers/search_helper_spec.rb @@ -72,7 +71,6 @@ RSpec/InstanceVariable: - qa/qa/specs/features/ee/browser_ui/2_plan/multiple_assignees_for_issues/more_than_four_assignees_spec.rb - qa/qa/specs/features/ee/browser_ui/3_create/repository/code_owners_spec.rb - qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb - - qa/qa/specs/features/ee/browser_ui/4_verify/cancelling_merge_request_in_merge_train_spec.rb - qa/spec/support/repeater_spec.rb - spec/commands/metrics_server/metrics_server_spec.rb - spec/controllers/admin/clusters_controller_spec.rb @@ -89,7 +87,6 @@ RSpec/InstanceVariable: - spec/controllers/profiles/avatars_controller_spec.rb - spec/controllers/projects/clusters_controller_spec.rb - spec/controllers/sessions_controller_spec.rb - - spec/features/admin/admin_runners_spec.rb - spec/features/calendar_spec.rb - spec/features/issues/user_filters_issues_spec.rb - spec/features/markdown/copy_as_gfm_spec.rb diff --git a/.rubocop_todo/rspec/multiple_memoized_helpers.yml b/.rubocop_todo/rspec/multiple_memoized_helpers.yml index 2f6d390bec2..8330d768794 100644 --- a/.rubocop_todo/rspec/multiple_memoized_helpers.yml +++ b/.rubocop_todo/rspec/multiple_memoized_helpers.yml @@ -1,11 +1,9 @@ --- RSpec/MultipleMemoizedHelpers: Exclude: - - spec/lib/gitlab/background_migration/populate_finding_uuid_for_vulnerability_feedback_spec.rb - spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb - spec/lib/gitlab/diff/position_tracer/line_strategy_spec.rb - spec/requests/api/ci/runner/jobs_artifacts_spec.rb - ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb - ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb - ee/spec/services/ee/boards/issues/move_service_spec.rb - - ee/spec/services/security/store_report_service_spec.rb diff --git a/.rubocop_todo/rspec/predicate_matcher.yml b/.rubocop_todo/rspec/predicate_matcher.yml index ebd11aeb449..c6a75708ae8 100644 --- a/.rubocop_todo/rspec/predicate_matcher.yml +++ b/.rubocop_todo/rspec/predicate_matcher.yml @@ -32,8 +32,6 @@ RSpec/PredicateMatcher: - 'ee/spec/lib/gitlab/email/handler/create_note_handler_spec.rb' - 'ee/spec/lib/gitlab/geo/geo_node_status_check_spec.rb' - 'ee/spec/lib/gitlab/geo/jwt_request_decoder_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/base_transfer_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/file_transfer_spec.rb' - 'ee/spec/lib/gitlab/geo/replicator_spec.rb' - 'ee/spec/lib/gitlab/geo_spec.rb' - 'ee/spec/lib/gitlab/mirror_spec.rb' @@ -72,7 +70,6 @@ RSpec/PredicateMatcher: - 'ee/spec/models/project_spec.rb' - 'ee/spec/models/saml_provider_spec.rb' - 'ee/spec/models/security/orchestration_policy_configuration_spec.rb' - - 'ee/spec/presenters/ci/minutes/quota_presenter_spec.rb' - 'ee/spec/requests/api/boards_spec.rb' - 'ee/spec/requests/api/graphql/mutations/epics/set_subscription_spec.rb' - 'ee/spec/requests/api/groups_spec.rb' @@ -250,7 +247,6 @@ RSpec/PredicateMatcher: - 'spec/lib/gitlab/dependency_linker/podspec_linker_spec.rb' - 'spec/lib/gitlab/dependency_linker/requirements_txt_linker_spec.rb' - 'spec/lib/gitlab/deploy_key_access_spec.rb' - - 'spec/lib/gitlab/diff/custom_diff_spec.rb' - 'spec/lib/gitlab/diff/file_spec.rb' - 'spec/lib/gitlab/diff/position_spec.rb' - 'spec/lib/gitlab/diff/rendered/notebook/diff_file_spec.rb' @@ -458,7 +454,6 @@ RSpec/PredicateMatcher: - 'spec/services/projects/after_rename_service_spec.rb' - 'spec/services/projects/cleanup_service_spec.rb' - 'spec/services/projects/create_service_spec.rb' - - 'spec/services/projects/destroy_rollback_service_spec.rb' - 'spec/services/projects/destroy_service_spec.rb' - 'spec/services/projects/fork_service_spec.rb' - 'spec/services/projects/hashed_storage/base_attachment_service_spec.rb' @@ -471,7 +466,6 @@ RSpec/PredicateMatcher: - 'spec/services/projects/update_pages_service_spec.rb' - 'spec/services/projects/update_service_spec.rb' - 'spec/services/releases/create_service_spec.rb' - - 'spec/services/repositories/destroy_rollback_service_spec.rb' - 'spec/services/repositories/destroy_service_spec.rb' - 'spec/services/repository_archive_clean_up_service_spec.rb' - 'spec/services/resource_access_tokens/revoke_service_spec.rb' @@ -506,7 +500,6 @@ RSpec/PredicateMatcher: - 'spec/workers/ci/delete_objects_worker_spec.rb' - 'spec/workers/concerns/worker_attributes_spec.rb' - 'spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb' - - 'spec/workers/expire_build_instance_artifacts_worker_spec.rb' - 'spec/workers/group_destroy_worker_spec.rb' - 'spec/workers/hashed_storage/migrator_worker_spec.rb' - 'spec/workers/hashed_storage/rollbacker_worker_spec.rb' diff --git a/.rubocop_todo/rspec/repeated_example_group_body.yml b/.rubocop_todo/rspec/repeated_example_group_body.yml index 87148442b08..6fdeb9a2094 100644 --- a/.rubocop_todo/rspec/repeated_example_group_body.yml +++ b/.rubocop_todo/rspec/repeated_example_group_body.yml @@ -1,8 +1,5 @@ --- RSpec/RepeatedExampleGroupBody: - # Offense count: 143 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'ee/spec/controllers/ee/groups_controller_spec.rb' - 'ee/spec/lib/banzai/filter/references/vulnerability_reference_filters_spec.rb' @@ -18,12 +15,10 @@ RSpec/RepeatedExampleGroupBody: - 'ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/update_spec.rb' - 'ee/spec/requests/groups/security/credentials_controller_spec.rb' - 'ee/spec/services/app_sec/dast/profiles/create_associations_service_spec.rb' - - 'ee/spec/services/groups/sync_service_spec.rb' - 'spec/controllers/groups/registry/repositories_controller_spec.rb' - 'spec/controllers/projects/blob_controller_spec.rb' - 'spec/controllers/projects/graphs_controller_spec.rb' - 'spec/controllers/projects/registry/repositories_controller_spec.rb' - - 'spec/features/incidents/incident_details_spec.rb' - 'spec/features/issues/spam_akismet_issue_creation_spec.rb' - 'spec/features/merge_request/user_sees_closing_issues_message_spec.rb' - 'spec/features/projects/commit/cherry_pick_spec.rb' @@ -31,6 +26,7 @@ RSpec/RepeatedExampleGroupBody: - 'spec/features/security/project/private_access_spec.rb' - 'spec/finders/packages/nuget/package_finder_spec.rb' - 'spec/helpers/gitlab_routing_helper_spec.rb' + - 'spec/helpers/groups_helper_spec.rb' - 'spec/lib/api/entities/application_setting_spec.rb' - 'spec/lib/banzai/filter/references/commit_range_reference_filter_spec.rb' - 'spec/lib/banzai/filter/references/commit_reference_filter_spec.rb' @@ -39,9 +35,9 @@ RSpec/RepeatedExampleGroupBody: - 'spec/lib/gitlab/ci/config/entry/release_spec.rb' - 'spec/lib/gitlab/ci/pipeline/seed/build_spec.rb' - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' + - 'spec/lib/gitlab/database/migrations/batched_background_migration_helpers_spec.rb' - 'spec/lib/gitlab/empty_search_results_spec.rb' - 'spec/lib/gitlab/import_export/project/sample/relation_factory_spec.rb' - - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' - 'spec/lib/gitlab/lfs/client_spec.rb' - 'spec/lib/gitlab/pagination/keyset/simple_order_builder_spec.rb' - 'spec/lib/gitlab/sanitizers/exif_spec.rb' diff --git a/.rubocop_todo/rspec/repeated_example_group_description.yml b/.rubocop_todo/rspec/repeated_example_group_description.yml index 562f5602d58..b5c4ac090ae 100644 --- a/.rubocop_todo/rspec/repeated_example_group_description.yml +++ b/.rubocop_todo/rspec/repeated_example_group_description.yml @@ -1,10 +1,8 @@ --- RSpec/RepeatedExampleGroupDescription: - # Offense count: 263 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'ee/spec/finders/merge_trains_finder_spec.rb' + - 'ee/spec/finders/security/vulnerability_reads_finder_spec.rb' - 'ee/spec/graphql/resolvers/vulnerabilities_grade_resolver_spec.rb' - 'ee/spec/graphql/resolvers/vulnerability_severities_count_resolver_spec.rb' - 'ee/spec/helpers/ee/auth_helper_spec.rb' @@ -24,16 +22,15 @@ RSpec/RepeatedExampleGroupDescription: - 'ee/spec/models/software_license_spec.rb' - 'ee/spec/policies/app_sec/fuzzing/coverage/corpus_policy_spec.rb' - 'ee/spec/policies/group_policy_spec.rb' - - 'ee/spec/policies/project_policy_spec.rb' - 'ee/spec/requests/api/graphql/iteration_spec.rb' - 'ee/spec/requests/api/graphql/mutations/iterations/create_spec.rb' - - 'ee/spec/requests/api/graphql/vulnerabilities/sort_spec.rb' - 'ee/spec/requests/groups/security/credentials_controller_spec.rb' + - 'ee/spec/requests/groups/settings/reporting_controller_spec.rb' - 'ee/spec/services/app_sec/dast/profiles/create_associations_service_spec.rb' - 'ee/spec/services/app_sec/dast/site_validations/find_or_create_service_spec.rb' - 'ee/spec/services/audit_event_service_spec.rb' - - 'ee/spec/services/groups/sync_service_spec.rb' - 'ee/spec/services/todo_service_spec.rb' + - 'ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb' - 'ee/spec/support/shared_examples/services/scoped_label_shared_examples.rb' - 'ee/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' - 'spec/controllers/profiles/notifications_controller_spec.rb' @@ -44,6 +41,7 @@ RSpec/RepeatedExampleGroupDescription: - 'spec/features/merge_request/user_sees_merge_widget_spec.rb' - 'spec/features/projects/jobs_spec.rb' - 'spec/features/projects/new_project_spec.rb' + - 'spec/features/projects/pipelines/legacy_pipeline_spec.rb' - 'spec/features/security/project/private_access_spec.rb' - 'spec/finders/ci/pipelines_for_merge_request_finder_spec.rb' - 'spec/frontend/fixtures/runner.rb' @@ -52,7 +50,6 @@ RSpec/RepeatedExampleGroupDescription: - 'spec/helpers/dropdowns_helper_spec.rb' - 'spec/helpers/gitlab_routing_helper_spec.rb' - 'spec/helpers/namespaces_helper_spec.rb' - - 'spec/initializers/omniauth_spec.rb' - 'spec/lib/banzai/pipeline/gfm_pipeline_spec.rb' - 'spec/lib/gitlab/alert_management/payload/base_spec.rb' - 'spec/lib/gitlab/auth/atlassian/auth_hash_spec.rb' @@ -69,14 +66,15 @@ RSpec/RepeatedExampleGroupDescription: - 'spec/lib/gitlab/ci/pipeline/seed/build_spec.rb' - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' - 'spec/lib/gitlab/data_builder/push_spec.rb' + - 'spec/lib/gitlab/database/migrations/batched_background_migration_helpers_spec.rb' - 'spec/lib/gitlab/database_importers/common_metrics/importer_spec.rb' - 'spec/lib/gitlab/git/diff_spec.rb' - 'spec/lib/gitlab/git/push_spec.rb' - 'spec/lib/gitlab/git/repository_spec.rb' - 'spec/lib/gitlab/import_export/project/sample/relation_factory_spec.rb' - - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' - 'spec/lib/gitlab/kubernetes/rollout_status_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/validator/errors_spec.rb' + - 'spec/lib/gitlab/redis/multi_store_spec.rb' - 'spec/lib/gitlab/sanitizers/exif_spec.rb' - 'spec/lib/gitlab/template/finders/global_template_finder_spec.rb' - 'spec/lib/gitlab/usage_data_spec.rb' @@ -93,8 +91,10 @@ RSpec/RepeatedExampleGroupDescription: - 'spec/models/project_spec.rb' - 'spec/models/ssh_host_key_spec.rb' - 'spec/requests/api/files_spec.rb' + - 'spec/requests/api/graphql/ci/runners_spec.rb' - 'spec/requests/api/graphql/project/release_spec.rb' - 'spec/requests/api/group_clusters_spec.rb' + - 'spec/requests/api/internal/base_spec.rb' - 'spec/requests/api/merge_requests_spec.rb' - 'spec/requests/api/notification_settings_spec.rb' - 'spec/requests/api/project_clusters_spec.rb' @@ -105,10 +105,10 @@ RSpec/RepeatedExampleGroupDescription: - 'spec/services/import/github_service_spec.rb' - 'spec/services/merge_requests/refresh_service_spec.rb' - 'spec/services/metrics/dashboard/gitlab_alert_embed_service_spec.rb' - - 'spec/services/resource_access_tokens/create_service_spec.rb' - 'spec/services/verify_pages_domain_service_spec.rb' - 'spec/support/cycle_analytics_helpers/test_generation.rb' - 'spec/support/shared_examples/models/application_setting_shared_examples.rb' + - 'spec/support/shared_examples/models/concerns/limitable_shared_examples.rb' - 'spec/support/shared_examples/requests/api/composer_packages_shared_examples.rb' - 'spec/support/shared_examples/serializers/diff_file_entity_shared_examples.rb' - 'spec/support/shared_examples/services/container_registry_auth_service_shared_examples.rb' diff --git a/.rubocop_todo/rspec/return_from_stub.yml b/.rubocop_todo/rspec/return_from_stub.yml index 2fb01b855be..21cd26a0a6f 100644 --- a/.rubocop_todo/rspec/return_from_stub.yml +++ b/.rubocop_todo/rspec/return_from_stub.yml @@ -21,7 +21,6 @@ RSpec/ReturnFromStub: - 'ee/spec/features/projects/pipelines/pipeline_spec.rb' - 'ee/spec/features/projects/settings/ee/service_desk_setting_spec.rb' - 'ee/spec/features/promotion_spec.rb' - - 'ee/spec/features/refactor_blob_viewer_disabled/projects/path_locks_spec.rb' - 'ee/spec/features/trials/select_namespace_spec.rb' - 'ee/spec/graphql/mutations/projects/set_locked_spec.rb' - 'ee/spec/helpers/application_helper_spec.rb' @@ -45,8 +44,6 @@ RSpec/ReturnFromStub: - 'ee/spec/lib/gitlab/code_owners_spec.rb' - 'ee/spec/lib/gitlab/geo/health_check_spec.rb' - 'ee/spec/lib/gitlab/geo/logger_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/base_transfer_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/file_transfer_spec.rb' - 'ee/spec/lib/gitlab/geo_spec.rb' - 'ee/spec/lib/gitlab/git_access_spec.rb' - 'ee/spec/lib/gitlab/git_access_wiki_spec.rb' @@ -71,7 +68,6 @@ RSpec/ReturnFromStub: - 'ee/spec/services/geo/design_repository_sync_service_spec.rb' - 'ee/spec/services/geo/files_expire_service_spec.rb' - 'ee/spec/services/geo/framework_repository_sync_service_spec.rb' - - 'ee/spec/services/geo/job_artifact_deleted_event_store_spec.rb' - 'ee/spec/services/geo/project_housekeeping_service_spec.rb' - 'ee/spec/services/geo/repository_base_sync_service_spec.rb' - 'ee/spec/services/geo/repository_updated_service_spec.rb' @@ -81,7 +77,6 @@ RSpec/ReturnFromStub: - 'ee/spec/services/merge_requests/build_service_spec.rb' - 'ee/spec/services/merge_trains/create_pipeline_service_spec.rb' - 'ee/spec/services/merge_trains/refresh_merge_request_service_spec.rb' - - 'ee/spec/services/network_policies/resources_service_spec.rb' - 'ee/spec/services/projects/hashed_storage/migrate_repository_service_spec.rb' - 'ee/spec/services/security/token_revocation_service_spec.rb' - 'ee/spec/services/system_notes/merge_train_service_spec.rb' @@ -99,7 +94,6 @@ RSpec/ReturnFromStub: - 'ee/spec/workers/ee/ci/build_finished_worker_spec.rb' - 'ee/spec/workers/geo/container_repository_sync_dispatch_worker_spec.rb' - 'ee/spec/workers/geo/design_repository_shard_sync_worker_spec.rb' - - 'ee/spec/workers/geo/file_download_dispatch_worker_spec.rb' - 'ee/spec/workers/geo/repository_shard_sync_worker_spec.rb' - 'ee/spec/workers/geo/repository_verification/primary/shard_worker_spec.rb' - 'ee/spec/workers/geo/repository_verification/primary/single_worker_spec.rb' diff --git a/.rubocop_todo/rspec/scattered_let.yml b/.rubocop_todo/rspec/scattered_let.yml index 52f19bf0768..069f9a15fff 100644 --- a/.rubocop_todo/rspec/scattered_let.yml +++ b/.rubocop_todo/rspec/scattered_let.yml @@ -42,7 +42,6 @@ RSpec/ScatteredLet: - 'ee/spec/models/approval_wrapped_any_approver_rule_spec.rb' - 'ee/spec/models/approvals/scan_finding_wrapped_rule_set_spec.rb' - 'ee/spec/models/ci/minutes/notification_spec.rb' - - 'ee/spec/models/ci/minutes/quota_spec.rb' - 'ee/spec/models/ci/pipeline_spec.rb' - 'ee/spec/models/ee/ci/build_dependencies_spec.rb' - 'ee/spec/models/ee/namespace/root_storage_size_spec.rb' @@ -157,7 +156,6 @@ RSpec/ScatteredLet: - 'spec/lib/gitlab/diff/position_tracer/line_strategy_spec.rb' - 'spec/lib/gitlab/diff/suggestion_diff_spec.rb' - 'spec/lib/gitlab/diff/suggestion_spec.rb' - - 'spec/lib/gitlab/elasticsearch/logs/lines_spec.rb' - 'spec/lib/gitlab/email/handler/service_desk_handler_spec.rb' - 'spec/lib/gitlab/error_tracking/processor/context_payload_processor_spec.rb' - 'spec/lib/gitlab/error_tracking_spec.rb' diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml index a69ab9198b1..84e862ff48b 100644 --- a/.rubocop_todo/rspec/verified_doubles.yml +++ b/.rubocop_todo/rspec/verified_doubles.yml @@ -82,17 +82,15 @@ RSpec/VerifiedDoubles: - ee/spec/lib/gitlab/geo/replicator_spec.rb - ee/spec/lib/gitlab/geo_spec.rb - ee/spec/lib/gitlab/git_access_spec.rb - - ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_block_aggregate_spec.rb + - ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_links_aggregate_spec.rb - ee/spec/lib/gitlab/import_export/group/relation_factory_spec.rb - ee/spec/lib/gitlab/middleware/ip_restrictor_spec.rb - - ee/spec/lib/gitlab/patch/legacy_database_config_spec.rb - ee/spec/lib/gitlab/prometheus/queries/cluster_query_spec.rb - ee/spec/lib/gitlab/subscription_portal/clients/rest_spec.rb - ee/spec/lib/sidebars/groups/menus/analytics_menu_spec.rb - ee/spec/lib/system_check/geo/geo_database_configured_check_spec.rb - ee/spec/models/app_sec/fuzzing/api/ci_configuration_spec.rb - ee/spec/models/approvable_spec.rb - - ee/spec/models/concerns/ee/sha_attribute_spec.rb - ee/spec/models/concerns/geo/verification_state_spec.rb - ee/spec/models/ee/ci/job_artifact_spec.rb - ee/spec/models/ee/user_spec.rb @@ -247,7 +245,6 @@ RSpec/VerifiedDoubles: - qa/spec/support/formatters/allure_metadata_formatter_spec.rb - qa/spec/support/page_error_checker_spec.rb - qa/spec/support/run_spec.rb - - qa/spec/support/shared_examples/scenario_shared_examples.rb - qa/spec/tools/long_running_spec_reporter_spec.rb - spec/benchmarks/banzai_benchmark.rb - spec/bin/feature_flag_spec.rb @@ -377,7 +374,6 @@ RSpec/VerifiedDoubles: - spec/lib/api/helpers_spec.rb - spec/lib/atlassian/jira_connect/client_spec.rb - spec/lib/backup/files_spec.rb - - spec/lib/backup/gitaly_rpc_backup_spec.rb - spec/lib/backup/repositories_spec.rb - spec/lib/banzai/cross_project_reference_spec.rb - spec/lib/banzai/filter/gollum_tags_filter_spec.rb @@ -400,7 +396,6 @@ RSpec/VerifiedDoubles: - spec/lib/bulk_imports/projects/pipelines/snippets_repository_pipeline_spec.rb - spec/lib/bulk_imports/projects/transformers/project_attributes_transformer_spec.rb - spec/lib/constraints/admin_constrainer_spec.rb - - spec/lib/constraints/feature_constrainer_spec.rb - spec/lib/constraints/group_url_constrainer_spec.rb - spec/lib/constraints/jira_encoded_url_constrainer_spec.rb - spec/lib/constraints/project_url_constrainer_spec.rb @@ -442,7 +437,6 @@ RSpec/VerifiedDoubles: - spec/lib/gitlab/ci/build/policy/variables_spec.rb - spec/lib/gitlab/ci/build/policy_spec.rb - spec/lib/gitlab/ci/build/prerequisite/kubernetes_namespace_spec.rb - - spec/lib/gitlab/ci/build/rules/rule/clause/changes_spec.rb - spec/lib/gitlab/ci/build/rules/rule_spec.rb - spec/lib/gitlab/ci/build/rules_spec.rb - spec/lib/gitlab/ci/build/status/reason_spec.rb @@ -647,7 +641,6 @@ RSpec/VerifiedDoubles: - spec/lib/gitlab/grape_logging/loggers/urgency_logger_spec.rb - spec/lib/gitlab/graphql/authorize/object_authorization_spec.rb - spec/lib/gitlab/graphql/batch_key_spec.rb - - spec/lib/gitlab/graphql/find_argument_in_parent_spec.rb - spec/lib/gitlab/graphql/generic_tracing_spec.rb - spec/lib/gitlab/graphql/lazy_spec.rb - spec/lib/gitlab/graphql/loaders/issuable_loader_spec.rb @@ -708,7 +701,6 @@ RSpec/VerifiedDoubles: - spec/lib/gitlab/metrics/elasticsearch_rack_middleware_spec.rb - spec/lib/gitlab/metrics/exporter/base_exporter_spec.rb - spec/lib/gitlab/metrics/exporter/gc_request_middleware_spec.rb - - spec/lib/gitlab/metrics/exporter/health_checks_middleware_spec.rb - spec/lib/gitlab/metrics/exporter/metrics_middleware_spec.rb - spec/lib/gitlab/metrics/rack_middleware_spec.rb - spec/lib/gitlab/metrics/requests_rack_middleware_spec.rb @@ -836,7 +828,6 @@ RSpec/VerifiedDoubles: - spec/models/concerns/atomic_internal_id_spec.rb - spec/models/concerns/legacy_bulk_insert_spec.rb - spec/models/concerns/prometheus_adapter_spec.rb - - spec/models/concerns/sha256_attribute_spec.rb - spec/models/concerns/sha_attribute_spec.rb - spec/models/concerns/token_authenticatable_strategies/base_spec.rb - spec/models/concerns/token_authenticatable_strategies/encrypted_spec.rb @@ -989,7 +980,6 @@ RSpec/VerifiedDoubles: - spec/services/ide/schemas_config_service_spec.rb - spec/services/import/bitbucket_server_service_spec.rb - spec/services/import/github_service_spec.rb - - spec/services/import/gitlab_projects/create_project_from_remote_file_service_spec.rb - spec/services/issues/create_service_spec.rb - spec/services/issues/related_branches_service_spec.rb - spec/services/jira_connect_subscriptions/create_service_spec.rb @@ -1008,7 +998,6 @@ RSpec/VerifiedDoubles: - spec/services/metrics/users_starred_dashboards/create_service_spec.rb - spec/services/milestones/update_service_spec.rb - spec/services/namespaces/in_product_marketing_emails_service_spec.rb - - spec/services/namespaces/invite_team_email_service_spec.rb - spec/services/notes/create_service_spec.rb - spec/services/notes/render_service_spec.rb - spec/services/notification_service_spec.rb @@ -1031,7 +1020,6 @@ RSpec/VerifiedDoubles: - spec/services/projects/update_service_spec.rb - spec/services/repositories/changelog_service_spec.rb - spec/services/search_service_spec.rb - - spec/services/service_ping/build_payload_service_spec.rb - spec/services/service_ping/submit_service_ping_service_spec.rb - spec/services/snippets/update_repository_storage_service_spec.rb - spec/services/spam/akismet_mark_as_spam_service_spec.rb diff --git a/.rubocop_todo/style/case_like_if.yml b/.rubocop_todo/style/case_like_if.yml index f1e349fe836..119ca3d800f 100644 --- a/.rubocop_todo/style/case_like_if.yml +++ b/.rubocop_todo/style/case_like_if.yml @@ -24,7 +24,6 @@ Style/CaseLikeIf: - 'ee/app/controllers/concerns/credentials_inventory_actions.rb' - 'ee/app/finders/ee/notes_finder.rb' - 'ee/app/helpers/ee/branches_helper.rb' - - 'ee/app/helpers/ee/namespace_storage_limit_alert_helper.rb' - 'ee/app/services/epics/tree_reorder_service.rb' - 'ee/app/services/merge_request_approval_settings/update_service.rb' - 'ee/lib/gitlab/alert_management/alert_payload_field_extractor.rb' @@ -34,7 +33,6 @@ Style/CaseLikeIf: - 'ee/spec/features/projects/custom_projects_template_spec.rb' - 'ee/spec/support/matchers/ee/epic_aggregate_matchers.rb' - 'lib/api/helpers/label_helpers.rb' - - 'lib/gitlab/analytics/unique_visits.rb' - 'lib/gitlab/ci/ansi2html.rb' - 'lib/gitlab/ci/ansi2json/converter.rb' - 'lib/gitlab/ci/build/image.rb' diff --git a/.rubocop_todo/style/empty_method.yml b/.rubocop_todo/style/empty_method.yml index aa3972a0b22..3e6a1efec70 100644 --- a/.rubocop_todo/style/empty_method.yml +++ b/.rubocop_todo/style/empty_method.yml @@ -61,7 +61,6 @@ Style/EmptyMethod: - 'app/controllers/registrations/welcome_controller.rb' - 'app/controllers/search_controller.rb' - 'app/graphql/resolvers/concerns/caching_array_resolver.rb' - - 'app/helpers/namespace_storage_limit_alert_helper.rb' - 'app/helpers/subscribable_banner_helper.rb' - 'app/helpers/users/callouts_helper.rb' - 'app/models/ci/bridge.rb' diff --git a/.rubocop_todo/style/explicit_block_argument.yml b/.rubocop_todo/style/explicit_block_argument.yml index f6bff468c76..e5ce2576f8c 100644 --- a/.rubocop_todo/style/explicit_block_argument.yml +++ b/.rubocop_todo/style/explicit_block_argument.yml @@ -16,7 +16,6 @@ Style/ExplicitBlockArgument: - 'app/models/merge_request.rb' - 'app/models/snippet_repository.rb' - 'app/services/import_export_clean_up_service.rb' - - 'app/services/issuable/clone/attributes_rewriter.rb' - 'app/services/packages/debian/generate_distribution_key_service.rb' - 'app/workers/concerns/each_shard_worker.rb' - 'db/migrate/20210629031900_associate_existing_dast_builds_with_variables.rb' diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml index a9065bb5932..caa293b31ae 100644 --- a/.rubocop_todo/style/format_string.yml +++ b/.rubocop_todo/style/format_string.yml @@ -165,8 +165,6 @@ Style/FormatString: - 'app/services/metrics/dashboard/update_dashboard_service.rb' - 'app/services/milestones/promote_service.rb' - 'app/services/personal_access_tokens/revoke_service.rb' - - 'app/services/pod_logs/elasticsearch_service.rb' - - 'app/services/pod_logs/kubernetes_service.rb' - 'app/services/projects/cleanup_service.rb' - 'app/services/projects/create_from_template_service.rb' - 'app/services/projects/import_service.rb' @@ -232,8 +230,6 @@ Style/FormatString: - 'ee/app/services/incident_management/escalation_policies/base_service.rb' - 'ee/app/services/issues/build_from_vulnerability_service.rb' - 'ee/app/services/merge_requests/create_from_vulnerability_data_service.rb' - - 'ee/app/services/namespaces/check_excess_storage_size_service.rb' - - 'ee/app/services/namespaces/check_storage_size_service.rb' - 'ee/app/services/security/security_orchestration_policies/policy_configuration_validation_service.rb' - 'ee/app/services/security/security_orchestration_policies/validate_policy_service.rb' - 'ee/app/services/timebox_report_service.rb' diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index c7109639677..7ee19ee164e 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -682,7 +682,6 @@ Style/GuardClause: - 'spec/deprecation_toolkit_env.rb' - 'spec/features/issuables/issuable_list_spec.rb' - 'spec/features/projects/blobs/edit_spec.rb' - - 'spec/features/refactor_blob_viewer_disabled/projects/blobs/edit_spec.rb' - 'spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb' - 'spec/services/issues/relative_position_rebalancing_service_spec.rb' - 'spec/services/packages/maven/metadata/append_package_file_service_spec.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index 645fc5f764c..1dfedcc91c0 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -153,7 +153,6 @@ Style/IfUnlessModifier: - 'app/models/ci/build.rb' - 'app/models/ci/build_trace_chunk.rb' - 'app/models/ci/job_artifact.rb' - - 'app/models/ci/legacy_stage.rb' - 'app/models/ci/pipeline.rb' - 'app/models/ci/runner.rb' - 'app/models/ci/running_build.rb' @@ -308,7 +307,6 @@ Style/IfUnlessModifier: - 'app/services/import/github_service.rb' - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file.rb' - 'app/services/issuable/bulk_update_service.rb' - - 'app/services/issuable/clone/attributes_rewriter.rb' - 'app/services/issuable/common_system_notes_service.rb' - 'app/services/issuable_base_service.rb' - 'app/services/issuable_links/create_service.rb' @@ -357,7 +355,6 @@ Style/IfUnlessModifier: - 'app/services/packages/pypi/create_package_service.rb' - 'app/services/packages/rubygems/dependency_resolver_service.rb' - 'app/services/pages/migrate_legacy_storage_to_deployment_service.rb' - - 'app/services/pod_logs/kubernetes_service.rb' - 'app/services/post_receive_service.rb' - 'app/services/projects/container_repository/gitlab/delete_tags_service.rb' - 'app/services/projects/container_repository/third_party/delete_tags_service.rb' @@ -716,7 +713,7 @@ Style/IfUnlessModifier: - 'ee/lib/gitlab/geo/replication/blob_downloader.rb' - 'ee/lib/gitlab/geo/replicator.rb' - 'ee/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate.rb' - - 'ee/lib/gitlab/graphql/aggregations/issues/lazy_block_aggregate.rb' + - 'ee/lib/gitlab/graphql/aggregations/issues/lazy_links_aggregate.rb' - 'ee/lib/gitlab/graphql/aggregations/security_orchestration_policies/lazy_dast_profile_aggregate.rb' - 'ee/lib/gitlab/graphql/aggregations/vulnerabilities/lazy_user_notes_count_aggregate.rb' - 'ee/lib/gitlab/graphql/aggregations/vulnerability_statistics/lazy_aggregate.rb' @@ -937,7 +934,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/database/with_lock_retries.rb' - 'lib/gitlab/diff/formatters/base_formatter.rb' - 'lib/gitlab/diff/rendered/notebook/diff_file.rb' - - 'lib/gitlab/elasticsearch/logs/lines.rb' - 'lib/gitlab/email/handler/service_desk_handler.rb' - 'lib/gitlab/email/message/in_product_marketing/base.rb' - 'lib/gitlab/email/message/repository_push.rb' @@ -1168,7 +1164,6 @@ Style/IfUnlessModifier: - 'spec/features/merge_request/batch_comments_spec.rb' - 'spec/features/merge_request/user_sees_avatar_on_diff_notes_spec.rb' - 'spec/features/projects/blobs/edit_spec.rb' - - 'spec/features/refactor_blob_viewer_disabled/projects/blobs/edit_spec.rb' - 'spec/graphql/mutations/releases/update_spec.rb' - 'spec/helpers/application_settings_helper_spec.rb' - 'spec/helpers/invite_members_helper_spec.rb' @@ -1251,7 +1246,6 @@ Style/IfUnlessModifier: - 'spec/views/projects/edit.html.haml_spec.rb' - 'spec/views/shared/access_tokens/_table.html.haml_spec.rb' - 'spec/workers/analytics/usage_trends/counter_job_worker_spec.rb' - - 'tooling/bin/qa/check_if_qa_only_spec_changes' - 'tooling/danger/product_intelligence.rb' - 'tooling/lib/tooling/image.rb' - 'tooling/lib/tooling/test_map_packer.rb' diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml index 487e0e7cd20..16ae8989c97 100644 --- a/.rubocop_todo/style/percent_literal_delimiters.yml +++ b/.rubocop_todo/style/percent_literal_delimiters.yml @@ -20,7 +20,6 @@ Style/PercentLiteralDelimiters: - 'app/controllers/jira_connect/app_descriptor_controller.rb' - 'app/controllers/jira_connect/subscriptions_controller.rb' - 'app/controllers/profiles/two_factor_auths_controller.rb' - - 'app/controllers/projects/logs_controller.rb' - 'app/controllers/projects/performance_monitoring/dashboards_controller.rb' - 'app/controllers/projects/product_analytics_controller.rb' - 'app/controllers/projects/service_desk_controller.rb' @@ -79,7 +78,6 @@ Style/PercentLiteralDelimiters: - 'app/models/bulk_imports/file_transfer/project_config.rb' - 'app/models/ci/build.rb' - 'app/models/ci/build_runner_session.rb' - - 'app/models/ci/legacy_stage.rb' - 'app/models/ci/pipeline.rb' - 'app/models/clusters/applications/cert_manager.rb' - 'app/models/clusters/platforms/kubernetes.rb' @@ -142,7 +140,6 @@ Style/PercentLiteralDelimiters: - 'app/models/resource_timebox_event.rb' - 'app/models/user.rb' - 'app/models/user_interacted_project.rb' - - 'app/models/users/in_product_marketing_email.rb' - 'app/policies/identity_provider_policy.rb' - 'app/presenters/dev_ops_report/metric_presenter.rb' - 'app/presenters/search_service_presenter.rb' @@ -166,8 +163,6 @@ Style/PercentLiteralDelimiters: - 'app/services/merge_requests/update_service.rb' - 'app/services/metrics/dashboard/default_embed_service.rb' - 'app/services/packages/debian/generate_distribution_service.rb' - - 'app/services/pod_logs/base_service.rb' - - 'app/services/pod_logs/elasticsearch_service.rb' - 'app/services/preview_markdown_service.rb' - 'app/services/projects/apple_target_platform_detector_service.rb' - 'app/services/projects/container_repository/cleanup_tags_service.rb' @@ -674,7 +669,6 @@ Style/PercentLiteralDelimiters: - 'spec/factories/ci/runners.rb' - 'spec/factories/clusters/applications/helm.rb' - 'spec/factories/clusters/clusters.rb' - - 'spec/factories/clusters/integrations/elastic_stack.rb' - 'spec/factories/clusters/integrations/prometheus.rb' - 'spec/factories/clusters/providers/aws.rb' - 'spec/factories/deployments.rb' @@ -692,7 +686,6 @@ Style/PercentLiteralDelimiters: - 'spec/features/projects/artifacts/user_downloads_artifacts_spec.rb' - 'spec/features/projects/branches_spec.rb' - 'spec/features/projects/environments/environment_spec.rb' - - 'spec/features/projects/environments_pod_logs_spec.rb' - 'spec/features/projects/integrations/user_activates_jira_spec.rb' - 'spec/features/projects/jobs_spec.rb' - 'spec/features/projects/labels/issues_sorted_by_priority_spec.rb' @@ -1003,7 +996,6 @@ Style/PercentLiteralDelimiters: - 'spec/models/project_setting_spec.rb' - 'spec/models/project_spec.rb' - 'spec/models/project_team_spec.rb' - - 'spec/models/project_tracing_setting_spec.rb' - 'spec/models/projects/topic_spec.rb' - 'spec/models/prometheus_metric_spec.rb' - 'spec/models/releases/link_spec.rb' @@ -1115,8 +1107,6 @@ Style/PercentLiteralDelimiters: - 'spec/services/packages/nuget/update_package_from_metadata_service_spec.rb' - 'spec/services/packages/update_tags_service_spec.rb' - 'spec/services/pages_domains/obtain_lets_encrypt_certificate_service_spec.rb' - - 'spec/services/pod_logs/base_service_spec.rb' - - 'spec/services/pod_logs/kubernetes_service_spec.rb' - 'spec/services/product_analytics/build_graph_service_spec.rb' - 'spec/services/projects/branches_by_mode_service_spec.rb' - 'spec/services/projects/container_repository/cleanup_tags_service_spec.rb' diff --git a/.rubocop_todo/style/redundant_regexp_escape.yml b/.rubocop_todo/style/redundant_regexp_escape.yml index 969a23601ca..cf502711f35 100644 --- a/.rubocop_todo/style/redundant_regexp_escape.yml +++ b/.rubocop_todo/style/redundant_regexp_escape.yml @@ -109,5 +109,4 @@ Style/RedundantRegexpEscape: - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb' - 'spec/uploaders/personal_file_uploader_spec.rb' - 'spec/views/help/index.html.haml_spec.rb' - - 'tooling/bin/qa/check_if_qa_only_spec_changes' - 'tooling/danger/project_helper.rb' diff --git a/.rubocop_todo/style/redundant_self.yml b/.rubocop_todo/style/redundant_self.yml index 1aba23c90ae..9951160ae02 100644 --- a/.rubocop_todo/style/redundant_self.yml +++ b/.rubocop_todo/style/redundant_self.yml @@ -143,7 +143,6 @@ Style/RedundantSelf: - 'app/models/project_group_link.rb' - 'app/models/project_import_data.rb' - 'app/models/project_label.rb' - - 'app/models/project_tracing_setting.rb' - 'app/models/prometheus_alert.rb' - 'app/models/protected_branch.rb' - 'app/models/protected_branch/push_access_level.rb' diff --git a/.rubocop_todo/style/symbol_proc.yml b/.rubocop_todo/style/symbol_proc.yml index 5e3aa10d9e5..ea3a505d2da 100644 --- a/.rubocop_todo/style/symbol_proc.yml +++ b/.rubocop_todo/style/symbol_proc.yml @@ -133,7 +133,7 @@ Style/SymbolProc: - 'ee/spec/helpers/ee/registrations_helper_spec.rb' - 'ee/spec/lib/ee/gitlab/search_results_spec.rb' - 'ee/spec/lib/gitlab/elastic/document_reference_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_block_aggregate_spec.rb' + - 'ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_links_aggregate_spec.rb' - 'ee/spec/models/ee/iterations/cadence_spec.rb' - 'ee/spec/services/groups/participants_service_spec.rb' - 'ee/spec/support/helpers/subscription_portal_helpers.rb' |