diff options
| author | Jacob Schatz <jschatz1@gmail.com> | 2016-03-15 16:52:53 +0000 |
|---|---|---|
| committer | Jacob Schatz <jschatz1@gmail.com> | 2016-03-15 16:52:53 +0000 |
| commit | 37707ac59e6c4e6db2b758338e13cb089dacd8c7 (patch) | |
| tree | b78a0d665fafde7b9d1ad6a3cc7795a3bc2b2e17 /.gitlab-ci.yml | |
| parent | 0602091f0cdebbc3183732dee78c38f89b4b7d01 (diff) | |
| parent | 8d8b457cebdfd0790157cd54fd1f24e46fbf0785 (diff) | |
| download | gitlab-ce-37707ac59e6c4e6db2b758338e13cb089dacd8c7.tar.gz | |
Merge branch 'css-style-guide' into 'master'
CSS style guide
Working towards what was discussed in #13552, this adds the [SCSS Linter gem](https://github.com/brigade/scss-lint) for style guide conformity in CI.
TODO:
- [x] Agree on and write SCSS Style Guide Documentation.
- [x] Document the `scss-lint` config file.
- [x] Figure out how best to run this in CI, right now it's taking longer than I would think it should.
- [x] Use CSSComb for auto-correction (Maybe just include a CSSComb config file and have developers run the node package manually if they're interested in using it?).
My logic for not using CSSComb in the first place is that, AFAIK, we don't currently require Node/NPM, even in the dev environment. Maybe I'm wrong about that? `scss-lint` is a Ruby implementation of a similar concept, but it doesn't include autocorrect.
Is there a way we can run get GitLab CI to run `scss-lint` without having to put together the full GitLab application? Seeing as it's just static analysis, it seems like a waste of time/resources.
/cc @jschatz1 @rspeicher
See merge request !3069
Diffstat (limited to '.gitlab-ci.yml')
| -rw-r--r-- | .gitlab-ci.yml | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index b4dad768fa4..2ad63548d78 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -122,6 +122,14 @@ rubocop: - ruby - mysql +scss-lint: + stage: test + script: + - bundle exec rake scss_lint + tags: + - ruby + allow_failure: true + brakeman: stage: test script: |