diff options
author | Andy Whitcroft <apw@shadowen.org> | 2007-01-08 15:58:23 +0000 |
---|---|---|
committer | Junio C Hamano <junkio@cox.net> | 2007-01-08 15:44:47 -0800 |
commit | 93822c2239a336e5cb583549071c59202ef6c5b2 (patch) | |
tree | f0c0a11adb226671e6e71803fa7d41d274aa7807 /unpack-file.c | |
parent | 93d26e4cb9cec2eb8abb4f37e6dda2c86fcceeac (diff) | |
download | git-93822c2239a336e5cb583549071c59202ef6c5b2.tar.gz |
short i/o: fix calls to write to use xwrite or write_in_full
We have a number of badly checked write() calls. Often we are
expecting write() to write exactly the size we requested or fail,
this fails to handle interrupts or short writes. Switch to using
the new write_in_full(). Otherwise we at a minimum need to check
for EINTR and EAGAIN, where this is appropriate use xwrite().
Note, the changes to config handling are much larger and handled
in the next patch in the sequence.
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'unpack-file.c')
-rw-r--r-- | unpack-file.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/unpack-file.c b/unpack-file.c index ccddf1d4b0..d24acc2a67 100644 --- a/unpack-file.c +++ b/unpack-file.c @@ -17,7 +17,7 @@ static char *create_temp_file(unsigned char *sha1) fd = mkstemp(path); if (fd < 0) die("unable to create temp-file"); - if (write(fd, buf, size) != size) + if (write_in_full(fd, buf, size) != size) die("unable to write temp-file"); close(fd); return path; |