summaryrefslogtreecommitdiff
path: root/t/t9139-git-svn-non-utf8-commitencoding.sh
diff options
context:
space:
mode:
authorEric Wong <normalperson@yhbt.net>2009-05-28 00:56:23 -0700
committerEric Wong <normalperson@yhbt.net>2009-05-28 00:57:07 -0700
commitb510df8af2c86d441de87fa4be09f786b5411527 (patch)
tree44ac92ead768529ffefe3f09db23426db2c9a647 /t/t9139-git-svn-non-utf8-commitencoding.sh
parent33fd7169ed6658e898b414a66aefaad16b404ec5 (diff)
downloadgit-b510df8af2c86d441de87fa4be09f786b5411527.tar.gz
git-svn: refuse to dcommit non-UTF-8 messages
...without i18n.commitencoding set in the config. SVN tries to store all commit messages in UTF-8, however it is up to the job of the clients to enforce this rule. SVN servers themselves do not always enforce this; allowing clients to commit malformed UTF-8 messages and break repositories. So git-svn will enforce this and tell the user to set i18n.commitencoding when a git commit is is not in UTF-8. Signed-off-by: Eric Wong <normalperson@yhbt.net>
Diffstat (limited to 't/t9139-git-svn-non-utf8-commitencoding.sh')
-rwxr-xr-xt/t9139-git-svn-non-utf8-commitencoding.sh47
1 files changed, 47 insertions, 0 deletions
diff --git a/t/t9139-git-svn-non-utf8-commitencoding.sh b/t/t9139-git-svn-non-utf8-commitencoding.sh
new file mode 100755
index 0000000000..2b1db97337
--- /dev/null
+++ b/t/t9139-git-svn-non-utf8-commitencoding.sh
@@ -0,0 +1,47 @@
+#!/bin/sh
+#
+# Copyright (c) 2009 Eric Wong
+
+test_description='git svn refuses to dcommit non-UTF8 messages'
+
+. ./lib-git-svn.sh
+
+# ISO-2022-JP can pass for valid UTF-8, so skipping that in this test
+
+for H in ISO-8859-1 EUCJP
+do
+ test_expect_success "$H setup" '
+ mkdir $H &&
+ svn_cmd import -m "$H test" $H "$svnrepo"/$H &&
+ git svn clone "$svnrepo"/$H $H
+ '
+done
+
+for H in ISO-8859-1 EUCJP
+do
+ test_expect_success "$H commit on git side" '
+ (
+ cd $H &&
+ git config i18n.commitencoding $H &&
+ git checkout -b t refs/remotes/git-svn &&
+ echo $H >F &&
+ git add F &&
+ git commit -a -F "$TEST_DIRECTORY"/t3900/$H.txt &&
+ E=$(git cat-file commit HEAD | sed -ne "s/^encoding //p") &&
+ test "z$E" = "z$H"
+ )
+ '
+done
+
+for H in ISO-8859-1 EUCJP
+do
+ test_expect_success "$H dcommit to svn" '
+ (
+ cd $H &&
+ git config --unset i18n.commitencoding &&
+ ! git svn dcommit
+ )
+ '
+done
+
+test_done