diff options
| author | Jeff King <peff@peff.net> | 2010-10-17 02:37:03 +0800 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2010-10-18 16:20:19 -0700 |
| commit | d7c411b71d727600d2f031fec9723873ae93c1c7 (patch) | |
| tree | cef120584580323d54a0e24d0006bf8f4df22a95 /t/t5523-push-upstream.sh | |
| parent | 8ac3ed27d4ca6b3c89c51e4d90e2e7be5de5ab15 (diff) | |
| download | git-d7c411b71d727600d2f031fec9723873ae93c1c7.tar.gz | |
push: pass --progress down to git-pack-objects
When pushing via builtin transports (like file://, git://), the
underlying transport helper (in this case, git-pack-objects) did not get
the --progress option, even if it was passed to git push.
Fix this, and update the tests to reflect this.
Note that according to the git-pack-objects documentation, we can safely
apply the usual --progress semantics for the transport commands like
clone and fetch (and for pushing over other smart transports).
Reported-by: Chase Brammer <cbrammer@gmail.com>
Helped-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5523-push-upstream.sh')
| -rwxr-xr-x | t/t5523-push-upstream.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/t/t5523-push-upstream.sh b/t/t5523-push-upstream.sh index f43d76063e..c229fe68f1 100755 --- a/t/t5523-push-upstream.sh +++ b/t/t5523-push-upstream.sh @@ -78,7 +78,7 @@ test_expect_success TTY 'progress messages go to tty' ' grep "Writing objects" err ' -test_expect_failure 'progress messages do not go to non-tty' ' +test_expect_success 'progress messages do not go to non-tty' ' ensure_fresh_upstream && # skip progress messages, since stderr is non-tty @@ -86,7 +86,7 @@ test_expect_failure 'progress messages do not go to non-tty' ' ! grep "Writing objects" err ' -test_expect_failure 'progress messages go to non-tty (forced)' ' +test_expect_success 'progress messages go to non-tty (forced)' ' ensure_fresh_upstream && # force progress messages to stderr, even though it is non-tty |