diff options
| author | Stefan Beller <sbeller@google.com> | 2018-12-14 16:09:38 -0800 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2018-12-28 10:06:33 -0800 |
| commit | 142e9f4432199cec5de418d74b37872d8330f696 (patch) | |
| tree | fe2e890d4b0486f469c330fe7ad7aa1035310f9e /submodule.c | |
| parent | 605f0ec1350477e53fd1a7774bad977257bf10d5 (diff) | |
| download | git-142e9f4432199cec5de418d74b37872d8330f696.tar.gz | |
submodule: don't add submodule as odb for push
In push_submodule(), because we do not actually need access to objects
in the submodule, do not invoke add_submodule_odb().
(for_each_remote_ref_submodule() does not require access to those
objects, and the actual push is done by spawning another process,
which handles object access by itself.)
This code of push_submodule() is exercised in t5531 and continues
to work, showing that the submodule odbc is not needed.
Signed-off-by: Stefan Beller <sbeller@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'submodule.c')
| -rw-r--r-- | submodule.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/submodule.c b/submodule.c index 4486ff664b..d9c06767a1 100644 --- a/submodule.c +++ b/submodule.c @@ -1023,9 +1023,6 @@ static int push_submodule(const char *path, const struct string_list *push_options, int dry_run) { - if (add_submodule_odb(path)) - return 1; - if (for_each_remote_ref_submodule(path, has_remote, NULL) > 0) { struct child_process cp = CHILD_PROCESS_INIT; argv_array_push(&cp.args, "push"); |