diff options
| author | Denton Liu <liu.denton@gmail.com> | 2019-04-29 04:28:14 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2019-05-05 15:20:06 +0900 |
| commit | 554544276a604c144df45efcb060c80aa322088c (patch) | |
| tree | ce55b3dc9ca47c326991ecfc06a2b1103f60be3a /streaming.h | |
| parent | ffac537e6cbbf934b08745a378932722df287a53 (diff) | |
| download | git-554544276a604c144df45efcb060c80aa322088c.tar.gz | |
*.[ch]: remove extern from function declarations using spatch
There has been a push to remove extern from function declarations.
Remove some instances of "extern" for function declarations which are
caught by Coccinelle. Note that Coccinelle has some difficulty with
processing functions with `__attribute__` or varargs so some `extern`
declarations are left behind to be dealt with in a future patch.
This was the Coccinelle patch used:
@@
type T;
identifier f;
@@
- extern
T f(...);
and it was run with:
$ git ls-files \*.{c,h} |
grep -v ^compat/ |
xargs spatch --sp-file contrib/coccinelle/noextern.cocci --in-place
Files under `compat/` are intentionally excluded as some are directly
copied from external sources and we should avoid churning them as much
as possible.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'streaming.h')
| -rw-r--r-- | streaming.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/streaming.h b/streaming.h index 32f4626771..f465a3cd31 100644 --- a/streaming.h +++ b/streaming.h @@ -8,10 +8,10 @@ /* opaque */ struct git_istream; -extern struct git_istream *open_istream(const struct object_id *, enum object_type *, unsigned long *, struct stream_filter *); -extern int close_istream(struct git_istream *); -extern ssize_t read_istream(struct git_istream *, void *, size_t); +struct git_istream *open_istream(const struct object_id *, enum object_type *, unsigned long *, struct stream_filter *); +int close_istream(struct git_istream *); +ssize_t read_istream(struct git_istream *, void *, size_t); -extern int stream_blob_to_fd(int fd, const struct object_id *, struct stream_filter *, int can_seek); +int stream_blob_to_fd(int fd, const struct object_id *, struct stream_filter *, int can_seek); #endif /* STREAMING_H */ |