summaryrefslogtreecommitdiff
path: root/strbuf.c
diff options
context:
space:
mode:
authorRené Scharfe <l.s.r@web.de>2017-06-14 20:24:25 +0200
committerJunio C Hamano <gitster@pobox.com>2017-06-15 11:40:53 -0700
commitfe9e2aefd4adac63821d0c007effcc8087e32ad6 (patch)
treeacc9011fb27de95e3e628f6efde92548812f9e99 /strbuf.c
parent840ed141983718e0c5518a325534a5656797132a (diff)
downloadgit-fe9e2aefd4adac63821d0c007effcc8087e32ad6.tar.gz
pretty: recalculate duplicate short hashesrs/pretty-add-again
b9c6232138 (--format=pretty: avoid calculating expensive expansions twice) optimized adding short hashes multiple times by using the fact that the output strbuf was only ever simply appended to and copying the added string from the previous run. That prerequisite is no longer given; we now have modfiers like %< and %+ that can cause the cache to lose track of the correct offsets. Remove it. Reported-by: Michael Giuffrida <michaelpg@chromium.org> Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'strbuf.c')
-rw-r--r--strbuf.c7
1 files changed, 0 insertions, 7 deletions
diff --git a/strbuf.c b/strbuf.c
index b839be491b..df2c113f21 100644
--- a/strbuf.c
+++ b/strbuf.c
@@ -204,13 +204,6 @@ void strbuf_addbuf(struct strbuf *sb, const struct strbuf *sb2)
strbuf_setlen(sb, sb->len + sb2->len);
}
-void strbuf_adddup(struct strbuf *sb, size_t pos, size_t len)
-{
- strbuf_grow(sb, len);
- memcpy(sb->buf + sb->len, sb->buf + pos, len);
- strbuf_setlen(sb, sb->len + len);
-}
-
void strbuf_addchars(struct strbuf *sb, int c, size_t n)
{
strbuf_grow(sb, n);