diff options
| author | Denton Liu <liu.denton@gmail.com> | 2019-04-29 04:28:14 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2019-05-05 15:20:06 +0900 |
| commit | 554544276a604c144df45efcb060c80aa322088c (patch) | |
| tree | ce55b3dc9ca47c326991ecfc06a2b1103f60be3a /sha1-lookup.h | |
| parent | ffac537e6cbbf934b08745a378932722df287a53 (diff) | |
| download | git-554544276a604c144df45efcb060c80aa322088c.tar.gz | |
*.[ch]: remove extern from function declarations using spatch
There has been a push to remove extern from function declarations.
Remove some instances of "extern" for function declarations which are
caught by Coccinelle. Note that Coccinelle has some difficulty with
processing functions with `__attribute__` or varargs so some `extern`
declarations are left behind to be dealt with in a future patch.
This was the Coccinelle patch used:
@@
type T;
identifier f;
@@
- extern
T f(...);
and it was run with:
$ git ls-files \*.{c,h} |
grep -v ^compat/ |
xargs spatch --sp-file contrib/coccinelle/noextern.cocci --in-place
Files under `compat/` are intentionally excluded as some are directly
copied from external sources and we should avoid churning them as much
as possible.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'sha1-lookup.h')
| -rw-r--r-- | sha1-lookup.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sha1-lookup.h b/sha1-lookup.h index 7678b23b36..457c9b4964 100644 --- a/sha1-lookup.h +++ b/sha1-lookup.h @@ -3,7 +3,7 @@ typedef const unsigned char *sha1_access_fn(size_t index, void *table); -extern int sha1_pos(const unsigned char *sha1, +int sha1_pos(const unsigned char *sha1, void *table, size_t nr, sha1_access_fn fn); |