summaryrefslogtreecommitdiff
path: root/run-command.h
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2015-03-22 06:00:32 -0400
committerJunio C Hamano <gitster@pobox.com>2015-03-22 15:55:31 -0700
commitd56d966b3b03d2849ef9e20cacd7965106e8fdf0 (patch)
treee2f36b3f06cfa36677c7aaa1660211242ff68396 /run-command.h
parent9a9592ff7c8a8f0e449515c158e4a5a4895c5c23 (diff)
downloadgit-d56d966b3b03d2849ef9e20cacd7965106e8fdf0.tar.gz
wt_status: fix signedness mismatch in strbuf_read call
We call strbuf_read(), and want to know whether we got any output. To do so, we assign the result to a size_t, and check whether it is non-zero. But strbuf_read returns a signed ssize_t. If it encounters an error, it will return -1, and we'll end up treating this the same as if we had gotten output. Instead, we can just check whether our buffer has anything in it (which is what we care about anyway, and is the same thing since we know the buffer was empty to begin with). Note that the "len" variable actually has two roles in this function. Now that we've eliminated the first, we can push the declaration closer to the point of use for the second one. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'run-command.h')
0 files changed, 0 insertions, 0 deletions