diff options
| author | Junio C Hamano <junkio@cox.net> | 2006-09-20 21:47:42 -0700 |
|---|---|---|
| committer | Junio C Hamano <junkio@cox.net> | 2006-09-20 21:47:42 -0700 |
| commit | cb5d709ff8a4bae19d57a470ba2b137c25938a44 (patch) | |
| tree | d64f4ca2150e36ed77e30df9a3c4261028d26ad2 /revision.c | |
| parent | cc4c4f0ce25cc3803197bc19c275fd6f59a2a511 (diff) | |
| download | git-cb5d709ff8a4bae19d57a470ba2b137c25938a44.tar.gz | |
Add callback data to for_each_ref() family.
This is a long overdue fix to the API for for_each_ref() family
of functions. It allows the callers to specify a callback data
pointer, so that the caller does not have to use static
variables to communicate with the callback funciton.
The updated for_each_ref() family takes a function of type
int (*fn)(const char *, const unsigned char *, void *)
and a void pointer as parameters, and calls the function with
the name of the ref and its SHA-1 with the caller-supplied void
pointer as parameters.
The commit updates two callers, builtin-name-rev.c and
builtin-pack-refs.c as an example.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'revision.c')
| -rw-r--r-- | revision.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/revision.c b/revision.c index 6a2539b623..0e84b8a0fb 100644 --- a/revision.c +++ b/revision.c @@ -466,7 +466,7 @@ static void limit_list(struct rev_info *revs) static int all_flags; static struct rev_info *all_revs; -static int handle_one_ref(const char *path, const unsigned char *sha1) +static int handle_one_ref(const char *path, const unsigned char *sha1, void *cb_data) { struct object *object = get_reference(all_revs, path, sha1, all_flags); add_pending_object(all_revs, object, ""); @@ -477,7 +477,7 @@ static void handle_all(struct rev_info *revs, unsigned flags) { all_revs = revs; all_flags = flags; - for_each_ref(handle_one_ref); + for_each_ref(handle_one_ref, NULL); } static int add_parents_only(struct rev_info *revs, const char *arg, int flags) |